mirror of
https://github.com/zed-industries/zed.git
synced 2025-01-24 11:01:54 +00:00
Fix regression causing guests to miss operations while opening a buffer
This commit is contained in:
parent
5403ab3fd2
commit
528a4dd9b4
1 changed files with 25 additions and 9 deletions
|
@ -524,11 +524,7 @@ impl Project {
|
||||||
// Record the fact that the buffer is no longer loading.
|
// Record the fact that the buffer is no longer loading.
|
||||||
this.loading_buffers.remove(&project_path);
|
this.loading_buffers.remove(&project_path);
|
||||||
let buffer = load_result.map_err(Arc::new)?;
|
let buffer = load_result.map_err(Arc::new)?;
|
||||||
this.open_buffers.insert(
|
this.register_buffer(&buffer, &worktree, cx)?;
|
||||||
buffer.read(cx).remote_id() as usize,
|
|
||||||
OpenBuffer::Loaded(buffer.downgrade()),
|
|
||||||
);
|
|
||||||
this.assign_language_to_buffer(&worktree, &buffer, cx);
|
|
||||||
Ok(buffer)
|
Ok(buffer)
|
||||||
}));
|
}));
|
||||||
})
|
})
|
||||||
|
@ -568,9 +564,7 @@ impl Project {
|
||||||
})
|
})
|
||||||
.await?;
|
.await?;
|
||||||
this.update(&mut cx, |this, cx| {
|
this.update(&mut cx, |this, cx| {
|
||||||
this.open_buffers
|
this.assign_language_to_buffer(&buffer, &worktree, cx);
|
||||||
.insert(buffer.id(), OpenBuffer::Loaded(buffer.downgrade()));
|
|
||||||
this.assign_language_to_buffer(&worktree, &buffer, cx);
|
|
||||||
});
|
});
|
||||||
Ok(())
|
Ok(())
|
||||||
})
|
})
|
||||||
|
@ -618,10 +612,32 @@ impl Project {
|
||||||
result
|
result
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn register_buffer(
|
||||||
|
&mut self,
|
||||||
|
buffer: &ModelHandle<Buffer>,
|
||||||
|
worktree: &ModelHandle<Worktree>,
|
||||||
|
cx: &mut ModelContext<Self>,
|
||||||
|
) -> Result<()> {
|
||||||
|
match self.open_buffers.insert(
|
||||||
|
buffer.read(cx).remote_id() as usize,
|
||||||
|
OpenBuffer::Loaded(buffer.downgrade()),
|
||||||
|
) {
|
||||||
|
Some(OpenBuffer::Operations(pending_ops)) => {
|
||||||
|
buffer.update(cx, |buf, cx| buf.apply_ops(pending_ops, cx))?;
|
||||||
|
}
|
||||||
|
Some(OpenBuffer::Loaded(_)) => {
|
||||||
|
return Err(anyhow!("registered the same buffer twice"));
|
||||||
|
}
|
||||||
|
None => {}
|
||||||
|
}
|
||||||
|
self.assign_language_to_buffer(&buffer, &worktree, cx);
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
fn assign_language_to_buffer(
|
fn assign_language_to_buffer(
|
||||||
&mut self,
|
&mut self,
|
||||||
worktree: &ModelHandle<Worktree>,
|
|
||||||
buffer: &ModelHandle<Buffer>,
|
buffer: &ModelHandle<Buffer>,
|
||||||
|
worktree: &ModelHandle<Worktree>,
|
||||||
cx: &mut ModelContext<Self>,
|
cx: &mut ModelContext<Self>,
|
||||||
) -> Option<()> {
|
) -> Option<()> {
|
||||||
let (path, full_path) = {
|
let (path, full_path) = {
|
||||||
|
|
Loading…
Reference in a new issue