diff --git a/crates/fs/src/repository.rs b/crates/fs/src/repository.rs index ce881d2b0f..6ead6f36b5 100644 --- a/crates/fs/src/repository.rs +++ b/crates/fs/src/repository.rs @@ -2,7 +2,7 @@ use anyhow::Result; use collections::HashMap; use parking_lot::Mutex; use std::{ - path::{Path, PathBuf}, + path::{Component, Path, PathBuf}, sync::Arc, }; @@ -27,7 +27,11 @@ impl GitRepository for LibGitRepository { fn logic(repo: &LibGitRepository, relative_file_path: &Path) -> Result> { const STAGE_NORMAL: i32 = 0; let index = repo.index()?; - let oid = match index.get_path(relative_file_path, STAGE_NORMAL) { + + // This check is required because index.get_path() unwraps internally :( + check_path_to_repo_path_errors(relative_file_path)?; + + let oid = match index.get_path(&relative_file_path, STAGE_NORMAL) { Some(entry) => entry.id, None => return Ok(None), }; @@ -69,3 +73,32 @@ impl GitRepository for FakeGitRepository { state.index_contents.get(path).cloned() } } + +fn check_path_to_repo_path_errors(relative_file_path: &Path) -> Result<()> { + match relative_file_path.components().next() { + None => anyhow::bail!("repo path should not be empty"), + Some(Component::Prefix(_)) => anyhow::bail!( + "repo path `{}` should be relative, not a windows prefix", + relative_file_path.to_string_lossy() + ), + Some(Component::RootDir) => { + anyhow::bail!( + "repo path `{}` should be relative", + relative_file_path.to_string_lossy() + ) + } + Some(Component::CurDir) => { + anyhow::bail!( + "repo path `{}` should not start with `.`", + relative_file_path.to_string_lossy() + ) + } + Some(Component::ParentDir) => { + anyhow::bail!( + "repo path `{}` should not start with `..`", + relative_file_path.to_string_lossy() + ) + } + _ => Ok(()), + } +}