mirrors/zed
1
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2025-01-24 11:01:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

supermaven: Fix crash when editing non-ASCII text (#19153)

Browse source 
Closes #19051
Closes #19182


#### How to reproduce this crash:
1. Open any file and input some ASCII characters.
2. Replace these characters with `你好`.
3. Press `backspace`.
4. Crash.



https://github.com/user-attachments/assets/ea5c5340-29a5-42c8-98c5-6e60770445a4



The issue lies with the `prefix_offset` introduced in #18858. After the
buffer is modified, this value is not always valid and may fall within a
`char boundary`, which results in a crash.



Release Notes:

- Fixed Supermaven crashing on deleting non-ASCII text
This commit is contained in:
张小白 2024-10-14 23:27:15 +08:00 committed by GitHub
parent 3ff52a816e
commit 6986f081d0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/supermaven/src/supermaven.rs
View file

@ -217,11 +217,11 @@ fn find_relevant_completion<'a>(
}; };
let current_cursor_offset = cursor_position.to_offset(buffer); let current_cursor_offset = cursor_position.to_offset(buffer);
let original_cursor_offset = state.prefix_offset; if current_cursor_offset < state.prefix_offset {
if current_cursor_offset < original_cursor_offset {
continue; continue;
} }
let original_cursor_offset = buffer.clip_offset(state.prefix_offset, text::Bias::Left);
let text_inserted_since_completion_request = let text_inserted_since_completion_request =
buffer.text_for_range(original_cursor_offset..current_cursor_offset); buffer.text_for_range(original_cursor_offset..current_cursor_offset);
let mut trimmed_completion = state_completion; let mut trimmed_completion = state_completion;