From 6d787379735268dd485b0a453485568052dc1462 Mon Sep 17 00:00:00 2001 From: Bennet Bo Fenner <53836821+bennetbo@users.noreply.github.com> Date: Mon, 25 Mar 2024 09:06:00 +0100 Subject: [PATCH] markdown preview: Insert missing line break on hard break (#9687) Closes #8990 For this input ``` Test \ Test ``` pulldown_cmark reports ``` Start(Paragraph) Text(Borrowed("Test ")) HardBreak Text(Borrowed("Test")) End(Paragraph) ``` Previously `Event::HardBreak` just marked the paragraph block as completed and ignored all the remaining text inside the paragraph. Before: See https://github.com/zed-industries/zed/issues/8990#issue-2173197637 After: ![image](https://github.com/zed-industries/zed/assets/53836821/48237ea6-d749-4207-89a3-b0f146b0e544) Release Notes: - Fixed markdown preview not handling hard breaks (e.g. `\`) correctly ([#8990](https://github.com/zed-industries/zed/issues/8990)). --- crates/markdown_preview/src/markdown_parser.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/markdown_preview/src/markdown_parser.rs b/crates/markdown_preview/src/markdown_parser.rs index 474cc0ac0f..1a950f5425 100644 --- a/crates/markdown_preview/src/markdown_parser.rs +++ b/crates/markdown_preview/src/markdown_parser.rs @@ -202,7 +202,7 @@ impl<'a> MarkdownParser<'a> { } Event::HardBreak => { - break; + text.push('\n'); } Event::Text(t) => {