mirrors/zed
1
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2024-10-25 07:55:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

Fix npm install command with a URI://localhost:port proxy setting (#11955)

Browse source 
NodeRuntime without environment information can not parse `localhost`
correctly.

Release Notes:

- N/A
This commit is contained in:
张小白 2024-05-17 16:30:52 +08:00 committed by GitHub
parent 5ad8e721db
commit 70888cf3d6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
crates/http/src/http.rs
View file

@ -58,7 +58,15 @@ impl HttpClientWithUrl {
/// Returns a new [`HttpClientWithUrl`] with the given base URL.
pub fn new(base_url: impl Into<String>, unparsed_proxy: Option<String>) -> Self {
let parsed_proxy = get_proxy(unparsed_proxy);
let proxy_string = parsed_proxy.as_ref().map(|p| p.to_string());
let proxy_string = parsed_proxy.as_ref().map(|p| {
// Map proxy settings from `http://localhost:10809` to `http://127.0.0.1:10809`
// NodeRuntime without environment information can not parse `localhost`
// correctly.
// TODO: map to `[::1]` if we are using ipv6
p.to_string()
.to_ascii_lowercase()
.replace("localhost", "127.0.0.1")
});
Self {
base_url: Mutex::new(base_url.into()),
client: client(parsed_proxy),