From 7599933f306aaea060a66ed5c96b606835833853 Mon Sep 17 00:00:00 2001 From: Marshall Bowers Date: Fri, 23 Feb 2024 20:58:45 -0500 Subject: [PATCH] Fix uploads to `edit_events` table (#8318) This PR fixes uploads the `edit_events` table. We were trying to insert into a column that didn't exist: ``` HTTP error 500 Internal Server Error: failed to upload to table 'edit_events' Caused by: bad response: Code: 16. DB::Exception: No such column os_name in table default.edit_events ``` Release Notes: - N/A --- crates/collab/src/api/events.rs | 8 -------- 1 file changed, 8 deletions(-) diff --git a/crates/collab/src/api/events.rs b/crates/collab/src/api/events.rs index c687cad648..1b1a58fb55 100644 --- a/crates/collab/src/api/events.rs +++ b/crates/collab/src/api/events.rs @@ -703,11 +703,6 @@ pub struct EditEventRow { patch: Option, release_channel: String, - // SystemInfoBase - os_name: String, - os_version: Option, - architecture: String, - // ClientEventBase installation_id: Option, // Note: This column name has a typo in the ClickHouse table. @@ -742,9 +737,6 @@ impl EditEventRow { minor: semver.map(|s| s.minor as i32), patch: semver.map(|s| s.patch as i32), release_channel: body.release_channel.clone().unwrap_or_default(), - os_name: body.os_name.clone(), - os_version: body.os_version.clone(), - architecture: body.architecture.clone(), installation_id: body.installation_id.clone(), session_id: body.session_id.clone(), is_staff: body.is_staff,