mirrors/zed
1
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2025-02-07 02:57:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Improve digit duplication

Browse source
This commit is contained in:
Marshall Bowers 2023-11-09 18:19:58 -05:00
parent 8f5adeb9c3
commit 82861e3123
1 changed files with 13 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
crates/gpui2/src/color.rs
View file

@ -127,19 +127,22 @@ impl TryFrom<&'_ str> for Rgba {
let (r, g, b, a) = match hex.len() { let (r, g, b, a) = match hex.len() {
RGB | RGBA => { RGB | RGBA => {
// There's likely a better way to handle 3 and 4-value hex codes without let r = u8::from_str_radix(&hex[0..1], 16)?;
// needing to use `.repeat` and incur additional allocations. let g = u8::from_str_radix(&hex[1..2], 16)?;
// What we probably want to do is parse the single hex digit and then perform let b = u8::from_str_radix(&hex[2..3], 16)?;
// bit-shifting to "duplicate" the digit.
let r = u8::from_str_radix(&hex[0..1].repeat(2), 16)?;
let g = u8::from_str_radix(&hex[1..2].repeat(2), 16)?;
let b = u8::from_str_radix(&hex[2..3].repeat(2), 16)?;
let a = if hex.len() == RGBA { let a = if hex.len() == RGBA {
u8::from_str_radix(&hex[3..4].repeat(2), 16)? u8::from_str_radix(&hex[3..4], 16)?
} else { } else {
0xff 0xf
}; };
(r, g, b, a)
/// Duplicates a given hex digit.
/// E.g., `0xf` -> `0xff`.
const fn duplicate(value: u8) -> u8 {
value << 4 | value
}
(duplicate(r), duplicate(g), duplicate(b), duplicate(a))
} }
RRGGBB | RRGGBBAA => { RRGGBB | RRGGBBAA => {
let r = u8::from_str_radix(&hex[0..2], 16)?; let r = u8::from_str_radix(&hex[0..2], 16)?;