mirrors/zed
1
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2024-12-24 17:28:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Fix filtering when providing non-admins info about channel members

Browse source
This commit is contained in:
Max Brunsfeld 2023-10-19 12:54:47 -07:00
parent 150ed641ae
commit 841cfac1f8
1 changed files with 12 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
crates/collab/src/db/queries/channels.rs
View file

@ -713,7 +713,7 @@ impl Database {
user_id: UserId, user_id: UserId,
) -> Result<Vec<proto::ChannelMember>> { ) -> Result<Vec<proto::ChannelMember>> {
self.transaction(|tx| async move { self.transaction(|tx| async move {
let role = self let user_role = self
.check_user_is_channel_member(channel_id, user_id, &*tx) .check_user_is_channel_member(channel_id, user_id, &*tx)
.await?; .await?;
@ -797,13 +797,19 @@ impl Database {
Ok(user_details Ok(user_details
.into_iter() .into_iter()
.filter_map(|(user_id, details)| { .filter_map(|(user_id, mut details)| {
// If the user is not an admin, don't give them all of the details // If the user is not an admin, don't give them as much
if role != ChannelRole::Admin { // information about the other members.
if details.kind == Kind::AncestorMember { if user_role != ChannelRole::Admin {
if details.kind == Kind::Invitee
|| details.channel_role == ChannelRole::Banned
{
return None; return None;
} }
return None;
if details.channel_role == ChannelRole::Admin {
details.channel_role = ChannelRole::Member;
}
} }
Some(proto::ChannelMember { Some(proto::ChannelMember {