Rename NewNotification proto message to AddNotification

This commit is contained in:
Max Brunsfeld 2023-10-19 13:29:14 -07:00
parent 33f06d3104
commit 851d7d0bc4
5 changed files with 8 additions and 5 deletions

View file

@ -242,6 +242,9 @@ impl ChannelChat {
})
}
/// Load all of the chat messages since a certain message id.
///
/// For now, we always maintain a suffix of the channel's messages.
pub async fn load_history_since_message(
chat: ModelHandle<Self>,
message_id: u64,

View file

@ -2934,7 +2934,7 @@ fn send_notifications(
for connection_id in connection_pool.user_connection_ids(user_id) {
if let Err(error) = peer.send(
connection_id,
proto::NewNotification {
proto::AddNotification {
notification: Some(notification.clone()),
},
) {

View file

@ -154,7 +154,7 @@ impl NotificationStore {
async fn handle_new_notification(
this: ModelHandle<Self>,
envelope: TypedEnvelope<proto::NewNotification>,
envelope: TypedEnvelope<proto::AddNotification>,
_: Arc<Client>,
cx: AsyncAppContext,
) -> Result<()> {

View file

@ -176,7 +176,7 @@ message Envelope {
MoveChannel move_channel = 147;
SetChannelVisibility set_channel_visibility = 148;
NewNotification new_notification = 149;
AddNotification add_notification = 149;
GetNotifications get_notifications = 150;
GetNotificationsResponse get_notifications_response = 151;
DeleteNotification delete_notification = 152;
@ -1610,7 +1610,7 @@ message GetNotifications {
optional uint64 before_id = 1;
}
message NewNotification {
message AddNotification {
Notification notification = 1;
}

View file

@ -135,6 +135,7 @@ messages!(
(Ack, Foreground),
(AckBufferOperation, Background),
(AckChannelMessage, Background),
(AddNotification, Foreground),
(AddProjectCollaborator, Foreground),
(ApplyCodeAction, Background),
(ApplyCodeActionResponse, Background),
@ -212,7 +213,6 @@ messages!(
(LinkChannel, Foreground),
(MarkNotificationsRead, Foreground),
(MoveChannel, Foreground),
(NewNotification, Foreground),
(OnTypeFormatting, Background),
(OnTypeFormattingResponse, Background),
(OpenBufferById, Background),