From 85b727c1a28b05d466169a7c6279e8b91fb84e87 Mon Sep 17 00:00:00 2001 From: "Joseph T. Lyons" Date: Mon, 13 Jan 2025 15:38:44 -0500 Subject: [PATCH] Remove inaccurate comments (#23056) These comments are inaccurate. Even if `convert_case` provided a way to customize which boundaries were used (which is now does, it 0.7.1), they would be removed from the string and replaced with the new boundary character (`-`, `_`, ...), and we'd lose the ability to reconstruct the text the way the author formatted it. This is not a hack, this is the way we have to do it. Release Notes: - N/A --- crates/editor/src/editor.rs | 4 ---- crates/editor/src/editor_tests.rs | 2 -- 2 files changed, 6 deletions(-) diff --git a/crates/editor/src/editor.rs b/crates/editor/src/editor.rs index 22d9650beb..4170f70d2b 100644 --- a/crates/editor/src/editor.rs +++ b/crates/editor/src/editor.rs @@ -6203,8 +6203,6 @@ impl Editor { pub fn convert_to_title_case(&mut self, _: &ConvertToTitleCase, cx: &mut ViewContext) { self.manipulate_text(cx, |text| { - // Hack to get around the fact that to_case crate doesn't support '\n' as a word boundary - // https://github.com/rutrum/convert-case/issues/16 text.split('\n') .map(|line| line.to_case(Case::Title)) .join("\n") @@ -6225,8 +6223,6 @@ impl Editor { cx: &mut ViewContext, ) { self.manipulate_text(cx, |text| { - // Hack to get around the fact that to_case crate doesn't support '\n' as a word boundary - // https://github.com/rutrum/convert-case/issues/16 text.split('\n') .map(|line| line.to_case(Case::UpperCamel)) .join("\n") diff --git a/crates/editor/src/editor_tests.rs b/crates/editor/src/editor_tests.rs index e477013e68..5770d0cf1a 100644 --- a/crates/editor/src/editor_tests.rs +++ b/crates/editor/src/editor_tests.rs @@ -3705,7 +3705,6 @@ async fn test_manipulate_text(cx: &mut TestAppContext) { "}); // Test multiple line, single selection case - // Test code hack that covers the fact that to_case crate doesn't support '\n' as a word boundary cx.set_state(indoc! {" «The quick brown fox jumps over @@ -3719,7 +3718,6 @@ async fn test_manipulate_text(cx: &mut TestAppContext) { "}); // Test multiple line, single selection case - // Test code hack that covers the fact that to_case crate doesn't support '\n' as a word boundary cx.set_state(indoc! {" «The quick brown fox jumps over