mirrors/zed
1
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2024-10-23 06:56:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

Deduplicate /tab all buffers inserted (#16681)
Some checks failed
CI / Check formatting and spelling (push) Has been cancelled
Details
CI / (macOS) Run Clippy and tests (push) Has been cancelled
Details
CI / (Linux) Run Clippy and tests (push) Has been cancelled
Details
CI / (Windows) Run Clippy and tests (push) Has been cancelled
Details
CI / Create a macOS bundle (push) Has been cancelled
Details
CI / Create a Linux bundle (push) Has been cancelled
Details
CI / Create arm64 Linux bundle (push) Has been cancelled
Details

Browse source 
Closes https://github.com/zed-industries/zed/issues/16678

Release Notes:

- Fixed `/tab all` inserting duplicate buffers
([!16678](https://github.com/zed-industries/zed/issues/16678))
This commit is contained in:
Kirill Bulatov 2024-08-22 19:04:03 +03:00 committed by Kirill Bulatov
parent 5321b10aa4
commit 8debea80f3
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
crates/assistant/src/slash_command/tab_command.rs
View file

@ -197,6 +197,7 @@ fn tab_items_for_queries(
}
let mut timestamps_by_entity_id = HashMap::default();
let mut visited_buffers = HashSet::default();
let mut open_buffers = Vec::new();
for pane in workspace.panes() {
@ -211,9 +212,11 @@ fn tab_items_for_queries(
if let Some(timestamp) =
timestamps_by_entity_id.get(&editor.entity_id())
{
let snapshot = buffer.read(cx).snapshot();
let full_path = snapshot.resolve_file_path(cx, true);
open_buffers.push((full_path, snapshot, *timestamp));
if visited_buffers.insert(buffer.read(cx).remote_id()) {
let snapshot = buffer.read(cx).snapshot();
let full_path = snapshot.resolve_file_path(cx, true);
open_buffers.push((full_path, snapshot, *timestamp));
}
}
}
}