From 9547e88d883d1f0187c2268a981aae2bb6c2d1a2 Mon Sep 17 00:00:00 2001 From: Conrad Irwin Date: Thu, 16 Nov 2023 19:50:31 -0700 Subject: [PATCH] TEMP --- crates/gpui2/src/elements/overlay.rs | 8 ++++---- crates/ui2/src/components/context_menu.rs | 6 +++--- crates/ui2/src/styled_ext.rs | 1 + 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/crates/gpui2/src/elements/overlay.rs b/crates/gpui2/src/elements/overlay.rs index 8580ae3eb0..4d3e8fdbf7 100644 --- a/crates/gpui2/src/elements/overlay.rs +++ b/crates/gpui2/src/elements/overlay.rs @@ -1,9 +1,9 @@ use smallvec::SmallVec; -use taffy::style::Position; +use taffy::style::{Display, Position}; use crate::{ - point, px, AbsoluteLength, AnyElement, BorrowWindow, Bounds, Component, Element, LayoutId, - ParentComponent, Pixels, Point, Size, Style, + point, AnyElement, BorrowWindow, Bounds, Component, Element, LayoutId, ParentComponent, Pixels, + Point, Size, Style, }; pub struct OverlayState { @@ -76,6 +76,7 @@ impl Element for Overlay { let mut overlay_style = Style::default(); overlay_style.position = Position::Absolute; + overlay_style.display = Display::Flex; let layout_id = cx.request_layout(&overlay_style, child_layout_ids.iter().copied()); @@ -108,7 +109,6 @@ impl Element for Overlay { origin: Point::zero(), size: cx.viewport_size(), }; - dbg!(bounds, desired, limits); match self.fit_mode { OverlayFitMode::SnapToWindow => { diff --git a/crates/ui2/src/components/context_menu.rs b/crates/ui2/src/components/context_menu.rs index 8024d334b5..5d4974e631 100644 --- a/crates/ui2/src/components/context_menu.rs +++ b/crates/ui2/src/components/context_menu.rs @@ -1,11 +1,11 @@ use std::cell::RefCell; use std::rc::Rc; -use crate::{h_stack, prelude::*, ListItemVariant}; +use crate::{prelude::*, ListItemVariant}; use crate::{v_stack, Label, List, ListEntry, ListItem, ListSeparator, ListSubHeader}; use gpui::{ - overlay, px, Action, AnyElement, Bounds, DispatchPhase, Div, EventEmitter, FocusHandle, - Focusable, FocusableView, LayoutId, MouseButton, MouseDownEvent, Overlay, Render, View, + overlay, px, Action, AnyElement, Bounds, DispatchPhase, EventEmitter, FocusHandle, + FocusableView, LayoutId, MouseButton, MouseDownEvent, Overlay, Render, View, }; use smallvec::SmallVec; diff --git a/crates/ui2/src/styled_ext.rs b/crates/ui2/src/styled_ext.rs index d9911e6833..9037682807 100644 --- a/crates/ui2/src/styled_ext.rs +++ b/crates/ui2/src/styled_ext.rs @@ -5,6 +5,7 @@ use crate::{ElevationIndex, UITextSize}; fn elevated(this: E, cx: &mut ViewContext, index: ElevationIndex) -> E { this.bg(cx.theme().colors().elevated_surface_background) + .z_index(index.z_index()) .rounded_lg() .border() .border_color(cx.theme().colors().border_variant)