mirrors/zed
1
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2025-01-10 20:41:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Do not reset timer for each reported event (#4079)

Browse source 
Always attempt to flush after the timeout period.

Release Notes:

- N/A
This commit is contained in:
Joseph T. Lyons 2024-01-16 18:44:02 -05:00 committed by GitHub
commit 9cd81ad255
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 11 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
crates/client/src/telemetry.rs
View file

@ -143,10 +143,10 @@ const MAX_QUEUE_LEN: usize = 5;
const MAX_QUEUE_LEN: usize = 50;
#[cfg(debug_assertions)]
const FLUSH_DEBOUNCE_INTERVAL: Duration = Duration::from_secs(1);
const FLUSH_INTERVAL: Duration = Duration::from_secs(1);
#[cfg(not(debug_assertions))]
const FLUSH_DEBOUNCE_INTERVAL: Duration = Duration::from_secs(60 * 5);
const FLUSH_INTERVAL: Duration = Duration::from_secs(60 * 5);
impl Telemetry {
pub fn new(client: Arc<dyn HttpClient>, cx: &mut AppContext) -> Arc<Self> {
@ -457,6 +457,15 @@ impl Telemetry {
return;
}
if state.flush_events_task.is_none() {
let this = self.clone();
let executor = self.executor.clone();
state.flush_events_task = Some(self.executor.spawn(async move {
executor.timer(FLUSH_INTERVAL).await;
this.flush_events();
}));
}
let signed_in = state.metrics_id.is_some();
state.events_queue.push(EventWrapper { signed_in, event });
@ -464,13 +473,6 @@ impl Telemetry {
if state.events_queue.len() >= MAX_QUEUE_LEN {
drop(state);
self.flush_events();
} else {
let this = self.clone();
let executor = self.executor.clone();
state.flush_events_task = Some(self.executor.spawn(async move {
executor.timer(FLUSH_DEBOUNCE_INTERVAL).await;
this.flush_events();
}));
}
}
}