From 9ea50ed6496c9a5452b44b21e44bfa0622f8a97e Mon Sep 17 00:00:00 2001 From: Marshall Bowers Date: Mon, 4 Mar 2024 12:22:11 -0500 Subject: [PATCH] Enable `clippy::iter_overeager_cloned` (#8839) This PR enables the [`clippy::iter_overeager_cloned`](https://rust-lang.github.io/rust-clippy/master/index.html#/iter_overeager_cloned) rule and fixes the outstanding violations. Release Notes: - N/A --- crates/language/src/syntax_map.rs | 9 ++++++--- tooling/xtask/src/main.rs | 1 - 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/crates/language/src/syntax_map.rs b/crates/language/src/syntax_map.rs index e517a9f092..926c4a36ed 100644 --- a/crates/language/src/syntax_map.rs +++ b/crates/language/src/syntax_map.rs @@ -614,9 +614,12 @@ impl SyntaxSnapshot { Some(old_tree.clone()), ); changed_ranges = join_ranges( - invalidated_ranges.iter().cloned().filter(|range| { - range.start <= step_end_byte && range.end >= step_start_byte - }), + invalidated_ranges + .iter() + .filter(|&range| { + range.start <= step_end_byte && range.end >= step_start_byte + }) + .cloned(), old_tree.changed_ranges(&tree).map(|r| { step_start_byte + r.start_byte..step_start_byte + r.end_byte }), diff --git a/tooling/xtask/src/main.rs b/tooling/xtask/src/main.rs index 1f075c59d4..69b6bc95bb 100644 --- a/tooling/xtask/src/main.rs +++ b/tooling/xtask/src/main.rs @@ -88,7 +88,6 @@ fn run_clippy(args: ClippyArgs) -> Result<()> { "clippy::derive_ord_xor_partial_ord", "clippy::eq_op", "clippy::implied_bounds_in_impls", - "clippy::iter_overeager_cloned", "clippy::let_underscore_future", "clippy::map_entry", "clippy::never_loop",