From 9f396948bb181f7b8f1e03343242d3a033fb102b Mon Sep 17 00:00:00 2001 From: Thorsten Ball Date: Tue, 12 Mar 2024 14:12:44 +0100 Subject: [PATCH] Improve error messages when fetching single GitHub release (#9219) Release Notes: - N/A --- crates/util/src/github.rs | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/crates/util/src/github.rs b/crates/util/src/github.rs index 7e2578214e..76891e1bd1 100644 --- a/crates/util/src/github.rs +++ b/crates/util/src/github.rs @@ -85,14 +85,19 @@ pub async fn github_release_with_tag( let mut response = http .get(&url, Default::default(), true) .await - .context("error fetching latest release")?; + .with_context(|| format!("error fetching release {} of {}", tag, repo_name_with_owner))?; let mut body = Vec::new(); response .body_mut() .read_to_end(&mut body) .await - .context("error reading latest release")?; + .with_context(|| { + format!( + "error reading response body for release {} of {}", + tag, repo_name_with_owner + ) + })?; if response.status().is_client_error() { let text = String::from_utf8_lossy(body.as_slice()); @@ -111,7 +116,11 @@ pub async fn github_release_with_tag( "GitHub API response text: {:?}", String::from_utf8_lossy(body.as_slice()) ); - return Err(anyhow!("error deserializing latest release")); + Err(anyhow!( + "error deserializing release {} of {}", + tag, + repo_name_with_owner + )) } } }