mirrors/zed
1
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2024-10-26 00:19:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Compile and instantiate wasm modules on a background thread (#11270)

Browse source 
Release Notes:

- Fixed a hang that could occur when loading some extensions, by loading
extensions on a background thread.
This commit is contained in:
Max Brunsfeld 2024-05-01 14:34:54 -07:00 committed by GitHub
parent fb0d2e948f
commit a194c0aa6e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
crates/extension/src/wasm_host.rs
View file

@ -106,9 +106,9 @@ impl WasmHost {
wasm_bytes: Vec<u8>, wasm_bytes: Vec<u8>,
manifest: Arc<ExtensionManifest>, manifest: Arc<ExtensionManifest>,
executor: BackgroundExecutor, executor: BackgroundExecutor,
) -> impl 'static + Future<Output = Result<WasmExtension>> { ) -> Task<Result<WasmExtension>> {
let this = self.clone(); let this = self.clone();
async move { executor.clone().spawn(async move {
let zed_api_version = parse_wasm_extension_version(&manifest.id, &wasm_bytes)?; let zed_api_version = parse_wasm_extension_version(&manifest.id, &wasm_bytes)?;
let component = Component::from_binary(&this.engine, &wasm_bytes) let component = Component::from_binary(&this.engine, &wasm_bytes)
@ -147,7 +147,7 @@ impl WasmHost {
tx, tx,
zed_api_version, zed_api_version,
}) })
} })
} }
async fn build_wasi_ctx(&self, manifest: &Arc<ExtensionManifest>) -> Result<wasi::WasiCtx> { async fn build_wasi_ctx(&self, manifest: &Arc<ExtensionManifest>) -> Result<wasi::WasiCtx> {