From c03600c55ecde723f721ce6cf2456dd8f674379f Mon Sep 17 00:00:00 2001 From: Nathan Sobo Date: Tue, 28 May 2024 20:31:58 -0600 Subject: [PATCH] Stop silently appending a system prompt for edit formatting (#12407) We should reintroduce this as part of the prompt library. Release Notes: - Removed an over-eager system prompt from the assistant that was causing misbehavior. Going forward, our intent is to always let you observe and edit text before we send it. --------- Co-authored-by: Marshall --- crates/assistant/src/assistant_panel.rs | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/crates/assistant/src/assistant_panel.rs b/crates/assistant/src/assistant_panel.rs index c12986787c..a6db195c8a 100644 --- a/crates/assistant/src/assistant_panel.rs +++ b/crates/assistant/src/assistant_panel.rs @@ -2103,16 +2103,10 @@ impl Conversation { } fn to_completion_request(&self, cx: &mut ModelContext) -> LanguageModelRequest { - let edits_system_prompt = LanguageModelRequestMessage { - role: Role::System, - content: include_str!("./system_prompts/edits.md").to_string(), - }; - - let messages = Some(edits_system_prompt).into_iter().chain( - self.messages(cx) - .filter(|message| matches!(message.status, MessageStatus::Done)) - .map(|message| message.to_request_message(self.buffer.read(cx))), - ); + let messages = self + .messages(cx) + .filter(|message| matches!(message.status, MessageStatus::Done)) + .map(|message| message.to_request_message(self.buffer.read(cx))); LanguageModelRequest { model: self.model.clone(),