mirrors/zed
1
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2025-02-06 10:42:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

pane: Do not autopin new item created as a neighbour of pinned tab (#18072)

Browse source 
When I used editor::NewFile or ProjectSearch from a pinned tab, the
resulting new tab would be pinned (and the last pinned tab would be
pushed off). This PR fixes it by always storing new tabs outside of the
pinned area if there's no destination index for the new tab.

Release Notes:

- Fixed tab bar not preserving pinned tab state when an editor::NewFile
action is executed.
This commit is contained in:
Piotr Osiewicz 2024-09-19 17:00:26 +02:00 committed by GitHub
parent d91e62524f
commit d2894ce9c9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
crates/workspace/src/pane.rs
View file

@ -831,13 +831,14 @@ impl Pane {
}
}
}
// If no destination index is specified, add or move the item after the active item.
// If no destination index is specified, add or move the item after the
// active item (or at the start of tab bar, if the active item is pinned)
let mut insertion_index = {
cmp::min(
if let Some(destination_index) = destination_index {
destination_index
} else {
self.active_item_index + 1
cmp::max(self.active_item_index + 1, self.pinned_count())
},
self.items.len(),
)