From d8cb0e8a2afe5eff4edfe6fd57a4b86f1d823123 Mon Sep 17 00:00:00 2001 From: Conrad Irwin Date: Thu, 14 Dec 2023 10:36:16 -0700 Subject: [PATCH] Fix z-indexes in editor element * Ensure that scroll events from blocks scroll the editor * Ensure that scroll bars show behind hover things --- crates/editor2/src/element.rs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/crates/editor2/src/element.rs b/crates/editor2/src/element.rs index 2b6db125da..b0341e2d4b 100644 --- a/crates/editor2/src/element.rs +++ b/crates/editor2/src/element.rs @@ -1095,7 +1095,7 @@ impl EditorElement { } }); - cx.with_z_index(1, |cx| { + cx.with_z_index(2, |cx| { if let Some((position, mut context_menu)) = layout.context_menu.take() { let available_space = size(AvailableSpace::MinContent, AvailableSpace::MinContent); @@ -2825,14 +2825,16 @@ impl Element for EditorElement { self.paint_text(text_bounds, &mut layout, cx); if !layout.blocks.is_empty() { - cx.with_z_index(1, |cx| { + // z-index of 0 so that it is on the same mouse event layer as the editor's + // mouse events + cx.with_z_index(0, |cx| { cx.with_element_id(Some("editor_blocks"), |cx| { self.paint_blocks(bounds, &mut layout, cx); }); }) } - cx.with_z_index(2, |cx| self.paint_scrollbar(bounds, &mut layout, cx)); + cx.with_z_index(1, |cx| self.paint_scrollbar(bounds, &mut layout, cx)); }); }); })