From da9601c69851b2b9c2997611d4834307a2d6b5f9 Mon Sep 17 00:00:00 2001 From: Marshall Bowers Date: Mon, 9 Sep 2024 17:49:40 -0400 Subject: [PATCH] markdown: Handle definition lists in parser (#17617) Resolves https://github.com/zed-industries/zed/issues/17607. This PR makes it so the Markdown parser can handle Markdown containing definition lists. Note that this is just parser support, we aren't yet doing anything with the definition lists themselves. Release Notes: - N/A --- crates/markdown/src/parser.rs | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/crates/markdown/src/parser.rs b/crates/markdown/src/parser.rs index cb83b2356e..3dd11be983 100644 --- a/crates/markdown/src/parser.rs +++ b/crates/markdown/src/parser.rs @@ -232,6 +232,10 @@ pub enum MarkdownTag { /// A metadata block. MetadataBlock(MetadataBlockKind), + + DefinitionList, + DefinitionListTitle, + DefinitionListDefinition, } #[derive(Clone, Debug, PartialEq)] @@ -317,11 +321,9 @@ impl From> for MarkdownTag { }, pulldown_cmark::Tag::HtmlBlock => MarkdownTag::HtmlBlock, pulldown_cmark::Tag::MetadataBlock(kind) => MarkdownTag::MetadataBlock(kind), - pulldown_cmark::Tag::DefinitionList - | pulldown_cmark::Tag::DefinitionListTitle - | pulldown_cmark::Tag::DefinitionListDefinition => { - unimplemented!("definition lists are not yet supported") - } + pulldown_cmark::Tag::DefinitionList => MarkdownTag::DefinitionList, + pulldown_cmark::Tag::DefinitionListTitle => MarkdownTag::DefinitionListTitle, + pulldown_cmark::Tag::DefinitionListDefinition => MarkdownTag::DefinitionListDefinition, } } }