From e6fe12d0e1e37cbc94226b397bdd100e837f805e Mon Sep 17 00:00:00 2001 From: Drew Ridley <47063089+DrewRidley@users.noreply.github.com> Date: Fri, 3 Jan 2025 17:52:08 -0500 Subject: [PATCH] assistant: Remove outdated settings update path (#21672) Removed a settings update that should have been removed in the 0.148.0 release. I am not sure if there is a tracking issue, but I identified this check for outdated settings that should not be needed anymore. I investigated a bit and did not find any conflicts or UB as a result of removing this code. Release Notes: - N/A --------- Co-authored-by: Marshall Bowers --- crates/assistant/src/assistant.rs | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/crates/assistant/src/assistant.rs b/crates/assistant/src/assistant.rs index 6d619a76b9..33c12088a7 100644 --- a/crates/assistant/src/assistant.rs +++ b/crates/assistant/src/assistant.rs @@ -37,7 +37,7 @@ pub use prompts::PromptBuilder; use prompts::PromptLoadingParams; use semantic_index::{CloudEmbeddingProvider, SemanticDb}; use serde::{Deserialize, Serialize}; -use settings::{update_settings_file, Settings, SettingsStore}; +use settings::{Settings, SettingsStore}; use slash_command::search_command::SearchSlashCommandFeatureFlag; use slash_command::{ auto_command, cargo_workspace_command, default_command, delta_command, diagnostics_command, @@ -199,16 +199,6 @@ pub fn init( AssistantSettings::register(cx); SlashCommandSettings::register(cx); - // TODO: remove this when 0.148.0 is released. - if AssistantSettings::get_global(cx).using_outdated_settings_version { - update_settings_file::(fs.clone(), cx, { - let fs = fs.clone(); - |content, cx| { - content.update_file(fs, cx); - } - }); - } - cx.spawn(|mut cx| { let client = client.clone(); async move {