Fix tab strikethrough logic (#20755)
Some checks are pending
CI / Check Postgres and Protobuf migrations, mergability (push) Waiting to run
CI / Check formatting and spelling (push) Waiting to run
CI / (macOS) Run Clippy and tests (push) Waiting to run
CI / (Linux) Run Clippy and tests (push) Waiting to run
CI / (Linux) Build Remote Server (push) Waiting to run
CI / (Windows) Run Clippy and tests (push) Waiting to run
CI / Create a macOS bundle (push) Blocked by required conditions
CI / Create a Linux bundle (push) Blocked by required conditions
CI / Create arm64 Linux bundle (push) Blocked by required conditions
Deploy Docs / Deploy Docs (push) Waiting to run
Docs / Check formatting (push) Waiting to run

This fix was in downstream commits before splitting out #20711, should
have tested locally before merging.

Release Notes:

- N/A
This commit is contained in:
Michael Sloan 2024-11-15 17:14:49 -07:00 committed by GitHub
parent 6e296eb4b6
commit f34877334e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -635,12 +635,13 @@ impl Item for Editor {
Some(util::truncate_and_trailoff(description, MAX_TAB_TITLE_LEN))
});
let is_deleted: bool = self
// Whether the file was saved in the past but is now deleted.
let was_deleted: bool = self
.buffer()
.read(cx)
.as_singleton()
.and_then(|buffer| buffer.read(cx).file())
.map_or(true, |file| file.is_deleted());
.map_or(false, |file| file.is_deleted() && file.is_created());
h_flex()
.gap_2()
@ -648,7 +649,7 @@ impl Item for Editor {
Label::new(self.title(cx).to_string())
.color(label_color)
.italic(params.preview)
.strikethrough(is_deleted),
.strikethrough(was_deleted),
)
.when_some(description, |this, description| {
this.child(