mirrors/zed
1
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2025-02-11 21:00:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Remove TODO in JsonLspAdapter (#15338)
Some checks are pending
CI / Check formatting and spelling (push) Waiting to run
Details
CI / (macOS) Run Clippy and tests (push) Waiting to run
Details
CI / (Linux) Run Clippy and tests (push) Waiting to run
Details
CI / (Windows) Run Clippy and tests (push) Waiting to run
Details
CI / Create a macOS bundle (push) Blocked by required conditions
Details
CI / Create a Linux bundle (push) Blocked by required conditions
Details
CI / Create arm64 Linux bundle (push) Blocked by required conditions
Details
Deploy Docs / Deploy Docs (push) Waiting to run
Details

Browse source 
As the post-install issue is fixed via #15331 , we can remove this
`TODO` now. I have tested on win11, it works fine.

Release Notes:

- N/A
This commit is contained in:
张小白 2024-07-28 01:05:48 +08:00 committed by GitHub
parent f1d777434b
commit f88278111e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/languages/src/json.rs
View file

@ -166,11 +166,9 @@ impl LspAdapter for JsonLspAdapter {
.await; .await;
if should_install_language_server { if should_install_language_server {
// TODO: the postinstall fails on Windows
self.node self.node
.npm_install_packages(&container_dir, &[(package_name, latest_version.as_str())]) .npm_install_packages(&container_dir, &[(package_name, latest_version.as_str())])
.await .await?;
.log_err();
} }
Ok(LanguageServerBinary { Ok(LanguageServerBinary {