Remove occasionally incorrect expectation (#10358)

This panic has occured a handful of times, I think it must be the case
that:

1. Item is dropped outside of an update loop
2. The next update is this one

In that case no flush effects will have called the release observers
yet, but we cannot upgrade the WeakModel because the ref count is 0



Release Notes:

- Fixed a (rare) panic while collaborating
This commit is contained in:
Conrad Irwin 2024-04-10 09:34:54 -06:00 committed by GitHub
parent 7abb63cfda
commit fc10201ce2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194

View file

@ -453,9 +453,7 @@ impl<T: Item> ItemHandle for View<T> {
}
workspace.update(&mut cx, |workspace, cx| {
let item = item.upgrade().expect(
"item to be alive, otherwise task would have been dropped",
);
let Some(item) = item.upgrade() else { return };
workspace.update_followers(
is_project_item,
proto::update_followers::Variant::UpdateView(