mirrors/zed
1
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2025-01-12 13:24:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Trigger scroll_to on code action list when moving selection (#3026)

Browse source 
Release Notes:
- Fixed the code action popup menu not scrolling as selection moves.
This commit is contained in:
Julia 2023-09-25 11:21:24 -04:00 committed by GitHub
commit ff5d0f2aeb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/editor/src/editor.rs
View file

@ -1131,12 +1131,14 @@ struct CodeActionsMenu {
impl CodeActionsMenu { impl CodeActionsMenu {
fn select_first(&mut self, cx: &mut ViewContext<Editor>) { fn select_first(&mut self, cx: &mut ViewContext<Editor>) {
self.selected_item = 0; self.selected_item = 0;
self.list.scroll_to(ScrollTarget::Show(self.selected_item));
cx.notify() cx.notify()
} }
fn select_prev(&mut self, cx: &mut ViewContext<Editor>) { fn select_prev(&mut self, cx: &mut ViewContext<Editor>) {
if self.selected_item > 0 { if self.selected_item > 0 {
self.selected_item -= 1; self.selected_item -= 1;
self.list.scroll_to(ScrollTarget::Show(self.selected_item));
cx.notify() cx.notify()
} }
} }
@ -1144,12 +1146,14 @@ impl CodeActionsMenu {
fn select_next(&mut self, cx: &mut ViewContext<Editor>) { fn select_next(&mut self, cx: &mut ViewContext<Editor>) {
if self.selected_item + 1 < self.actions.len() { if self.selected_item + 1 < self.actions.len() {
self.selected_item += 1; self.selected_item += 1;
self.list.scroll_to(ScrollTarget::Show(self.selected_item));
cx.notify() cx.notify()
} }
} }
fn select_last(&mut self, cx: &mut ViewContext<Editor>) { fn select_last(&mut self, cx: &mut ViewContext<Editor>) {
self.selected_item = self.actions.len() - 1; self.selected_item = self.actions.len() - 1;
self.list.scroll_to(ScrollTarget::Show(self.selected_item));
cx.notify() cx.notify()
} }