mirrors/zed
1
0
Fork 0
mirror of https://github.com/zed-industries/zed.git synced 2025-02-10 12:19:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Fix off-by-1 in Channel::messages_in_range

Browse source 
Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>
This commit is contained in:
Nathan Sobo 2021-08-24 17:17:55 -06:00
parent 3ad894b7e8
commit ff966c8d04
1 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
zed/src/channel.rs
View file

@ -243,7 +243,7 @@ impl Channel {
pub fn messages_in_range(&self, range: Range<usize>) -> impl Iterator<Item = &ChannelMessage> { pub fn messages_in_range(&self, range: Range<usize>) -> impl Iterator<Item = &ChannelMessage> {
let mut cursor = self.messages.cursor::<Count, ()>(); let mut cursor = self.messages.cursor::<Count, ()>();
cursor.seek(&Count(range.start), Bias::Left, &()); cursor.seek(&Count(range.start), Bias::Right, &());
cursor.take(range.len()) cursor.take(range.len())
} }
@ -459,6 +459,15 @@ mod tests {
new_count: 1, new_count: 1,
} }
); );
channel.read_with(&cx, |channel, _| {
assert_eq!(
channel
.messages_in_range(2..3)
.map(|message| &message.body)
.collect::<Vec<_>>(),
&["c"]
)
})
} }
struct FakeServer { struct FakeServer {