Max Brunsfeld
38d41acf9b
Fix rendering of shared screens in collab panel
2023-12-05 10:29:19 -08:00
Max Brunsfeld
5e79807f6f
Fix tree branch rendering in collab panel
2023-12-05 10:14:40 -08:00
Antonio Scandurra
09db455db2
Port semantic_index
to gpui2
...
Co-Authored-By: Julia Risley <julia@zed.dev>
2023-12-05 15:38:36 +01:00
Piotr Osiewicz
d433da1e70
Editor2 tests ( #3486 )
...
Release Notes:
- N/A
2023-12-05 14:52:20 +01:00
Max Brunsfeld
ae6ddceb67
Enable more collab UI features ( #3496 )
...
* Current Call section of the collab panel
* Improve the collab titlebar
* Add basic UI for following
Following only partially works, but the UI for following is now in
place.
2023-12-04 18:01:11 -08:00
Max Brunsfeld
eff3a72fb5
Start work on following in zed2
...
Co-authored-by: Nathan <nathan@zed.dev>
2023-12-04 17:51:53 -08:00
Conrad Irwin
9162f299a7
Fix project panel context menu
2023-12-05 00:41:00 +00:00
Max Brunsfeld
63667ecf6f
Start bringing back the current call section of the collab panel
...
Co-authored-by: Nathan <nathan@zed.dev>
2023-12-04 15:46:56 -08:00
Conrad Irwin
13bb16577c
action dispatch target ( #3494 )
...
- Ensure the candidate keybinding matches the correct context
- Fix context key matching
- I was soooo close
- Dispatch actions on focused node
[[PR Description]]
Release Notes:
- (Added|Fixed|Improved) ...
([#<public_issue_number_if_exists>](https://github.com/zed-industries/community/issues/ <public_issue_number_if_exists>)).
2023-12-04 23:43:26 +00:00
Conrad Irwin
c82fea375d
Dispatch actions on focused node
...
Allows us to implement context menu matching nicely
2023-12-04 22:58:04 +00:00
Marshall Bowers
c10d8a8110
Fix cursor styles not displaying properly ( #3493 )
...
This PR fixes an issue where an element with a cursor style set would
not update the cursor when hovering over it.
Previously the cursor style would only appear by interacting with the
element in some way, for instance, by clicking on the element or by
having a `.hover` with some other style being applied.
Release Notes:
- N/A
2023-12-04 16:40:53 -05:00
Conrad Irwin
79773178c8
I was soooo close
2023-12-04 21:37:47 +00:00
Conrad Irwin
2c2e5144c9
Fix context key matching
...
* You need to check all layers of the context stack
* When in command, the context should be based on where focus was (to
match `available_actions`.
2023-12-04 21:28:37 +00:00
Marshall Bowers
3627ff87f0
Ensure the candidate keybinding matches the correct context
2023-12-04 15:53:38 -05:00
Marshall Bowers
4cb4033a36
Merge branch 'main' into editor2_tests
2023-12-04 14:09:23 -05:00
Marshall Bowers
b212aab00d
Add support for copying diagnostic messages to the clipboard ( #3489 )
...
This PR adds support for copying diagnostics messages to the clipboard.
This was already working, but we were missing implementations
clipboard-related methods in the `TestPlatform` that were causing the
tests to fail when the copying functionality was added.
Release Notes:
- N/A
2023-12-04 14:08:05 -05:00
Nate Butler
50fe683305
Fix typos
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-12-04 11:28:22 -05:00
Piotr Osiewicz
b5924d6b11
Add simulate_window_resize.
...
Fixes up tests for movement in editor/scrolling.
Co-authored-by: Antonio <antonio@zed.dev>
2023-12-04 17:27:48 +01:00
Nate Butler
80ae640060
Add additional cursors to gpui2
...
Co-Authored-By: Marshall Bowers <1486634+maxdeviant@users.noreply.github.com>
2023-12-04 11:20:41 -05:00
Piotr Osiewicz
2108ddf621
Defer activating Subscriptions that are invoked as a part of an effect.
...
Fixes test test_edit_events.
Co-authored-by: Antonio <antonio@zed.dev>
2023-12-04 16:17:33 +01:00
Piotr Osiewicz
b9a917f42a
Fix up condition not checking the condition at the start.
...
Co-authored-by: Antonio <antonio@zed.dev>
2023-12-04 15:31:35 +01:00
Piotr Osiewicz
24b08921fe
Revert "fix display map tests"
...
This reverts commit 0f7fc8c1a0
.
2023-12-04 15:22:29 +01:00
Piotr Osiewicz
0f7fc8c1a0
fix display map tests
...
These tests failed due to an indefinite hang in buffer.condition in the following code:
\`\`\`rust
let buffer = cx
.add_model(|cx| Buffer::new(0, cx.model_id() as u64, text).with_language(language, cx));
buffer.condition(cx, |buf, _| !buf.is_parsing()).await;
`\`\`
In both gpui1 and gpui2 \`.with_language\` spawns a task that notifies the context once it's done. The \`condition\` waits for notifications to be raised. The gist of the problem was that in gpui2, the spawned task was scheduled straight away, so we never really saw the notification with \`condition\`, causing us to wait indefinitely. This is probably a difference in test between schedulers in gpui1 and gpui2, but I kind of sidestepped the issue by spawning a condition before firing off a parsing task with \`set_language\`.
2023-12-04 13:14:03 +01:00
Conrad Irwin
63b65b2b2e
Dismiss tooltips at capture
...
(Otherwise they stay open when you hover over the editor, which
stops mouse move events propagating)
2023-12-01 23:51:06 -07:00
Piotr Osiewicz
be509a5ce0
test_clipboard
2023-12-01 20:50:30 +01:00
Piotr Osiewicz
1c52b936bc
Uncomment flaky tests
2023-12-01 19:21:30 +01:00
Piotr Osiewicz
e0ccaa60ff
editor tests: Reintroduce block_on_ticks.
...
Co-authored-by: Antonio <antonio@zed.dev>
2023-12-01 17:24:47 +01:00
Piotr Osiewicz
a40a5fb212
Revert "editor tests: Reintroduce block_on_ticks."
...
This reverts commit aed11ee8cb
.
2023-12-01 17:24:20 +01:00
Piotr Osiewicz
aed11ee8cb
editor tests: Reintroduce block_on_ticks.
...
Co-authored-by: Antonio <antonio@zed.dev>
2023-12-01 17:22:12 +01:00
Julia
13f4cc563c
Merge branch 'main' into zed2-breadcrumbs
2023-12-01 11:02:34 -05:00
Antonio Scandurra
f0bc4a04bd
Uncomment git gutter painting
2023-12-01 13:45:14 +01:00
Antonio Scandurra
c9be637b6b
Re-introduce auto-height in editor2
( #3471 )
...
Release Notes:
- N/A
2023-12-01 12:02:45 +01:00
Conrad Irwin
0441b4805a
Show cursor position in status bar ( #3464 )
...
Passes the compiler so it must work!
(though it doesn't show up until we fix pane focus)
Release Notes:
- N/A
2023-11-30 16:40:42 -07:00
Max Brunsfeld
cb11c1282c
Re-introduce active path tracking in workspace
2023-11-30 14:58:14 -08:00
Max Brunsfeld
a003a91212
Restore auto-save on focus change, re-enable workspace tests
2023-11-30 14:45:27 -08:00
Conrad Irwin
75afb65b26
Show cursor position in status bar
2023-11-30 10:16:24 -07:00
Julia
428c517693
Merge branch 'main' into zed2-breadcrumbs
2023-11-30 11:38:29 -05:00
Antonio Scandurra
5243401afa
Pass a WindowContext
in request_measured_layout
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2023-11-30 17:12:40 +01:00
Antonio Scandurra
d9b8c07b1e
Lift Send and Sync restriction for measurements
2023-11-30 16:37:57 +01:00
Antonio Scandurra
fac029b808
Fix errors in theme2
2023-11-30 12:08:00 +01:00
Antonio Scandurra
624ea58f2e
Polish screen sharing
2023-11-30 11:22:01 +01:00
Antonio Scandurra
cc0bc444b1
Merge remote-tracking branch 'origin/main' into surfaces
...
# Conflicts:
# crates/ui2/src/components/avatar.rs
2023-11-30 10:48:20 +01:00
Conrad Irwin
02174084ca
Collab panel2: Now with scrolling and keyboard ( #3455 )
...
Also introducing: .track_scroll() for non-uniform lists.
Release Notes:
- N/A
2023-11-30 00:13:52 -07:00
Conrad Irwin
4fbbb28da2
Restore logical offset preservation behaviour
2023-11-29 23:51:31 -07:00
Conrad Irwin
54cfcef0aa
Keybaord shortcut context menu
2023-11-29 23:04:33 -07:00
Conrad Irwin
a37f86f294
Scroll the collab panel when keyboard focusing
2023-11-29 22:39:15 -07:00
Conrad Irwin
8638fc4149
Add a ScrollHandle to gpui2 for the collab panel
2023-11-29 22:20:06 -07:00
Max Brunsfeld
e49325080c
Implement activity indicator in zed2
2023-11-29 17:18:21 -08:00
Max Brunsfeld
c95a7c7387
Address some TODOs in editor2 crate ( #3445 )
...
* Fix crash when jumping to definition
* Enabling resolution of completions
* Make links in interactive text clickable
* Enable code paths that use `select_anchors`
2023-11-29 16:32:02 -08:00
Conrad Irwin
3bdd51cb2a
Availability indicators
2023-11-29 15:06:58 -07:00