Conrad Irwin
e91ecec8cd
fix modal exchange ( #3620 )
...
- Fix opening GoToLine from Command
- Extend test to cover go_to_line behavior too
Release Notes:
- N/A
2023-12-12 21:30:34 -07:00
Conrad Irwin
a2f0accb74
Fix opening GoToLine from Command
...
This was broken because of the async hop introduced by should_dismiss.
Change that API to instead be syncronous, and require that implementors
(of which there is only one) to call dismiss again if they want to.
2023-12-12 20:46:27 -07:00
Joseph T. Lyons
a63b4c598c
Use release channel display name for feedback
2023-12-12 17:29:37 -05:00
Joseph T. Lyons
c9aa4a0e00
Fix placeholder text
2023-12-12 16:56:43 -05:00
Joseph T. Lyons
906505f4dc
Fix rustfmt in feedback_modal.rs
2023-12-11 13:56:58 -05:00
Joseph T. Lyons
ff45b43857
Add code for submission and error states for feedback modal ( #3572 )
...
Release Notes:
- N/A
2023-12-10 20:49:14 -05:00
Conrad Irwin
4290c67b6a
Restore namespace parameter to actions!
...
This does not yet fix `derive(Action)`, but will conflict with a lot so
wanted to merge quickly.
2023-12-09 15:18:31 -07:00
Joseph T. Lyons
33c41fb5e1
Show negative numbers after limit is hit
2023-12-09 00:35:19 -05:00
Joseph T. Lyons
9abf5a1bf2
Add code for submission and error states
2023-12-08 19:16:03 -05:00
Joseph T. Lyons
cbbcc3502a
Fix bug where feedback dismissal prompt is shown twice
2023-12-08 17:21:14 -05:00
Joseph T. Lyons
13dad89a85
Move all dismissal logic into dismiss_event
2023-12-08 16:14:45 -05:00
Joseph T. Lyons
113c7287df
Allow modals to override their dismissal
...
Co-Authored-By: Mikayla Maki <mikayla.c.maki@gmail.com>
2023-12-08 15:29:44 -05:00
Joseph T. Lyons
be6c909587
Remove some unused imports
2023-12-08 13:13:40 -05:00
Joseph T. Lyons
63cc9e5068
Move character counter up above editor in feedback modal
2023-12-08 13:07:16 -05:00
Joseph T. Lyons
4596e7a68a
Use consistent text
2023-12-08 11:39:10 -05:00
Joseph T. Lyons
b66e1d2d58
Fix compiler error
2023-12-08 11:35:49 -05:00
Joseph T. Lyons
260a753005
Fix rustfmt
2023-12-08 11:33:18 -05:00
Joseph T. Lyons
1f51f74670
Add TODO
2023-12-07 22:24:32 -05:00
Joseph T. Lyons
8b9b19195d
Fix bug with how characters limits are being displayed
2023-12-07 13:19:03 -05:00
Joseph T. Lyons
0ee4ad6ba0
Skip using map
2023-12-07 13:00:49 -05:00
Joseph T. Lyons
794b795800
Add TODO
2023-12-07 12:04:04 -05:00
Nate Butler
5e5eb25aab
WIP
...
[no-ci]
2023-12-07 10:50:07 -05:00
Nate Butler
f798b193d0
WIP
2023-12-07 01:46:28 -05:00
Nate Butler
7a1eb54106
checkpoint
2023-12-07 00:33:24 -05:00
Joseph T. Lyons
79e0d8ce3b
WIP
2023-12-06 23:15:04 -05:00
Joseph T. Lyons
256f0308ae
Renove unused code
2023-12-06 21:32:33 -05:00
Joseph T. Lyons
d62b151bc0
Improve character limit bounds indicator
2023-12-06 21:23:51 -05:00
Joseph T. Lyons
668f5accab
Highlight whole modal as needing UI tweaks
2023-12-06 19:35:41 -05:00
Joseph T. Lyons
57a9f024e7
Remove email address from local database if user removes it
2023-12-06 19:26:25 -05:00
Joseph T. Lyons
bbe9986f38
Start work to add a confirmation when exiting feedback containing text
2023-12-06 19:13:38 -05:00
Joseph T. Lyons
1abc9800af
Switch to if let statement
2023-12-06 19:11:24 -05:00
Joseph T. Lyons
034c11cc96
Hook up community repo button
2023-12-06 19:11:03 -05:00
Joseph T. Lyons
0885fa67fc
Hook up submit
2023-12-06 19:10:45 -05:00
Joseph T. Lyons
110612bf26
Reduce amount of state being stored
2023-12-06 18:36:17 -05:00
Joseph T. Lyons
46c998ca8d
WIP
2023-12-06 17:27:10 -05:00
Joseph T. Lyons
f4c7b13397
temp
2023-12-06 16:15:44 -05:00
Joseph T. Lyons
02a6a2e1a3
Revert "Delete feedback_modal.rs"
...
This reverts commit eff925cb6a
.
2023-12-06 14:13:56 -05:00
Joseph T. Lyons
4863c9ac25
WIP
2023-12-06 14:13:44 -05:00
Joseph T. Lyons
eff925cb6a
Delete feedback_modal.rs
2023-12-06 13:26:20 -05:00
Joseph T. Lyons
a27db35ff7
temp
2023-12-05 16:37:43 -05:00
Joseph T. Lyons
fdc2d7ce42
Remove unused code
2023-12-05 15:53:52 -05:00
Joseph T. Lyons
dec4cfa0b4
Implement feedback action
...
OpenZedCommunityRepo
2023-12-05 15:52:02 -05:00
Joseph T. Lyons
78e1c0f9c3
Implement feedback actions
...
CopySystemSpecsIntoClipboard
RequestFeature
FileBugReport
2023-12-05 15:48:41 -05:00
Joseph T. Lyons
a80b145d0d
temp
2023-12-05 13:04:53 -05:00
Joseph T. Lyons
a75f1a4a95
Close feedback modal when clicking cancel
2023-11-30 22:07:10 -05:00
Nate Butler
e228422f14
Update feedback modal UI
...
Co-Authored-By: Joseph T. Lyons <19867440+JosephTLyons@users.noreply.github.com>
2023-11-30 16:42:58 -05:00
Nate Butler
8b7be8f614
Get feedback2
compiling
...
Co-Authored-By: Joseph T. Lyons <19867440+JosephTLyons@users.noreply.github.com>
Co-Authored-By: Conrad Irwin <conrad.irwin@gmail.com>
2023-11-30 16:07:54 -05:00
Nate Butler
f987a640fd
init feedback2
...
Co-Authored-By: Joseph T. Lyons <19867440+JosephTLyons@users.noreply.github.com>
Co-Authored-By: Conrad Irwin <conrad.irwin@gmail.com>
2023-11-30 15:23:42 -05:00