Mikayla
ed263a7b5c
Resolve more todos
2024-01-09 15:08:05 -08:00
Mikayla
80790d921d
Fix / remove small todos
2024-01-09 14:16:46 -08:00
Marshall Bowers
684bd530f0
ui: Fix doc tests ( #3989 )
...
There were a ton of doc tests that weren't compiling in the `ui` crate,
so this PR fixes them.
Release Notes:
- N/A
2024-01-09 16:56:28 -05:00
Max Brunsfeld
68d0b468f3
Remove unnecessary mutexes from livekit client types ( #3984 )
...
We had introduced these mutexes at a time when `gpui2` required app
entities to be `Sync`, but they are no longer needed. Removing them now
because we're trying to find out why we're sometimes getting crashes and
deadlocks in livekit, and we didn't before.
2024-01-09 13:40:27 -08:00
Conrad Irwin
0daa2bf7f4
Fix panic in set_scroll_anchor_remote ( #3987 )
...
If the remote sends us an invalid scroll position, we should not panic.
Release Notes:
- Fix a panic receiving scroll positions out of order
2024-01-09 14:39:06 -07:00
Kirill Bulatov
18e537abdf
Do not dismiss buffer search when any modal is present ( #3988 )
...
Release Notes:
- Fixed buffer search being dismissed not after the modals are
2024-01-09 23:36:32 +02:00
Kirill Bulatov
8b71b1d07b
Do not dismiss buffer search when any modal is present
...
Co-authored-by: Piotr Osiewicz <piotr@zed.dev>
2024-01-09 23:29:05 +02:00
Marshall Bowers
a579ef17d7
Rename Shape
to AvatarShape
( #3986 )
...
This PR renames the `Shape` enum to `AvatarShape`, since it seems pretty
specific to `Avatar`s.
Release Notes:
- N/A
2024-01-09 16:21:27 -05:00
Conrad Irwin
a46947d5d7
Fix panic in set_scroll_anchor_remote
2024-01-09 14:19:48 -07:00
Max Brunsfeld
e3c603f41b
Make RemoteTrackPublication a tuple struct again
2024-01-09 12:54:51 -08:00
Max Brunsfeld
356f9fc3b6
Store a raw Room pointer on RoomDelegate
2024-01-09 12:50:00 -08:00
Marshall Bowers
7ed3f5f392
Clean up references in doc comments in ui
and theme
crates ( #3985 )
...
This PR cleans up a number of references in doc comments in the `ui` and
`theme` crates so that `rustdoc` will link and display them correctly.
Release Notes:
- N/A
2024-01-09 15:22:36 -05:00
Mikayla
145f3f55e9
Remove unused API
2024-01-09 12:20:17 -08:00
Mikayla Maki
447bfca942
Add a test to catch keybinding bounds issue ( #3966 )
...
Add a test to catch regressions to
https://github.com/zed-industries/zed/pull/3964
Thanks for the idea @ConradIrwin
TODO:
- [ ] Fix immediate stack overflow in test
Release Notes:
- N/A
2024-01-09 12:03:48 -08:00
Max Brunsfeld
128a8ff0b9
Remove unnecessary mutexes from livekit client types
...
Co-authored-by: Conrad <conrad@zed.dev>
2024-01-09 12:02:29 -08:00
Nate Butler
510234ca71
Add some Theme and UI docs ( #3979 )
...
Documents a number of items in the `theme` and `ui` crates.
Release Notes:
- N/A
2024-01-09 15:00:21 -05:00
Mikayla
1728c4eacc
Fixed test
2024-01-09 11:52:03 -08:00
Julia
5b1894a9b1
Take into account multiple scroll deltas within a single frame ( #3982 )
...
Release Notes:
- Fixed an issue where all but the last scroll event would be dropped if
there were multiple within a single frame.
2024-01-09 14:51:26 -05:00
Nate Butler
51988f63d5
Document more enums
2024-01-09 14:50:04 -05:00
Marshall Bowers
74dadd68d2
Clean up references in doc comments ( #3983 )
...
This PR cleans up a number of references in doc comments so that
`rustdoc` will link and display them correctly.
Release Notes:
- N/A
2024-01-09 14:48:48 -05:00
Julia
463270ed36
Take into account multiple scroll deltas within a single frame
...
Co-Authored-By: Antonio Scandurra <antonio@zed.dev>
2024-01-09 14:32:43 -05:00
Nate Butler
c19551d974
Document free functions
2024-01-09 14:21:29 -05:00
Nate Butler
cb24062e79
Restore removed ColorScaleStep ALL that was breaking the build
2024-01-09 14:16:50 -05:00
Nate Butler
e020d7ca11
Document ui crate traits
2024-01-09 14:15:25 -05:00
Nathan Sobo
00c3afd330
Add documentation to GPUI ( #3980 )
...
🍐 d with @conrad @mikayla-maki on covering some of the surface area.
Release Notes:
- N/A
2024-01-09 12:10:53 -07:00
Nathan Sobo
42cbd103fb
Even more docs
...
Co-authored-by: Conrad <conrad@zed.dev>
2024-01-09 12:02:12 -07:00
Nate Butler
46065c2621
Fix unclosed delimiter
2024-01-09 13:52:11 -05:00
Nate Butler
7dbe0519ec
Add label docs
2024-01-09 13:49:27 -05:00
Nate Butler
324fd24709
Initial button documentation
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
2024-01-09 13:39:15 -05:00
Nathan Sobo
458c672a72
Add more API docs
...
Co-Authored-By: Conrad <conrad@zed.dev>
2024-01-09 11:16:56 -07:00
Nate Butler
5359762051
Document components/avatar
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
2024-01-09 13:04:55 -05:00
Nathan Sobo
59f41acb82
Add a bunch of docs
...
Co-Authored-By: Conrad <conrad@zed.dev>
Co-Authored-By: Mikayla <mikayla@zed.dev>
2024-01-09 11:02:57 -07:00
Nate Butler
9747c10ce8
Document UI modules
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
2024-01-09 12:57:12 -05:00
Nate Butler
bcbfa7d036
Start documenting Theme crate
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
2024-01-09 12:49:56 -05:00
Piotr Osiewicz
ab6cd1d93a
chore: cfg(test) a test in rpc. ( #3978 )
...
The test in particular should be included in our release binary at
present. :/
Release Notes:
- N/A
2024-01-09 18:00:54 +01:00
Conrad Irwin
b801e0a46e
Fix merge conflict
2024-01-09 09:44:22 -07:00
Conrad Irwin
bebb528656
Merge branch 'main' into migrations-on-server-start
2024-01-09 09:43:14 -07:00
Marshall Bowers
824d06e2b2
Remove Default
impl for StatusColors
( #3977 )
...
This PR removes the `Default` impl for `StatusColors`.
Since we need default light and dark variants for `StatusColors`, we
can't use a single `Default` impl.
Release Notes:
- N/A
2024-01-09 11:31:19 -05:00
Piotr Osiewicz
d374953180
search: Remove newlines from query used for tab_content. ( #3976 )
...
Fixes https://github.com/zed-industries/community/issues/2388
Release Notes:
- Fixed tab content of project search overflowing the tab for queries
with newlines.
2024-01-09 17:16:25 +01:00
Marshall Bowers
f0ef63bfa0
gpui: Add SharedUrl
type ( #3975 )
...
This PR adds a `SharedUrl` type to GPUI.
It's just like a `SharedString`, but for denoting that the contained
value is a URL.
Mainlined from @nathansobo's GPUI blog post:
https://github.com/zed-industries/zed/pull/3968/files#diff-7ee75937e2daf7dd53f71b17698d8bd6d46993d06928d411781b9bd739b5f231R9-R12
Release Notes:
- N/A
2024-01-09 10:55:49 -05:00
Marshall Bowers
fa53353c57
Rename IconElement
to just Icon
( #3974 )
...
This PR renames the `IconElement` component to just `Icon`.
This better matches the rest of our components, as `IconElement` was the
only one using this naming convention.
The `Icon` enum has been renamed to `IconName` to free up the name.
I was trying to come up with a way that would allow rendering an
`Icon::Zed` directly (and thus make the `IconElement` a hidden part of
the API), but I couldn't come up with a way to do this cleanly.
Release Notes:
- N/A
2024-01-09 10:11:20 -05:00
Piotr Osiewicz
29ed067b26
Add a missing default value to docs ( #3973 )
...
Release Notes:
- N/A
2024-01-09 12:20:52 +01:00
Kirill Bulatov
a0f9393c1f
Remove some todo!'s from the code ( #3972 )
...
Release Notes:
- N/A
2024-01-09 11:45:09 +02:00
Kirill Bulatov
625c9d8980
Remove some todo!'s
2024-01-09 11:36:36 +02:00
Kirill Bulatov
aa1d2d2f24
Remove dbg! usage from tests
2024-01-09 10:08:27 +02:00
Conrad Irwin
0f7b47af39
Run migations on development server start
2024-01-08 22:45:15 -07:00
Conrad Irwin
82f7dd9bbb
Prototype cursor sharing (the inefficient way)
...
I think this will be a key user experience driver, but we do need to
find a way to enable it without widening our vector clocks.
2024-01-08 22:32:30 -07:00
Conrad Irwin
8669b08161
Failing test for unmuting microphone
2024-01-08 22:30:03 -07:00
Conrad Irwin
844d161c40
Allow adding write access to guests
2024-01-08 22:02:56 -07:00
Marshall Bowers
4afa5fb23e
Add stories for collab notifications ( #3967 )
...
This PR adds some basic stories for collab notifications to make them
easier to work on:
<img width="1076" alt="Screenshot 2024-01-08 at 9 43 39 PM"
src="https://github.com/zed-industries/zed/assets/1486634/4a0adcfa-1134-49c2-b589-74ac1d52af4c ">
I factored out a `CollabNotification` component that defines the general
structure for one of these notifications, and this is the component that
we use in the stories, with representative values passed to it to
simulate the different instances of the notification.
We can't use the actual notification components in the stories due to
their data dependencies.
Release Notes:
- N/A
2024-01-08 21:54:59 -05:00