Fernando Tagawa
d7c45ccf2f
x11: Fix preedit for CJK and partially fix unresponsive keyboard with xim ( #17373 )
...
Closes #15833
Related to [#12495
comment](https://github.com/zed-industries/zed/pull/12495#issuecomment-2328356125 )
Destroying and recreating the Input context was the only way to reset
the IME but it's making the keyboard unresponsive sometimes due to a XIM
error.
The keyboard will still be unresponsive if you close your IME while
using zed, but I don't know how to fix this.
* Fixed preedit drawing for CJK
* Fixed unresponsive keyboard by properly implementing reset_ic in
`xim-rs`
Release Notes:
- N/A
2024-09-16 18:46:03 -06:00
Max Brunsfeld
243629cce8
Fix keystroke observer leak in vim crate ( #17913 )
...
Release Notes:
- Fixed a performance problem that happened when using vim mode after
opening and closing many editors
Co-authored-by: Antonio <antonio@zed.dev>
Co-authored-by: Nathan <nathan@zed.dev>
2024-09-16 15:50:12 -07:00
Thorsten Ball
f986513d0d
gpui: Remove debug print statement ( #17878 )
...
Release Notes:
- N/A
2024-09-16 15:00:20 +02:00
Zhang
00c0a7254a
gpui: Allow TextInput example to lose and gain focus ( #17823 )
...
Improved the input.rs example file in gpui crate.
The new code
* allow this text field to lose and gain input focus.
* change TextInput's height from full to fix.
Release Notes:
- N/A
2024-09-14 15:49:53 -04:00
Junkui Zhang
461812d7b6
windows: Use the existing open_target function for platform::open_with_system ( #17705 )
...
Release Notes:
- N/A
2024-09-12 16:15:20 -04:00
Jason Lee
ee96d69e37
gpui: Fix CJK line wrap for GPUI text render ( #17737 )
...
Release Notes:
- N/A
This changes is going to let GPUI render correct text wrapping for CJK
characters. We was done this in PR #11296 for Editor, but this is also
need support for other text renders.
| Before | After |
| --- | --- |
| <img width="488" alt="SCR-20240912-jtvo"
src="https://github.com/user-attachments/assets/d061669c-62ab-4a7e-a724-2df84815d1ed ">
| <img width="438" alt="image"
src="https://github.com/user-attachments/assets/ec27fd80-69db-48b6-8ade-694cd65d1843 ">
|
2024-09-12 15:55:03 -04:00
Conrad Irwin
4d26f83d23
Revert "settings: Remove auxiliary Content types where possible ( #16744 )" ( #17768 )
...
This breaks setting `{"scrollbar": {"show":"never"}}`
Release Notes:
- N/A
2024-09-12 14:46:08 -04:00
Piotr Osiewicz
ccf6f27b8f
settings: Remove auxiliary Content types where possible ( #16744 )
...
Release Notes:
- N/A
2024-09-10 22:59:10 -04:00
Conrad Irwin
36eb1c15ea
use ssh lsp store ( #17655 )
...
Release Notes:
- ssh remoting: Added support for booting langauge servers (in limited
circumstances)
---------
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-09-10 15:51:01 -04:00
KorigamiK
ae3880e71a
Add ability to open files with system default application ( #17231 )
2024-09-10 14:36:36 -04:00
ZZzzaaKK
f71cb14d7a
Add ',' to word chars for line wrapping ( #17590 )
...
CI / Check formatting and spelling (push) Waiting to run
CI / (macOS) Run Clippy and tests (push) Waiting to run
CI / (Linux) Run Clippy and tests (push) Waiting to run
CI / (Windows) Run Clippy and tests (push) Waiting to run
CI / Create a macOS bundle (push) Blocked by required conditions
CI / Create a Linux bundle (push) Blocked by required conditions
CI / Create arm64 Linux bundle (push) Blocked by required conditions
Deploy Docs / Deploy Docs (push) Waiting to run
Docs / Check formatting (push) Waiting to run
Closes #16407
Adds ',' to the is_word_char() matches for line wrapping, so that commas
aren't wrapped to the start of a new line.
Release Notes:
- N/A
2024-09-09 14:52:43 -07:00
Sergio Nonide
c1193875e8
Fix blurry cursor on Wayland at a scale other than 100% ( #17496 )
...
Closes #13258
Release Notes:
- Fixed blurry mouse cursor on wayland when the screen scale is other
than 100%
Before:
After:
2024-09-09 14:44:02 -07:00
Fernando Tagawa
59be07ad90
x11: Implement Drag and Drop ( #17491 )
...
Closes #16225
Release Notes:
- x11: Implemented Drag and Drop.
2024-09-09 14:27:45 -07:00
Jason Lee
47aec5e64d
Improve popup menu to leave some margin with window edges ( #17159 )
...
CI / Check formatting and spelling (push) Waiting to run
CI / (macOS) Run Clippy and tests (push) Waiting to run
CI / (Linux) Run Clippy and tests (push) Waiting to run
CI / (Windows) Run Clippy and tests (push) Waiting to run
CI / Create a macOS bundle (push) Blocked by required conditions
CI / Create a Linux bundle (push) Blocked by required conditions
CI / Create arm64 Linux bundle (push) Blocked by required conditions
Deploy Docs / Deploy Docs (push) Waiting to run
Docs / Check formatting (push) Waiting to run
Release Notes:
- Improved popup menu to leave some margin with window edges.
## Updates in GPUI
- gpui: Add `snap_to_window_with_margin` method to `anchored` to support
leave margin to window edges.
## Before
<img width="609" alt="before-snap-to-window 2024-08-30 222506"
src="https://github.com/user-attachments/assets/62bb6791-7c89-4558-9484-5c7b31f5e91e ">
## After
<img width="698" alt="snap-to-window1 2024-08-30 222506"
src="https://github.com/user-attachments/assets/51634e79-2a95-42fe-8362-a3c7003648eb ">
<img width="622" alt="snap-to-window 2024-08-30 222506"
src="https://github.com/user-attachments/assets/43a865d6-d238-4fdc-ae9d-8160b9ba7953 ">
2024-09-07 03:05:57 +02:00
apricotbucket28
f91bf7fca5
blade: Update to e142a3a to fix crash ( #17510 )
...
Closes https://github.com/zed-industries/zed/issues/17005
Like https://github.com/zed-industries/zed/pull/17319 , but based on
https://github.com/kvark/blade/pull/144 .
This should be cherry-picked into preview if possible 🙂
Release Notes:
- Linux: Fixed crash when closing windows on Wayland.
2024-09-06 15:54:40 -04:00
Thorsten Ball
938c90fd3b
Revert FPS counter ( #17485 )
...
**UPDATE**: Response so far seems to be that this fixes the performance
issues on Intel MacBooks. So we're going to go ahead and merge it.
This reverts the FPS counter added in 11753914d#16422 ) because in this
issue someone bisected recent performance regressions down to this
commit:
- https://github.com/zed-industries/zed/issues/16729
Another issue that's possibly related:
-
https://github.com/zed-industries/zed/issues/17305#issuecomment-2332316242
We're reverting this in a PR to create a bundle that people can try out.
Assets:
- Universal Binary:
https://github.com/zed-industries/zed/actions/runs/10735702994/artifacts/1900460781
- x86/Intel:
https://github.com/zed-industries/zed/actions/runs/10735702994/artifacts/1900461236
- Apple Silicon:
https://github.com/zed-industries/zed/actions/runs/10735702994/artifacts/1900460978
Release Notes:
- Removed the recently-added FPS counter since the changes it made to
the Metal renderer on macOS could lead to performance regressions on
Intel MacBooks.
Co-authored-by: Bennet <bennet@zed.dev>
2024-09-06 15:35:00 +02:00
Piotr Osiewicz
e6c1c51b37
chore: Fix several style lints ( #17488 )
...
CI / Check formatting and spelling (push) Waiting to run
CI / (macOS) Run Clippy and tests (push) Waiting to run
CI / (Linux) Run Clippy and tests (push) Waiting to run
CI / (Windows) Run Clippy and tests (push) Waiting to run
CI / Create a macOS bundle (push) Blocked by required conditions
CI / Create a Linux bundle (push) Blocked by required conditions
CI / Create arm64 Linux bundle (push) Blocked by required conditions
Deploy Docs / Deploy Docs (push) Waiting to run
Docs / Check formatting (push) Waiting to run
It's not comprehensive enough to start linting on `style` group, but
hey, it's a start.
Release Notes:
- N/A
2024-09-06 11:58:39 +02:00
Fernando Tagawa
30f70ff110
wayland: Fix regression in dead keys caused by #12495 ( #17465 )
...
Related to
https://github.com/zed-industries/zed/pull/12495#issuecomment-2332414008
Release Notes:
- N/A
2024-09-05 18:13:00 -07:00
秦宇航
94b6d06a72
gpui: Add example for uniform_list ( #17421 )
...
CI / Check formatting and spelling (push) Waiting to run
CI / (macOS) Run Clippy and tests (push) Waiting to run
CI / (Linux) Run Clippy and tests (push) Waiting to run
CI / (Windows) Run Clippy and tests (push) Waiting to run
CI / Create a macOS bundle (push) Blocked by required conditions
CI / Create a Linux bundle (push) Blocked by required conditions
CI / Create arm64 Linux bundle (push) Blocked by required conditions
Deploy Docs / Deploy Docs (push) Waiting to run
Docs / Check formatting (push) Waiting to run
GPUI: Add example for `uniform_list`
- Added example for `uniform_list`
- Run `cargo run --example uniform_list` to fire up the example
-
https://github.com/user-attachments/assets/bb554fbc-c097-4ce5-8077-782dc4c5c398
Release Notes:
- N/A
https://github.com/user-attachments/assets/bb554fbc-c097-4ce5-8077-782dc4c5c398
---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
2024-09-05 14:24:10 -04:00
Marshall Bowers
3d99b5eb0f
gpui: Clean up common module ( #17427 )
...
This PR cleans up the `common` module for GPUI elements.
Release Notes:
- N/A
2024-09-05 12:39:30 -04:00
Jason Lee
a092ff0c4f
gpui: Add opacity to support transparency of the entire element ( #17132 )
...
Release Notes:
- N/A
---
Add this for let GPUI element to support fade in-out animation.
## Platform test
- [x] macOS
- [x] blade `cargo run -p gpui --example opacity --features macos-blade`
## Usage
```rs
div()
.opacity(0.5)
.bg(gpui::black())
.text_color(gpui::black())
.child("Hello world")
```
This will apply the `opacity` it self and all children to use `opacity`
value to render colors.
## Example
```
cargo run -p gpui --example opacity
cargo run -p gpui --example opacity --features macos-blade
```
<img width="612" alt="image"
src="https://github.com/user-attachments/assets/f1da87ed-31f5-4b55-a023-39e8ee1ba349 ">
2024-09-04 12:53:45 +02:00
Marshall Bowers
3d83903caa
gpui: Update "Getting Started" to include macOS setup ( #17316 )
...
This PR updates the GPUI docs to mention how to install XCode for Metal
support.
Supersedes https://github.com/zed-industries/zed/pull/16820 .
Release Notes:
- N/A
2024-09-03 13:26:11 -04:00
Marshall Bowers
12341e518e
gpui: Add svg example ( #17315 )
...
This PR adds an example for working with SVGs.
Release Notes:
- N/A
2024-09-03 13:15:37 -04:00
Marshall Bowers
89632ff5c2
gpui: Fix typo in DefaultThemeAppearance doc comment ( #17157 )
...
Release Notes:
- N/A
2024-08-30 09:48:13 -04:00
Jason Lee
0835d456dc
gpui: Fix text ellipsis appearing even the flex element has space ( #17149 )
...
Release Notes:
- N/A
There was a calculation bug before. When we added `text_ellipsis` to the
flex element, it would always show ellipsis no matter how long it was.
Actually we can't use `flex` and `text_ellipsis` at same time, the CSS
also not support this. But this bug will let user confuse.
### Before
<img width="731" alt="image"
src="https://github.com/user-attachments/assets/b7d60017-6785-45f5-8b40-dd5efa154a1e ">
### After
<img width="521" alt="image"
src="https://github.com/user-attachments/assets/a3117793-284e-48d4-8c15-059fe61abe60 ">
2024-08-30 09:01:46 -04:00
Nate Butler
01f8d27f22
Add a simple set of default colors to gpui ( #17110 )
...
This PR adds an initial set of default colors to `gpui`.
These will power default-styled gpui components (things like checkboxes,
buttons, inputs, etc.), storybook, and give a very simple,
appearance-aware set of colors out of the box for folks to build with.
These colors will evolve and be updated in the near future, they are
literally pulled from Finder for now :)
The API might not be perfect, I focused on getting something in quickly
that we can iterate on!
### Usage
```rs
use gpui::{colors, DefaultColor}
fn auto(cx: &WindowContext) -> {
// Init the full set of DefaultColors
let colors = colors(cx.appearance());
// Use a color
// It will automatically give you the correct color for the system's
// current appearance.
let background = DefaultColor::Background.hsla(&colors)
}
fn manual() -> {
// Init the full sets of DefaultColors
let light_colors = DefaultColors::light();
let dark_colors = DefaultColors::dark();
// Use a color
// Maybe for some fancy inverted element
let background = DefaultColor::Background.hsla(&light_colors)
let inverted_background = DefaultColor::Background.hsla(&dark_colors)
let inverted_text = DefaultColor::Text.hsla(&dark_colors)
}
```
Note: We need `cx` for the auto way as we need to get the system
appearance from the App/Window/ViewContext via `cx.appearance()`.
### Example
You can run `script/storybook default_colors` to open the Default Colors
story:
| Light | Dark |
|-------|------|
| 
| 
|
Release Notes:
- N/A
2024-08-29 16:50:03 -04:00
张小白
64fa7a5234
Set *_font_fallbacks default to None ( #16941 )
...
CI / Check formatting and spelling (push) Waiting to run
CI / (macOS) Run Clippy and tests (push) Waiting to run
CI / (Linux) Run Clippy and tests (push) Waiting to run
CI / (Windows) Run Clippy and tests (push) Waiting to run
CI / Create a macOS bundle (push) Blocked by required conditions
CI / Create a Linux bundle (push) Blocked by required conditions
CI / Create arm64 Linux bundle (push) Blocked by required conditions
Deploy Docs / Deploy Docs (push) Waiting to run
Docs / Check formatting (push) Waiting to run
In the current `default.json`, `*_font_fallbacks=[]`, which results in
the `fallbacks` value in the `Font` struct always being `Some(...)`.
This PR introduces the following improvements:
1. Changed `*_font_fallbacks = []` to `*_font_fallbacks = null` in
`default.json`.
2. Enhanced the macOS and Windows implementations.
Release Notes:
- N/A
2024-08-28 22:30:46 -07:00
renovate[bot]
5d5ae1ec6f
Update Rust crate bindgen to 0.70.0 ( #17024 )
...
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [bindgen](https://rust-lang.github.io/rust-bindgen/ )
([source](https://togithub.com/rust-lang/rust-bindgen )) |
build-dependencies | minor | `0.65.1` -> `0.70.0` |
---
### Release Notes
<details>
<summary>rust-lang/rust-bindgen (bindgen)</summary>
###
[`v0.70.1`](https://togithub.com/rust-lang/rust-bindgen/blob/HEAD/CHANGELOG.md#0701-2024-08-20 )
[Compare
Source](https://togithub.com/rust-lang/rust-bindgen/compare/v0.70.0...v0.70.1 )
#### Added
#### Changed
#### Removed
#### Fixed
- Fix regression where the `const` layout tests were triggering the
`unnecessary_operation` and `identity_op` clippy warnings.
#### Security
###
[`v0.70.0`](https://togithub.com/rust-lang/rust-bindgen/blob/HEAD/CHANGELOG.md#0700-2024-08-16 )
[Compare
Source](https://togithub.com/rust-lang/rust-bindgen/compare/v0.69.4...v0.70.0 )
#### Added
- Add target mappings for riscv64imac and riscv32imafc.
- Add a complex macro fallback API
([#​2779](https://togithub.com/rust-lang/rust-bindgen/issues/2779 )).
- Add option to use DST structs for flexible arrays (--flexarray-dst,
[#​2772](https://togithub.com/rust-lang/rust-bindgen/issues/2772 )).
- Add option to dynamically load variables
([#​2812](https://togithub.com/rust-lang/rust-bindgen/issues/2812 )).
- Add option in CLI to use rustified non-exhaustive enums
(--rustified-non-exhaustive-enum,
[#​2847](https://togithub.com/rust-lang/rust-bindgen/issues/2847 )).
#### Changed
- Remove which and lazy-static dependencies
([#​2809](https://togithub.com/rust-lang/rust-bindgen/issues/2809 ),
[#​2817](https://togithub.com/rust-lang/rust-bindgen/issues/2817 )).
- Generate compile-time layout tests
([#​2787](https://togithub.com/rust-lang/rust-bindgen/issues/2787 )).
- Print `bindgen-cli` errors to stderr instead of stdout
([#​2840](https://togithub.com/rust-lang/rust-bindgen/issues/2840 ))
#### Removed
#### Fixed
- Fix `--formatter=prettyplease` not working in `bindgen-cli` by adding
`prettyplease` feature and
enabling it by default for `bindgen-cli`
([#​2789](https://togithub.com/rust-lang/rust-bindgen/issues/2789 ))
.
- Fix `--allowlist-item` so anonymous enums are no longer ignored
([#​2827](https://togithub.com/rust-lang/rust-bindgen/issues/2827 )).
- Use clang_getFileLocation instead of clang_getSpellingLocation to fix
clang-trunk
([#​2824](https://togithub.com/rust-lang/rust-bindgen/issues/2824 )).
- Fix generated constants: `f64::INFINITY`, `f64::NEG_ INFINITY`,
`f64::NAN`
([#​2854](https://togithub.com/rust-lang/rust-bindgen/issues/2854 )).
#### Security
- Update `tempfile` and `rustix` due to
[GHSA-c827-hfw6-qwvm](https://togithub.com/advisories/GHSA-c827-hfw6-qwvm ).
###
[`v0.69.4`](https://togithub.com/rust-lang/rust-bindgen/blob/HEAD/CHANGELOG.md#0694-2024-02-04 )
[Compare
Source](https://togithub.com/rust-lang/rust-bindgen/compare/v0.69.3...v0.69.4 )
#### Added
#### Changed
- Allow older itertools.
([#​2745](https://togithub.com/rust-lang/rust-bindgen/issues/2745 ))
#### Removed
#### Fixed
#### Security
###
[`v0.69.3`](https://togithub.com/rust-lang/rust-bindgen/blob/HEAD/CHANGELOG.md#0693-2024-02-04 )
[Compare
Source](https://togithub.com/rust-lang/rust-bindgen/compare/v0.69.2...v0.69.3 )
#### Added
- Added blocklist_var
([#​2731](https://togithub.com/rust-lang/rust-bindgen/issues/2731 ))
- Stabilized thiscall_abi
([#​2661](https://togithub.com/rust-lang/rust-bindgen/issues/2661 ))
#### Changed
- Use CR consistently on windows
([#​2698](https://togithub.com/rust-lang/rust-bindgen/issues/2698 ))
- Replaced peeking_take_while by itertools
([#​2724](https://togithub.com/rust-lang/rust-bindgen/issues/2724 ))
#### Removed
#### Fixed
- Try to avoid repr(packed) for explicitly aligned types when not needed
([#​2734](https://togithub.com/rust-lang/rust-bindgen/issues/2734 ))
- Improved destructor handling on Windows
([#​2663](https://togithub.com/rust-lang/rust-bindgen/issues/2663 ))
- Support Float16
([#​2667](https://togithub.com/rust-lang/rust-bindgen/issues/2667 ))
- Fix alignment contribution from bitfields
([#​2680](https://togithub.com/rust-lang/rust-bindgen/issues/2680 ))
- Fixed msrv build.
#### Security
- Updated shlex dependency (RUSTSEC-2024-0006)
###
[`v0.69.2`](https://togithub.com/rust-lang/rust-bindgen/blob/HEAD/CHANGELOG.md#0692-2024-01-13 )
[Compare
Source](https://togithub.com/rust-lang/rust-bindgen/compare/v0.69.1...v0.69.2 )
#### Added
#### Changed
#### Removed
#### Fixed
- Fixed generation of extern "C" blocks with llvm 18+. See
[#​2689](https://togithub.com/rust-lang/rust-bindgen/issues/2689 ).
#### Security
###
[`v0.69.1`](https://togithub.com/rust-lang/rust-bindgen/blob/HEAD/CHANGELOG.md#0691-2023-11-02 )
[Compare
Source](https://togithub.com/rust-lang/rust-bindgen/compare/v0.69.0...v0.69.1 )
#### Fixed
- Allow to run `bindgen -v` without an input header argument.
###
[`v0.69.0`](https://togithub.com/rust-lang/rust-bindgen/blob/HEAD/CHANGELOG.md#0690-2023-11-01 )
[Compare
Source](https://togithub.com/rust-lang/rust-bindgen/compare/v0.68.1...v0.69.0 )
#### Added
- Added the `ParseCallbacks::header_file` callback which runs on every
filename passed to `Builder::header`.
- Added the `CargoCallbacks::new` constructor which emits a cargo-rerun
line
for every input header file by default.
- Added the `CargoCallbacks::rerun_on_header_files` method to configure
whether
a cargo-rerun line should be emitted for every input header file.
#### Changed
- The `--wrap-static-fns` feature was updated so function types that has
no
argument use `void` as its sole argument.
- `CargoCallbacks` is no longer a [unit-like
struct](https://doc.rust-lang.org/reference/items/structs.html ) and the
`CargoCallbacks` constant was added to mitigate the breaking nature of
this
change. This constant has been marked as deprecated and users will have
to
use the new `CargoCallbacks::new` method in the future.
#### Removed
#### Fixed
- Allow compiling `bindgen-cli` with a static libclang.
- Emit an opaque integer type for pointer types that don't have the same
size
as the target's pointer size.
- Avoid escaping Objective-C method names unless they are `Self`,
`self`,
`crate` or `super`.
#### Security
###
[`v0.68.1`](https://togithub.com/rust-lang/rust-bindgen/blob/HEAD/CHANGELOG.md#0681 )
[Compare
Source](https://togithub.com/rust-lang/rust-bindgen/compare/v0.68.0...v0.68.1 )
#### Fixed
- Fixed errors on the windows artifact build process.
###
[`v0.68.0`](https://togithub.com/rust-lang/rust-bindgen/blob/HEAD/CHANGELOG.md#0680 )
[Compare
Source](https://togithub.com/rust-lang/rust-bindgen/compare/v0.66.1...v0.68.0 )
#### Added
- The `system` ABI is now supported as an option for the
`--override-abi` flag.
- The `allowlist_item` method and the `--allowlist-item` flag have been
included to filter items regardless or their kind.
- Include installers as release artifacts on Github.
#### Changed
- The `Clone` implementation for `_BindgenUnionField` has been changed
to pass
the `incorrect_clone_impl_on_copy_type` Clippy lint.
- The `c_unwind` ABI can be used without a feature gate for any Rust
target version
equal to or greater than 1.71.
This comes as a result of the ABI being stabilised (in Rust 1.71).
- Formatting changes when using prettyplease as a formatter due to a new
prettyplease version.
- Avoid generating invalid `CStr` constants when using the
`--generate-cstr`
option.
#### Removed
- The `extra_assert` and `extra_assert_eq` macros are no longer
exported.
#### Fixed
- Bindgen no longer panics when parsing an objective-C header that
includes a
Rust keyword that cannot be a raw identifier, such as: `self`, `crate`,
`super` or `Self`.
###
[`v0.66.1`](https://togithub.com/rust-lang/rust-bindgen/blob/HEAD/CHANGELOG.md#0661 )
[Compare
Source](https://togithub.com/rust-lang/rust-bindgen/compare/v0.66.0...v0.66.1 )
#### Removed
- Revert source order sorting
([#​2543](https://togithub.com/rust-lang/rust-bindgen/issues/2543 ))
due to correctness regressions
[#​2558](https://togithub.com/rust-lang/rust-bindgen/issues/2558 ).
###
[`v0.66.0`](https://togithub.com/rust-lang/rust-bindgen/blob/HEAD/CHANGELOG.md#0660 )
[Compare
Source](https://togithub.com/rust-lang/rust-bindgen/compare/v0.65.1...v0.66.0 )
#### Added
- Added the `--generate-cstr` CLI flag to generate string constants as
`&CStr`
instead of `&[u8]`. (Requires Rust 1.59 or higher.)
- Added the `--generate-shell-completions` CLI flag to generate
completions for
different shells.
- The `--wrap-static-fns` option can now wrap `va_list` functions as
variadic functions
with the experimental `ParseCallbacks::wrap_as_variadic_fn` method.
- Add target mappings for riscv32imc and riscv32imac.
- Add the `ParseCallbacks::field_visibility` method to modify field
visibility.
#### Changed
- Non-UTF-8 string constants are now generated as references (`&[u8;
SIZE]`)
instead of arrays (`[u8; SIZE]`) to match UTF-8 strings.
- Wrappers for static functions that return `void` no longer contain a
`return`
statement and only call the static function instead.
- The `--wrap-static-fns` option no longer emits wrappers for static
variadic
functions.
- Depfiles generated with `--depfile` or `Builder::depfile` will now
properly
generate module names and paths that include spaces by escaping them. To
make
the escaping clear and consistent, backslashes are also escaped.
- Updated `bitflags` dependency to 2.2.1. This changes the API of
`CodegenConfig`.
- Prettyplease formatting is gated by an optional, enabled by default
Cargo
feature when depending on `bindgen` as a library.
- Items are now parsed in the order they appear in source files. This
may result in
auto-generated `_bindgen_*` names having a different index.
- Use default visibility for padding fields: Previously, padding fields
were
always public. Now, they follow the default visibility for the type they
are
in.
- Compute visibility of bitfield unit based on actual field visibility:
A
bitfield unit field and its related functions now have their visibility
determined based on the most private between the default visibility and
the
actual visibility of the bitfields within the unit.
#### Removed
- Remove redundant Cargo features, which were all implicit:
- bindgen-cli: `env_logger` and `log` removed in favor of `logging`
- bindgen (lib):
- `log` removed in favor of `logging`
- `which` removed in favor of `which-logging`
- `annotate-snippets` removed in favor of `experimental`
- Prettyplease is available as a `Formatter` variant now.
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
Release Notes:
- N/A
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-08-28 22:12:49 -07:00
renovate[bot]
eb0b6d57e3
Update Rust crate cocoa to 0.26 ( #17036 )
...
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [cocoa](https://togithub.com/servo/core-foundation-rs ) | dependencies
| minor | `0.25` -> `0.26` |
| [cocoa](https://togithub.com/servo/core-foundation-rs ) |
workspace.dependencies | minor | `0.25` -> `0.26` |
---
### Configuration
📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
Release Notes:
- N/A
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
---------
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-08-28 21:57:26 -07:00
张小白
403fdd6018
windows: Fix autohide taskbar dosen't automatically appear when Zed is maximized ( #16806 )
...
Closes #12313
This PR introduces the following improvements:
1. Fixed the issue where the auto-hide taskbar wouldn't automatically
appear when Zed is maximized.
2. Refactored the `WM_NCCALCSIZE` code, making it more human-readable.
Release Notes:
- Fixed auto-hide taskbar would refuse to show itself when `Zed` is
maximized on
Winodws([#12313 ](https://github.com/zed-industries/zed/issues/12313 )).
---------
Co-authored-by: Mikayla Maki <mikayla@zed.dev>
2024-08-28 20:36:28 -07:00
apricotbucket28
a68a543d43
linux: Prompt library fixes ( #16850 )
...
This PR fixes two issues:
1. The prompt library window didn't set an `app_id` on Linux, which
caused it to be missing the Zed logo
2. A dangling reference to the window in the Wayland client code, which
caused the prompt library window not to close. See:
https://github.com/zed-industries/zed/pull/13201
Release Notes:
- Linux: Fixed the prompt library not closing on Wayland
---------
Co-authored-by: Junkui Zhang <364772080@qq.com>
2024-08-28 20:11:01 -07:00
张小白
9ad845b40a
windows: Implement theme changed events ( #16207 )
...
Closes [#16198 ](https://github.com/zed-industries/zed/issues/16198 )
AFAIK, when the system's theme mode or accent color changes, there are
typically two types of broadcast messages:
1. A `WM_SETTINGCHANGE` message, where `lParam` points to the string
"ImmersiveColorSet".
2. A `WM_DWMCOLORIZATIONCOLORCHANGED` message.
I use `WM_DWMCOLORIZATIONCOLORCHANGED` here for simplicity.
https://github.com/user-attachments/assets/422f8e4e-c698-4e7c-8d2d-01f453b9a7b3
Release Notes:
- N/A
2024-08-28 20:05:19 -07:00
Fernando Tagawa
8e8927db4b
linux: Fix IME panel position while enumerating input methods ( #12495 )
...
Release Notes:
- N/A
This updates the IME position every time the selection changes, this is
probably only useful when you enumerate languages with your IME.
TODO:
- ~There is a rare chance that the ime panel is not updated because the
window input handler is None.~
- ~Update IME panel in vim mode.~
- ~Update IME panel when leaving Buffer search input.~
---------
Co-authored-by: Mikayla Maki <mikayla@zed.dev>
2024-08-28 19:58:40 -07:00
张小白
aec8fb7e37
windows: Refactor prompt_for_paths and prompt_for_new_path ( #15774 )
...
Refactored `prompt_for_paths` and `prompt_for_new_path`, now errors can
propagate properly.
Release Notes:
- N/A
2024-08-28 19:51:39 -07:00
张小白
e8dfc30314
windows: Fix IME window position on Win10 ( #15471 )
...
On Windows, different input methods use different APIs to set their
window positions:
- The Japanese input method on Windows 11 uses `ImmSetCandidateWindow`.
- The Chinese input method on Windows 10 uses `ImmSetCompositionWindow`.
- The Chinese input method on Windows 11 can use either.
Therefore, this PR calls both functions to cover the various scenarios.
Additionally, introduced a helper function `with_input_handler` to
improve code readability.
Release Notes:
- N/A
2024-08-28 19:29:53 -07:00
Marshall Bowers
b374c7d912
Fix casing of "macOS" ( #17040 )
...
This PR fixes a number of spots in English contexts (docs, comments,
etc.) where we were using "MacOS" instead of "macOS".
Release Notes:
- N/A
2024-08-28 19:10:49 -04:00
renovate[bot]
0b6dc3e6c2
Update Rust crate cbindgen to 0.27.0 ( #17033 )
...
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [cbindgen](https://togithub.com/mozilla/cbindgen ) | build-dependencies
| minor | `0.26.0` -> `0.27.0` |
---
### Release Notes
<details>
<summary>mozilla/cbindgen (cbindgen)</summary>
###
[`v0.27.0`](https://togithub.com/mozilla/cbindgen/blob/HEAD/CHANGES#0270 )
[Compare
Source](https://togithub.com/mozilla/cbindgen/compare/0.26.0...v0.27.0 )
- Revert: The `Config` struct now has a private member.
\* Allow users to specify a crate version for bindings generation
([#​901](https://togithub.com/mozilla/cbindgen/issues/901 )).
\* Update MSRV to 1.74
([#​912](https://togithub.com/mozilla/cbindgen/issues/912 ),
[#​987](https://togithub.com/mozilla/cbindgen/issues/987 )).
\* Support #\[deprecated] on enum variants
([#​933](https://togithub.com/mozilla/cbindgen/issues/933 )).
\* Support integrating the package_version information in a header file
comment
([#​939](https://togithub.com/mozilla/cbindgen/issues/939 )).
\* Add a language backend
([#​942](https://togithub.com/mozilla/cbindgen/issues/942 )).
\* Support generics with defaulted args
([#​959](https://togithub.com/mozilla/cbindgen/issues/959 )).
\* Add `VaList` compatibility
([#​970](https://togithub.com/mozilla/cbindgen/issues/970 )).
</details>
---
### Configuration
📅 **Schedule**: Branch creation - "after 3pm on Wednesday" in timezone
America/New_York, Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box
---
Release Notes:
- N/A
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzguNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2024-08-28 18:41:04 -04:00
Piotr Osiewicz
4ec1f29df0
chore: Make some of the deps of gpui optional ( #16986 )
...
Minor bookkeeping, that takes down dep count of gpui from 454 to 430 for
me.
Release Notes:
- N/A
2024-08-28 10:05:50 +02:00
张小白
60af9dd4b1
Add .SystemUIFont to font list ( #15340 )
...
As discussed in #15326 , this font name should be included in the font
list since `settings.json` indicates that one can set the font to
`.SystemUIFont`.
Release Notes:
- N/A
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
2024-08-27 09:23:24 -04:00
Peter Tripp
d3d0c043f5
Support extended keys on Mac (insert, f13-f19) ( #16921 )
...
- Improved support for extended keyboards on Mac (F13-F19, Insert)
2024-08-27 09:09:57 -04:00
Piotr Osiewicz
226ec9d404
gpui: Fix performance of app menu opening with large # of windows ( #16939 )
...
This is officially my weirdest performance fix to date; With large # of
windows opening app menu could take a lot of time (we're talking few
seconds with 9 windows, a minute with 10 windows). The fix is to make
one method pub(crate).. What?
<img width="981" alt="image"
src="https://github.com/user-attachments/assets/83b26154-0acd-43ef-84b3-4b85cde36120 ">
We were spending most of the time on clear_pending_keystrokes, which -
funnily enough - called itself recursively. It turned out we have two
methods; `AppContext::clear_pending_keystrokes` and
WindowContext::clear_pending_keystrokes. The former calls the latter,
but - due to the fact that `WindowContext::clear_pending_keystrokes` is
private and `WindowContext` derefs to `AppContext` - `AppContext` one
ended up actually calling itself! The fix is plain and simple - marking
WindowContext one as pub(crate), so that it gets picked up as a method
to call over `AppContext::clear_pending_keystrokes`.
Closes #16895
Release Notes:
- Fixed app menu performance slowdowns when there are multiple windows
open.
2024-08-27 12:23:00 +02:00
apricotbucket28
29745ae229
blade: Align rasterized path bounds to whole pixels ( #16784 )
...
CI / Check formatting and spelling (push) Waiting to run
CI / (macOS) Run Clippy and tests (push) Waiting to run
CI / (Linux) Run Clippy and tests (push) Waiting to run
CI / (Windows) Run Clippy and tests (push) Waiting to run
CI / Create a macOS bundle (push) Blocked by required conditions
CI / Create a Linux bundle (push) Blocked by required conditions
CI / Create arm64 Linux bundle (push) Blocked by required conditions
Deploy Docs / Deploy Docs (push) Waiting to run
Docs / Check formatting (push) Waiting to run
Related: https://github.com/zed-industries/zed/pull/15822
| Before | After |
| --- | --- |
|
|
|
|
|
|
Release Notes:
- N/A
2024-08-27 01:26:59 +03:00
Kirill Bulatov
55dda0e6af
A set of small fixes ( #16849 )
...
CI / Check formatting and spelling (push) Waiting to run
CI / (macOS) Run Clippy and tests (push) Waiting to run
CI / (Linux) Run Clippy and tests (push) Waiting to run
CI / (Windows) Run Clippy and tests (push) Waiting to run
CI / Create a macOS bundle (push) Blocked by required conditions
CI / Create a Linux bundle (push) Blocked by required conditions
CI / Create arm64 Linux bundle (push) Blocked by required conditions
Deploy Docs / Deploy Docs (push) Waiting to run
Docs / Check formatting (push) Waiting to run
* Linux Clippy lints fixed
* Zed local tasks are now simpler to rerun
* Zed's `release-fast` build profile keeps the debug info so it's
possible to properly debug things without altering the sources
Release Notes:
- N/A
2024-08-26 02:24:08 +03:00
Walter de Jong
14f8d3a33a
gpui: Send correct kill signal on Linux ( #16797 )
...
CI / Check formatting and spelling (push) Waiting to run
CI / (macOS) Run Clippy and tests (push) Waiting to run
CI / (Linux) Run Clippy and tests (push) Waiting to run
CI / (Windows) Run Clippy and tests (push) Waiting to run
CI / Create a macOS bundle (push) Blocked by required conditions
CI / Create a Linux bundle (push) Blocked by required conditions
CI / Create arm64 Linux bundle (push) Blocked by required conditions
Deploy Docs / Deploy Docs (push) Waiting to run
Docs / Check formatting (push) Waiting to run
should be kill -0 (zero) instead
Related to #14291 and #14310
Release Notes:
- N/A
2024-08-24 22:11:06 +03:00
Jason Lee
938d93a64c
gpui: Add truncate and text_ellipsis to TextStyle ( #14850 )
...
Release Notes:
- N/A
Ref issue #4996
## Demo
```
cargo run -p gpui --example text_wrapper
```
https://github.com/user-attachments/assets/a7fcebf7-f287-4517-960d-76b12722a2d7
---------
Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
2024-08-23 14:02:51 -04:00
张小白
69e76a3bb9
Refactor all_font_names ( #15345 )
...
In the current code implementation, it seems that the only difference
between `all_font_names` and `all_font_families` is whether dynamically
loaded font resources are included. Specifically, `all_font_families`
returns the names of all system fonts, while `all_font_names` includes
both the system font names and the dynamically loaded font names. In
other words, `all_font_families` is a strict subset of `all_font_names`.
This is what I observed in my tests on macOS.
<img width="682" alt="截屏2024-07-28 00 49 29"
src="https://github.com/user-attachments/assets/47317c28-0074-49d2-bcfa-052cab13e335 ">
Related codes:
```rust
let x: HashSet<_> = self.all_font_names().into_iter().collect();
let y: HashSet<_> = self.all_font_families().into_iter().collect();
let only_in_x = x.difference(&y).collect::<Vec<_>>();
let only_in_y = y.difference(&x).collect::<Vec<_>>();
println!("=====================================");
println!("1 -> {:?}", only_in_x);
println!("-------------------------------------");
println!("2 -> {:?}", only_in_y);
```
Release Notes:
- N/A
2024-08-23 00:11:01 +02:00
Kyle Kelley
80c25960dd
repl: Set up a way to copy output from the REPL ( #16649 )
...
Closes #15494
Simple copy button to copy an individual output since selection is a bit
more work.
<img width="790" alt="image"
src="https://github.com/user-attachments/assets/4a7d8b69-70cc-428e-8fe3-b95386d341ee ">
Release Notes:
- repl: Copy output from the REPL using a button
---------
Co-authored-by: Mikayla <mikayla@zed.dev>
2024-08-22 15:03:42 -07:00
apricotbucket28
b19356ac69
linux: Ignore benign error when cancelling file picker ( #15553 )
...
Fixes https://github.com/zed-industries/zed/issues/15485
This should be clearer on the `ashpd` side, but `ResponseError` comes
from the portal
[Response](https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.Request.html#org-freedesktop-portal-request-response ),
which means the request itself didn't fail. Ignoring the `Other` variant
here should be safe.
Release Notes:
- Linux: Fixed benign error being shown when cancelling file picker
([#15485 ](https://github.com/zed-industries/zed/issues/15485 ))
2024-08-22 14:43:02 -07:00
apricotbucket28
7523a7a437
wayland: Do not reset clipboard data offer on keyboard leave ( #16126 )
...
Closes #14415
(also removed an unused serial while I was at it)
Release Notes:
- Linux: Fixed cross-window copy/paste not working in some Wayland
configurations.
2024-08-22 14:42:32 -07:00
apricotbucket28
e7c8dba54f
cosmic_text: Handle subpixel variants ( #16238 )
...
Closes https://github.com/zed-industries/zed/issues/14169 , closes
https://github.com/zed-industries/zed/issues/14387
| Before | After |
| --- | ---|
|
|
|
|
|
|
Release Notes:
- Linux: Improved text rendering by handling subpixel positioning.
2024-08-22 15:17:56 -06:00
