mirror of
https://github.com/zed-industries/zed.git
synced 2025-01-10 20:41:59 +00:00
44aed4a0cb
For #4965 There are still some minor issues: 1. When change the surround and delete the surround, we should also decide whether there are spaces inside after deleting/replacing according to whether it is open parentheses, and replace them accordingly, but at present, delete and change, haven't done this adaptation for current pr, I'm not sure if I can fit it in the back or if it needs to be fitted together. 2. In the selection mode, pressing s plus brackets should also trigger the Add Surrounds function, but this MR has not adapted the selection mode for the time being, I think we need to support different add behaviors for the three selection modes.(Currently in select mode, s is used for Substitute) 3. For the current change surrounds, if the user does not find the bracket that needs to be matched after entering cs, but it is a valid bracket, and will wait for the second input before failing, the better practice here should be to return to normal mode if the first bracket is not found 4. I reused BracketPair in language, but two of its properties weren't used in this mr, so I'm not sure if I should create a new struct with only start and end, which would have less code I'm not sure which ones need to be changed in the first issue, and which ones can be revised in the future, and it seems that they can be solved --------- Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com> |
||
|---|---|---|
| .. | ||
| atom.json | ||
| default-linux.json | ||
| default-macos.json | ||
| jetbrains.json | ||
| storybook.json | ||
| sublime_text.json | ||
| textmate.json | ||
| vim.json | ||