Thorsten Ball 8c681d0db3 lsp: Use itemDefaults if sent along with completion items (#11902) ... This fixes #10532 by properly making use of `itemDefaults.data` when that is sent along next to completion `items`. With this line here we tell the language server that we support `data` in `itemDefaults`, but we actually never checked for it and never used it: a0d7ec9f8e/crates/lsp/src/lsp.rs (L653) In the case of `tailwindcss-language-server` that means that most of the items it returns (more than 10k items!) were missing the `data` attribute, since the language server thought it can send it along in the `itemDefaults` (because we advertised our capability to use it.) When we then did a `completionItem/resolve`, we would not send a `data` attribute along, which lead to an error on the `tailwindcss-language-server` side and thus no documentation. This PR also adds support for the other `itemDefaults` that could be sent along and that we say we support: a0d7ec9f8e/crates/lsp/src/lsp.rs (L650-L653) `editRange` we handle separately, so this PR only adds the other 3. Release Notes: - Fixed documentation not showing up for completion items coming from `tailwindcss-language-server`. ([#10532](https://github.com/zed-industries/zed/issues/10532)). Demo: https://github.com/zed-industries/zed/assets/1185253/bc5ea0b3-7d83-499f-a908-b0d2a1db8a41		2024-05-16 13:26:07 +02:00
..
src	lsp: Use itemDefaults if sent along with completion items (#11902)	2024-05-16 13:26:07 +02:00
Cargo.toml	Extract http from util (#11680)	2024-05-10 15:50:20 -06:00
LICENSE-GPL	chore: Change AGPL-licensed crates to GPL (except for collab) (#4231)	2024-01-24 00:26:58 +01:00