mirror of
https://github.com/zed-industries/zed.git
synced 2025-01-16 15:11:25 +00:00
cea26c9d10
- Restore impl_actions! and remove derive(Action) Originally in gpui2 we inferred the action's namespace from the module it was defined in. This worked most of the time (ignoring the "remove_the_2" hack), but caused unintended (and mostly invisible) behavior in crates with multiple modules. #3577 restored the namespace parameter to actions!, and this PR reintroduces `impl_actions!` to do the same for non-unit structs. I considered trying to keep the struct-attribute API work, because it does feel more stylistically appropriate for rust, but two problems lead to it feeling less good than `impl_actions!` in practice: 1. You have to repeat the namespace for each struct (and usually you're defining them all in the same namespace) 2. You can't pass an argument to a derive macro inline, you need to use an attribute instead. Release Notes: - N/A |
||
---|---|---|
.. | ||
src | ||
Cargo.toml |