2021-04-05 05:56:10 +00:00
|
|
|
// Copyright 2021 Google LLC
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// https://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
2021-06-19 20:04:08 +00:00
|
|
|
use std::cmp::{max, min, Ordering};
|
|
|
|
use std::collections::{btree_map, BTreeMap, HashMap};
|
2021-03-20 21:44:00 +00:00
|
|
|
use std::fmt::{Debug, Formatter};
|
|
|
|
use std::ops::Range;
|
|
|
|
|
2021-06-19 20:04:08 +00:00
|
|
|
use itertools::Itertools;
|
|
|
|
|
2021-03-26 15:44:18 +00:00
|
|
|
pub fn find_line_ranges(text: &[u8]) -> Vec<Range<usize>> {
|
2021-03-20 21:44:00 +00:00
|
|
|
let mut ranges = vec![];
|
|
|
|
let mut start = 0;
|
|
|
|
loop {
|
|
|
|
match text[start..].iter().position(|b| *b == b'\n') {
|
|
|
|
None => {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
Some(i) => {
|
|
|
|
ranges.push(start..start + i + 1);
|
|
|
|
start += i + 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if start < text.len() {
|
|
|
|
ranges.push(start..text.len());
|
|
|
|
}
|
|
|
|
ranges
|
|
|
|
}
|
|
|
|
|
diff: do final refinement at byte-level for non-word bytes
This results in significantly more readable diffs on commits like
659393bec219 in this repo.
Before:
test bench_diff_10k_lines_reversed ... bench: 38,122,998 ns/iter (+/- 557,688)
test bench_diff_10k_modified_lines ... bench: 32,556,563 ns/iter (+/- 548,114)
test bench_diff_10k_unchanged_lines ... bench: 4,231 ns/iter (+/- 15)
test bench_diff_1k_lines_reversed ... bench: 958,296 ns/iter (+/- 46,963)
test bench_diff_1k_modified_lines ... bench: 3,014,723 ns/iter (+/- 15,830)
test bench_diff_1k_unchanged_lines ... bench: 249 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 78,599 ns/iter (+/- 1,079)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,493 ns/iter (+/- 413,712)
test bench_diff_10k_modified_lines ... bench: 37,352,516 ns/iter (+/- 1,293,950)
test bench_diff_10k_unchanged_lines ... bench: 4,238 ns/iter (+/- 13)
test bench_diff_1k_lines_reversed ... bench: 967,253 ns/iter (+/- 8,506)
test bench_diff_1k_modified_lines ... bench: 3,358,028 ns/iter (+/- 37,154)
test bench_diff_1k_unchanged_lines ... bench: 233 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 95,787 ns/iter (+/- 740)
So the biggest slowdown is when there are modified lines.
2021-04-07 17:07:37 +00:00
|
|
|
fn is_word_byte(b: u8) -> bool {
|
|
|
|
// TODO: Make this configurable (probably higher up in the call stack)
|
|
|
|
matches!(b, b'A'..=b'Z' | b'a'..=b'z' | b'0'..=b'9' | b'_')
|
|
|
|
}
|
|
|
|
|
2021-03-26 15:44:18 +00:00
|
|
|
pub fn find_word_ranges(text: &[u8]) -> Vec<Range<usize>> {
|
2021-03-20 21:44:00 +00:00
|
|
|
let mut word_ranges = vec![];
|
|
|
|
let mut word_start_pos = 0;
|
|
|
|
let mut in_word = false;
|
|
|
|
for (i, b) in text.iter().enumerate() {
|
diff: do final refinement at byte-level for non-word bytes
This results in significantly more readable diffs on commits like
659393bec219 in this repo.
Before:
test bench_diff_10k_lines_reversed ... bench: 38,122,998 ns/iter (+/- 557,688)
test bench_diff_10k_modified_lines ... bench: 32,556,563 ns/iter (+/- 548,114)
test bench_diff_10k_unchanged_lines ... bench: 4,231 ns/iter (+/- 15)
test bench_diff_1k_lines_reversed ... bench: 958,296 ns/iter (+/- 46,963)
test bench_diff_1k_modified_lines ... bench: 3,014,723 ns/iter (+/- 15,830)
test bench_diff_1k_unchanged_lines ... bench: 249 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 78,599 ns/iter (+/- 1,079)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,493 ns/iter (+/- 413,712)
test bench_diff_10k_modified_lines ... bench: 37,352,516 ns/iter (+/- 1,293,950)
test bench_diff_10k_unchanged_lines ... bench: 4,238 ns/iter (+/- 13)
test bench_diff_1k_lines_reversed ... bench: 967,253 ns/iter (+/- 8,506)
test bench_diff_1k_modified_lines ... bench: 3,358,028 ns/iter (+/- 37,154)
test bench_diff_1k_unchanged_lines ... bench: 233 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 95,787 ns/iter (+/- 740)
So the biggest slowdown is when there are modified lines.
2021-04-07 17:07:37 +00:00
|
|
|
if in_word && !is_word_byte(*b) {
|
2021-03-20 21:44:00 +00:00
|
|
|
in_word = false;
|
|
|
|
word_ranges.push(word_start_pos..i);
|
|
|
|
word_start_pos = i;
|
diff: do final refinement at byte-level for non-word bytes
This results in significantly more readable diffs on commits like
659393bec219 in this repo.
Before:
test bench_diff_10k_lines_reversed ... bench: 38,122,998 ns/iter (+/- 557,688)
test bench_diff_10k_modified_lines ... bench: 32,556,563 ns/iter (+/- 548,114)
test bench_diff_10k_unchanged_lines ... bench: 4,231 ns/iter (+/- 15)
test bench_diff_1k_lines_reversed ... bench: 958,296 ns/iter (+/- 46,963)
test bench_diff_1k_modified_lines ... bench: 3,014,723 ns/iter (+/- 15,830)
test bench_diff_1k_unchanged_lines ... bench: 249 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 78,599 ns/iter (+/- 1,079)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,493 ns/iter (+/- 413,712)
test bench_diff_10k_modified_lines ... bench: 37,352,516 ns/iter (+/- 1,293,950)
test bench_diff_10k_unchanged_lines ... bench: 4,238 ns/iter (+/- 13)
test bench_diff_1k_lines_reversed ... bench: 967,253 ns/iter (+/- 8,506)
test bench_diff_1k_modified_lines ... bench: 3,358,028 ns/iter (+/- 37,154)
test bench_diff_1k_unchanged_lines ... bench: 233 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 95,787 ns/iter (+/- 740)
So the biggest slowdown is when there are modified lines.
2021-04-07 17:07:37 +00:00
|
|
|
} else if !in_word && is_word_byte(*b) {
|
2021-03-20 21:44:00 +00:00
|
|
|
in_word = true;
|
|
|
|
word_start_pos = i;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if in_word && word_start_pos < text.len() {
|
|
|
|
word_ranges.push(word_start_pos..text.len());
|
|
|
|
}
|
|
|
|
word_ranges
|
|
|
|
}
|
|
|
|
|
diff: do final refinement at byte-level for non-word bytes
This results in significantly more readable diffs on commits like
659393bec219 in this repo.
Before:
test bench_diff_10k_lines_reversed ... bench: 38,122,998 ns/iter (+/- 557,688)
test bench_diff_10k_modified_lines ... bench: 32,556,563 ns/iter (+/- 548,114)
test bench_diff_10k_unchanged_lines ... bench: 4,231 ns/iter (+/- 15)
test bench_diff_1k_lines_reversed ... bench: 958,296 ns/iter (+/- 46,963)
test bench_diff_1k_modified_lines ... bench: 3,014,723 ns/iter (+/- 15,830)
test bench_diff_1k_unchanged_lines ... bench: 249 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 78,599 ns/iter (+/- 1,079)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,493 ns/iter (+/- 413,712)
test bench_diff_10k_modified_lines ... bench: 37,352,516 ns/iter (+/- 1,293,950)
test bench_diff_10k_unchanged_lines ... bench: 4,238 ns/iter (+/- 13)
test bench_diff_1k_lines_reversed ... bench: 967,253 ns/iter (+/- 8,506)
test bench_diff_1k_modified_lines ... bench: 3,358,028 ns/iter (+/- 37,154)
test bench_diff_1k_unchanged_lines ... bench: 233 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 95,787 ns/iter (+/- 740)
So the biggest slowdown is when there are modified lines.
2021-04-07 17:07:37 +00:00
|
|
|
pub fn find_nonword_ranges(text: &[u8]) -> Vec<Range<usize>> {
|
diff: first diff lines, then refine to words, producing better diffs
The new diff algorithm produces pretty bad diffs in some cases, such
as cc4b1e923091 in this repo (the parent of this commit). I think the
problem there is that many words are repeated over and over. Diffing
first at the line level and then refining the diff of the changed
ranges at the word level gives much better results. That's what this
patch does. After this patch, `jj diff -r cc4b1e923091` looks pretty
similar to the diff in GitHub's UI.
I hope to get around to doing the same for the merge code soon.
Impact on benchmarks:
Before:
test bench_diff_10k_lines_reversed ... bench: 42,647,532 ns/iter (+/- 765,347)
test bench_diff_10k_modified_lines ... bench: 21,407,980 ns/iter (+/- 126,366)
test bench_diff_10k_unchanged_lines ... bench: 4,235 ns/iter (+/- 16)
test bench_diff_1k_lines_reversed ... bench: 1,190,483 ns/iter (+/- 7,192)
test bench_diff_1k_modified_lines ... bench: 1,919,766 ns/iter (+/- 9,665)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 174,702 ns/iter (+/- 1,199)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,509 ns/iter (+/- 129,004)
test bench_diff_10k_modified_lines ... bench: 33,140,659 ns/iter (+/- 3,989,339)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 14)
test bench_diff_1k_lines_reversed ... bench: 973,551 ns/iter (+/- 94,895)
test bench_diff_1k_modified_lines ... bench: 3,033,818 ns/iter (+/- 29,513)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 79,100 ns/iter (+/- 963)
So most of them get slower, as expected. The last one, taken from a
real diff in the git.git repo, get faster, however (which is also what
I would have expected).
2021-04-03 22:37:55 +00:00
|
|
|
let mut ranges = vec![];
|
|
|
|
for (i, b) in text.iter().enumerate() {
|
diff: do final refinement at byte-level for non-word bytes
This results in significantly more readable diffs on commits like
659393bec219 in this repo.
Before:
test bench_diff_10k_lines_reversed ... bench: 38,122,998 ns/iter (+/- 557,688)
test bench_diff_10k_modified_lines ... bench: 32,556,563 ns/iter (+/- 548,114)
test bench_diff_10k_unchanged_lines ... bench: 4,231 ns/iter (+/- 15)
test bench_diff_1k_lines_reversed ... bench: 958,296 ns/iter (+/- 46,963)
test bench_diff_1k_modified_lines ... bench: 3,014,723 ns/iter (+/- 15,830)
test bench_diff_1k_unchanged_lines ... bench: 249 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 78,599 ns/iter (+/- 1,079)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,493 ns/iter (+/- 413,712)
test bench_diff_10k_modified_lines ... bench: 37,352,516 ns/iter (+/- 1,293,950)
test bench_diff_10k_unchanged_lines ... bench: 4,238 ns/iter (+/- 13)
test bench_diff_1k_lines_reversed ... bench: 967,253 ns/iter (+/- 8,506)
test bench_diff_1k_modified_lines ... bench: 3,358,028 ns/iter (+/- 37,154)
test bench_diff_1k_unchanged_lines ... bench: 233 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 95,787 ns/iter (+/- 740)
So the biggest slowdown is when there are modified lines.
2021-04-07 17:07:37 +00:00
|
|
|
if !is_word_byte(*b) {
|
diff: first diff lines, then refine to words, producing better diffs
The new diff algorithm produces pretty bad diffs in some cases, such
as cc4b1e923091 in this repo (the parent of this commit). I think the
problem there is that many words are repeated over and over. Diffing
first at the line level and then refining the diff of the changed
ranges at the word level gives much better results. That's what this
patch does. After this patch, `jj diff -r cc4b1e923091` looks pretty
similar to the diff in GitHub's UI.
I hope to get around to doing the same for the merge code soon.
Impact on benchmarks:
Before:
test bench_diff_10k_lines_reversed ... bench: 42,647,532 ns/iter (+/- 765,347)
test bench_diff_10k_modified_lines ... bench: 21,407,980 ns/iter (+/- 126,366)
test bench_diff_10k_unchanged_lines ... bench: 4,235 ns/iter (+/- 16)
test bench_diff_1k_lines_reversed ... bench: 1,190,483 ns/iter (+/- 7,192)
test bench_diff_1k_modified_lines ... bench: 1,919,766 ns/iter (+/- 9,665)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 174,702 ns/iter (+/- 1,199)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,509 ns/iter (+/- 129,004)
test bench_diff_10k_modified_lines ... bench: 33,140,659 ns/iter (+/- 3,989,339)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 14)
test bench_diff_1k_lines_reversed ... bench: 973,551 ns/iter (+/- 94,895)
test bench_diff_1k_modified_lines ... bench: 3,033,818 ns/iter (+/- 29,513)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 79,100 ns/iter (+/- 963)
So most of them get slower, as expected. The last one, taken from a
real diff in the git.git repo, get faster, however (which is also what
I would have expected).
2021-04-03 22:37:55 +00:00
|
|
|
ranges.push(i..i + 1);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
ranges
|
|
|
|
}
|
|
|
|
|
2021-03-20 21:44:00 +00:00
|
|
|
struct Histogram<'a> {
|
|
|
|
word_to_positions: HashMap<&'a [u8], Vec<usize>>,
|
|
|
|
count_to_words: BTreeMap<usize, Vec<&'a [u8]>>,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl Histogram<'_> {
|
|
|
|
fn calculate<'a>(
|
|
|
|
text: &'a [u8],
|
|
|
|
ranges: &[Range<usize>],
|
|
|
|
max_occurrences: usize,
|
|
|
|
) -> Histogram<'a> {
|
|
|
|
let mut word_to_positions: HashMap<&[u8], Vec<usize>> = HashMap::new();
|
|
|
|
for (i, range) in ranges.iter().enumerate() {
|
|
|
|
let positions = word_to_positions.entry(&text[range.clone()]).or_default();
|
|
|
|
// Allow one more than max_occurrences, so we can later skip those with more
|
|
|
|
// than max_occurrences
|
|
|
|
if positions.len() <= max_occurrences {
|
|
|
|
positions.push(i);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
let mut count_to_words: BTreeMap<usize, Vec<&[u8]>> = BTreeMap::new();
|
|
|
|
for (word, ranges) in &word_to_positions {
|
|
|
|
count_to_words.entry(ranges.len()).or_default().push(word);
|
|
|
|
}
|
|
|
|
Histogram {
|
|
|
|
word_to_positions,
|
|
|
|
count_to_words,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(Clone, PartialEq, Eq, Hash, Debug)]
|
|
|
|
enum RangeDiff {
|
|
|
|
Unchanged(Range<usize>, Range<usize>),
|
|
|
|
Replaced(Range<usize>, Range<usize>),
|
|
|
|
}
|
|
|
|
|
|
|
|
impl RangeDiff {
|
|
|
|
fn is_empty(&self) -> bool {
|
|
|
|
match self {
|
|
|
|
RangeDiff::Unchanged(left_range, right_range) => {
|
|
|
|
left_range.is_empty() && right_range.is_empty()
|
|
|
|
}
|
|
|
|
RangeDiff::Replaced(left_range, right_range) => {
|
|
|
|
left_range.is_empty() && right_range.is_empty()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(Clone, PartialEq, Eq, Hash)]
|
|
|
|
pub enum SliceDiff<'a> {
|
|
|
|
Unchanged(&'a [u8]),
|
|
|
|
Replaced(&'a [u8], &'a [u8]),
|
|
|
|
}
|
|
|
|
|
|
|
|
impl Debug for SliceDiff<'_> {
|
|
|
|
fn fmt(&self, f: &mut Formatter<'_>) -> Result<(), std::fmt::Error> {
|
|
|
|
match self {
|
|
|
|
SliceDiff::Unchanged(data) => f
|
diff: also recurse into final region after after unchanged regions
See test case for details.
Before:
test bench_diff_10k_lines_reversed ... bench: 36,249,659 ns/iter (+/- 174,455)
test bench_diff_10k_modified_lines ... bench: 37,258,890 ns/iter (+/- 803,963)
test bench_diff_10k_unchanged_lines ... bench: 4,252 ns/iter (+/- 69)
test bench_diff_1k_lines_reversed ... bench: 982,834 ns/iter (+/- 6,467)
test bench_diff_1k_modified_lines ... bench: 3,343,469 ns/iter (+/- 23,243)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 95,559 ns/iter (+/- 816)
After:
test bench_diff_10k_lines_reversed ... bench: 36,186,715 ns/iter (+/- 196,903)
test bench_diff_10k_modified_lines ... bench: 37,511,000 ns/iter (+/- 1,370,476)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 8)
test bench_diff_1k_lines_reversed ... bench: 986,010 ns/iter (+/- 11,565)
test bench_diff_1k_modified_lines ... bench: 3,370,938 ns/iter (+/- 17,041)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 102,189 ns/iter (+/- 1,052)
So this patch makes diffing even slower (but still easily fast enough
for all cases I've run into in real life). There's probably a lot that
can be done to make things faster, but the first priority is that the
diffs are correct and easy to read.
2021-04-08 06:26:19 +00:00
|
|
|
.debug_tuple("SliceDiff::Unchanged")
|
2021-03-20 21:44:00 +00:00
|
|
|
.field(&String::from_utf8_lossy(data))
|
|
|
|
.finish(),
|
|
|
|
SliceDiff::Replaced(left, right) => f
|
diff: also recurse into final region after after unchanged regions
See test case for details.
Before:
test bench_diff_10k_lines_reversed ... bench: 36,249,659 ns/iter (+/- 174,455)
test bench_diff_10k_modified_lines ... bench: 37,258,890 ns/iter (+/- 803,963)
test bench_diff_10k_unchanged_lines ... bench: 4,252 ns/iter (+/- 69)
test bench_diff_1k_lines_reversed ... bench: 982,834 ns/iter (+/- 6,467)
test bench_diff_1k_modified_lines ... bench: 3,343,469 ns/iter (+/- 23,243)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 95,559 ns/iter (+/- 816)
After:
test bench_diff_10k_lines_reversed ... bench: 36,186,715 ns/iter (+/- 196,903)
test bench_diff_10k_modified_lines ... bench: 37,511,000 ns/iter (+/- 1,370,476)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 8)
test bench_diff_1k_lines_reversed ... bench: 986,010 ns/iter (+/- 11,565)
test bench_diff_1k_modified_lines ... bench: 3,370,938 ns/iter (+/- 17,041)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 102,189 ns/iter (+/- 1,052)
So this patch makes diffing even slower (but still easily fast enough
for all cases I've run into in real life). There's probably a lot that
can be done to make things faster, but the first priority is that the
diffs are correct and easy to read.
2021-04-08 06:26:19 +00:00
|
|
|
.debug_tuple("SliceDiff::Replaced")
|
2021-03-20 21:44:00 +00:00
|
|
|
.field(&String::from_utf8_lossy(left))
|
|
|
|
.field(&String::from_utf8_lossy(right))
|
|
|
|
.finish(),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Finds the LCS given a array where the value of `input[i]` indicates that
|
|
|
|
/// the position of element `i` in the right array is at position `input[i]` in
|
|
|
|
/// the left array.
|
|
|
|
///
|
|
|
|
/// For example (some have multiple valid outputs):
|
|
|
|
///
|
|
|
|
/// [0,1,2] => [(0,0),(1,1),(2,2)]
|
|
|
|
/// [2,1,0] => [(0,2)]
|
|
|
|
/// [0,1,4,2,3,5,6] => [(0,0),(1,1),(2,3),(3,4),(5,5),(6,6)]
|
|
|
|
/// [0,1,4,3,2,5,6] => [(0,0),(1,1),(4,2),(5,5),(6,6)]
|
|
|
|
fn find_lcs(input: &[usize]) -> Vec<(usize, usize)> {
|
|
|
|
if input.is_empty() {
|
|
|
|
return vec![];
|
|
|
|
}
|
|
|
|
|
|
|
|
let mut chain = vec![(0, 0, 0); input.len()];
|
2021-04-29 05:41:20 +00:00
|
|
|
let mut global_longest = 0;
|
|
|
|
let mut global_longest_right_pos = 0;
|
2021-03-20 21:44:00 +00:00
|
|
|
for (right_pos, &left_pos) in input.iter().enumerate() {
|
2021-04-29 05:41:20 +00:00
|
|
|
let mut longest_from_here = 1;
|
|
|
|
let mut previous_right_pos = usize::MAX;
|
2021-03-20 21:44:00 +00:00
|
|
|
for i in (0..right_pos).rev() {
|
|
|
|
let (previous_len, previous_left_pos, _) = chain[i];
|
|
|
|
if previous_left_pos < left_pos {
|
|
|
|
let len = previous_len + 1;
|
2021-04-29 05:41:20 +00:00
|
|
|
if len > longest_from_here {
|
|
|
|
longest_from_here = len;
|
|
|
|
previous_right_pos = i;
|
|
|
|
if len > global_longest {
|
|
|
|
global_longest = len;
|
|
|
|
global_longest_right_pos = right_pos;
|
|
|
|
// If this is the longest chain globally so far, we cannot find a
|
|
|
|
// longer one by using a previous value, so break early.
|
|
|
|
break;
|
|
|
|
}
|
2021-03-20 21:44:00 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2021-04-29 05:41:20 +00:00
|
|
|
chain[right_pos] = (longest_from_here, left_pos, previous_right_pos);
|
2021-03-20 21:44:00 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
let mut result = vec![];
|
2021-04-29 05:41:20 +00:00
|
|
|
let mut right_pos = global_longest_right_pos;
|
2021-03-20 21:44:00 +00:00
|
|
|
loop {
|
|
|
|
let (_, left_pos, previous_right_pos) = chain[right_pos];
|
|
|
|
result.push((left_pos, right_pos));
|
|
|
|
if previous_right_pos == usize::MAX {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
right_pos = previous_right_pos;
|
|
|
|
}
|
|
|
|
result.reverse();
|
|
|
|
|
|
|
|
result
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Finds unchanged ranges among the ones given as arguments. The data between
|
|
|
|
/// those ranges is ignored.
|
2021-03-26 15:44:18 +00:00
|
|
|
pub(crate) fn unchanged_ranges(
|
2021-03-20 21:44:00 +00:00
|
|
|
left: &[u8],
|
|
|
|
right: &[u8],
|
|
|
|
left_ranges: &[Range<usize>],
|
|
|
|
right_ranges: &[Range<usize>],
|
|
|
|
) -> Vec<(Range<usize>, Range<usize>)> {
|
|
|
|
if left_ranges.is_empty() || right_ranges.is_empty() {
|
|
|
|
return vec![];
|
|
|
|
}
|
|
|
|
|
|
|
|
let max_occurrences = 100;
|
|
|
|
let mut left_histogram = Histogram::calculate(left, left_ranges, max_occurrences);
|
|
|
|
if *left_histogram.count_to_words.first_entry().unwrap().key() > max_occurrences {
|
|
|
|
// If there are very many occurrences of all words, then we just give up.
|
|
|
|
return vec![];
|
|
|
|
}
|
|
|
|
let mut right_histogram = Histogram::calculate(right, right_ranges, max_occurrences);
|
|
|
|
// Look for words with few occurrences in `left` (could equally well have picked
|
|
|
|
// `right`?). If any of them also occur in `right`, then we add the words to
|
|
|
|
// the LCS.
|
|
|
|
let mut uncommon_shared_words = vec![];
|
|
|
|
while !left_histogram.count_to_words.is_empty() && uncommon_shared_words.is_empty() {
|
|
|
|
let left_words = left_histogram.count_to_words.pop_first().unwrap().1;
|
|
|
|
for left_word in left_words {
|
|
|
|
if right_histogram.word_to_positions.contains_key(left_word) {
|
|
|
|
uncommon_shared_words.push(left_word);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
diff: also recurse into final region after after unchanged regions
See test case for details.
Before:
test bench_diff_10k_lines_reversed ... bench: 36,249,659 ns/iter (+/- 174,455)
test bench_diff_10k_modified_lines ... bench: 37,258,890 ns/iter (+/- 803,963)
test bench_diff_10k_unchanged_lines ... bench: 4,252 ns/iter (+/- 69)
test bench_diff_1k_lines_reversed ... bench: 982,834 ns/iter (+/- 6,467)
test bench_diff_1k_modified_lines ... bench: 3,343,469 ns/iter (+/- 23,243)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 95,559 ns/iter (+/- 816)
After:
test bench_diff_10k_lines_reversed ... bench: 36,186,715 ns/iter (+/- 196,903)
test bench_diff_10k_modified_lines ... bench: 37,511,000 ns/iter (+/- 1,370,476)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 8)
test bench_diff_1k_lines_reversed ... bench: 986,010 ns/iter (+/- 11,565)
test bench_diff_1k_modified_lines ... bench: 3,370,938 ns/iter (+/- 17,041)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 102,189 ns/iter (+/- 1,052)
So this patch makes diffing even slower (but still easily fast enough
for all cases I've run into in real life). There's probably a lot that
can be done to make things faster, but the first priority is that the
diffs are correct and easy to read.
2021-04-08 06:26:19 +00:00
|
|
|
if uncommon_shared_words.is_empty() {
|
|
|
|
return vec![];
|
|
|
|
}
|
2021-03-20 21:44:00 +00:00
|
|
|
|
|
|
|
// Let's say our inputs are "a b a b" and "a b c c b a b". We will have found
|
|
|
|
// the least common words to be "a" and "b". We now assume that each
|
|
|
|
// occurrence of each word lines up in the left and right input. We do that
|
|
|
|
// by numbering the shared occurrences, effectively instead comparing "a1 b1
|
|
|
|
// a2 b2" and "a1 b1 c c b2 a2 b". We then walk the common words in the
|
|
|
|
// right input in order (["a1", "b1", "b2", "a2"]), and record the index of
|
|
|
|
// that word in the left input ([0,1,3,2]). We then find the LCS and split
|
|
|
|
// points based on that ([0,1,3] or [0,1,2] are both valid).
|
|
|
|
|
|
|
|
// [(index into left_ranges, word, occurrence #)]
|
|
|
|
let mut left_positions = vec![];
|
|
|
|
let mut right_positions = vec![];
|
|
|
|
for uncommon_shared_word in uncommon_shared_words {
|
|
|
|
let left_occurrences = left_histogram
|
|
|
|
.word_to_positions
|
|
|
|
.get_mut(uncommon_shared_word)
|
|
|
|
.unwrap();
|
|
|
|
let right_occurrences = right_histogram
|
|
|
|
.word_to_positions
|
|
|
|
.get_mut(uncommon_shared_word)
|
|
|
|
.unwrap();
|
|
|
|
let shared_count = min(left_occurrences.len(), right_occurrences.len());
|
|
|
|
for occurrence in 0..shared_count {
|
|
|
|
left_positions.push((
|
|
|
|
left_occurrences[occurrence],
|
|
|
|
uncommon_shared_word,
|
|
|
|
occurrence,
|
|
|
|
));
|
|
|
|
right_positions.push((
|
|
|
|
right_occurrences[occurrence],
|
|
|
|
uncommon_shared_word,
|
|
|
|
occurrence,
|
|
|
|
));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
left_positions.sort();
|
|
|
|
right_positions.sort();
|
|
|
|
let mut left_position_map = HashMap::new();
|
|
|
|
for (i, (_pos, word, occurrence)) in left_positions.iter().enumerate() {
|
|
|
|
left_position_map.insert((*word, *occurrence), i);
|
|
|
|
}
|
|
|
|
let mut left_index_by_right_index = vec![];
|
|
|
|
for (_pos, word, occurrence) in &right_positions {
|
|
|
|
left_index_by_right_index.push(*left_position_map.get(&(*word, *occurrence)).unwrap());
|
|
|
|
}
|
diff: also recurse into final region after after unchanged regions
See test case for details.
Before:
test bench_diff_10k_lines_reversed ... bench: 36,249,659 ns/iter (+/- 174,455)
test bench_diff_10k_modified_lines ... bench: 37,258,890 ns/iter (+/- 803,963)
test bench_diff_10k_unchanged_lines ... bench: 4,252 ns/iter (+/- 69)
test bench_diff_1k_lines_reversed ... bench: 982,834 ns/iter (+/- 6,467)
test bench_diff_1k_modified_lines ... bench: 3,343,469 ns/iter (+/- 23,243)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 95,559 ns/iter (+/- 816)
After:
test bench_diff_10k_lines_reversed ... bench: 36,186,715 ns/iter (+/- 196,903)
test bench_diff_10k_modified_lines ... bench: 37,511,000 ns/iter (+/- 1,370,476)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 8)
test bench_diff_1k_lines_reversed ... bench: 986,010 ns/iter (+/- 11,565)
test bench_diff_1k_modified_lines ... bench: 3,370,938 ns/iter (+/- 17,041)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 102,189 ns/iter (+/- 1,052)
So this patch makes diffing even slower (but still easily fast enough
for all cases I've run into in real life). There's probably a lot that
can be done to make things faster, but the first priority is that the
diffs are correct and easy to read.
2021-04-08 06:26:19 +00:00
|
|
|
|
2021-03-20 21:44:00 +00:00
|
|
|
let lcs = find_lcs(&left_index_by_right_index);
|
|
|
|
|
|
|
|
// Produce output ranges, recursing into the modified areas between the elements
|
|
|
|
// in the LCS.
|
|
|
|
let mut result = vec![];
|
|
|
|
let mut previous_left_position = 0;
|
|
|
|
let mut previous_right_position = 0;
|
|
|
|
for (left_index, right_index) in lcs {
|
|
|
|
let left_position = left_positions[left_index].0;
|
|
|
|
let right_position = right_positions[right_index].0;
|
|
|
|
let skipped_left_positions = previous_left_position..left_position;
|
|
|
|
let skipped_right_positions = previous_right_position..right_position;
|
|
|
|
if !skipped_left_positions.is_empty() || !skipped_right_positions.is_empty() {
|
|
|
|
for unchanged_nested_range in unchanged_ranges(
|
|
|
|
left,
|
|
|
|
right,
|
|
|
|
&left_ranges[skipped_left_positions.clone()],
|
|
|
|
&right_ranges[skipped_right_positions.clone()],
|
|
|
|
) {
|
|
|
|
result.push(unchanged_nested_range);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
result.push((
|
|
|
|
left_ranges[left_position].clone(),
|
|
|
|
right_ranges[right_position].clone(),
|
|
|
|
));
|
|
|
|
previous_left_position = left_position + 1;
|
|
|
|
previous_right_position = right_position + 1;
|
|
|
|
}
|
diff: also recurse into final region after after unchanged regions
See test case for details.
Before:
test bench_diff_10k_lines_reversed ... bench: 36,249,659 ns/iter (+/- 174,455)
test bench_diff_10k_modified_lines ... bench: 37,258,890 ns/iter (+/- 803,963)
test bench_diff_10k_unchanged_lines ... bench: 4,252 ns/iter (+/- 69)
test bench_diff_1k_lines_reversed ... bench: 982,834 ns/iter (+/- 6,467)
test bench_diff_1k_modified_lines ... bench: 3,343,469 ns/iter (+/- 23,243)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 95,559 ns/iter (+/- 816)
After:
test bench_diff_10k_lines_reversed ... bench: 36,186,715 ns/iter (+/- 196,903)
test bench_diff_10k_modified_lines ... bench: 37,511,000 ns/iter (+/- 1,370,476)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 8)
test bench_diff_1k_lines_reversed ... bench: 986,010 ns/iter (+/- 11,565)
test bench_diff_1k_modified_lines ... bench: 3,370,938 ns/iter (+/- 17,041)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 102,189 ns/iter (+/- 1,052)
So this patch makes diffing even slower (but still easily fast enough
for all cases I've run into in real life). There's probably a lot that
can be done to make things faster, but the first priority is that the
diffs are correct and easy to read.
2021-04-08 06:26:19 +00:00
|
|
|
// Also recurse into range at end (after common ranges).
|
|
|
|
let skipped_left_positions = previous_left_position..left_ranges.len();
|
|
|
|
let skipped_right_positions = previous_right_position..right_ranges.len();
|
|
|
|
if !skipped_left_positions.is_empty() || !skipped_right_positions.is_empty() {
|
|
|
|
for unchanged_nested_range in unchanged_ranges(
|
|
|
|
left,
|
|
|
|
right,
|
|
|
|
&left_ranges[skipped_left_positions],
|
|
|
|
&right_ranges[skipped_right_positions],
|
|
|
|
) {
|
|
|
|
result.push(unchanged_nested_range);
|
|
|
|
}
|
|
|
|
}
|
2021-03-20 21:44:00 +00:00
|
|
|
|
|
|
|
result
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Adds ranges between around the `input` ranges so that the full ranges of
|
|
|
|
/// `left` and `right` are covered.
|
|
|
|
fn fill_in_range_gaps(
|
|
|
|
left: &[u8],
|
|
|
|
right: &[u8],
|
|
|
|
input: &[(Range<usize>, Range<usize>)],
|
|
|
|
) -> Vec<RangeDiff> {
|
|
|
|
let mut output = vec![];
|
|
|
|
let mut previous_left_end_pos = 0;
|
|
|
|
let mut previous_right_end_pos = 0;
|
|
|
|
// Add an empty range at the end in order to fill in any gap just before the
|
|
|
|
// end (without needing to duplicate code for that after the loop).
|
|
|
|
for (left_range, right_range) in input
|
|
|
|
.iter()
|
|
|
|
.chain(&[(left.len()..left.len(), right.len()..right.len())])
|
|
|
|
{
|
|
|
|
let left_gap_range = previous_left_end_pos..left_range.start;
|
|
|
|
let right_gap_range = previous_right_end_pos..right_range.start;
|
|
|
|
if !left_gap_range.is_empty() || !right_gap_range.is_empty() {
|
|
|
|
if left[left_gap_range.clone()] == right[right_gap_range.clone()] {
|
|
|
|
output.push(RangeDiff::Unchanged(left_gap_range, right_gap_range));
|
|
|
|
} else {
|
|
|
|
output.push(RangeDiff::Replaced(left_gap_range, right_gap_range));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
previous_left_end_pos = left_range.end;
|
|
|
|
previous_right_end_pos = right_range.end;
|
|
|
|
if !(left_range.is_empty() && right_range.is_empty()) {
|
|
|
|
output.push(RangeDiff::Unchanged(
|
|
|
|
left_range.clone(),
|
|
|
|
right_range.clone(),
|
|
|
|
));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
output
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Combines adjacent ranges of the same type into larger ranges. Removes empty
|
|
|
|
/// ranges.
|
|
|
|
fn compact_ranges(input: &[RangeDiff]) -> Vec<RangeDiff> {
|
|
|
|
if input.is_empty() {
|
|
|
|
return vec![];
|
|
|
|
}
|
|
|
|
let mut output = vec![];
|
|
|
|
let mut current_range = input[0].clone();
|
|
|
|
for range in input.iter().skip(1) {
|
|
|
|
match (&mut current_range, range) {
|
|
|
|
(RangeDiff::Unchanged(left1, right1), RangeDiff::Unchanged(left2, right2)) => {
|
|
|
|
left1.end = left2.end;
|
|
|
|
right1.end = right2.end;
|
|
|
|
}
|
|
|
|
(RangeDiff::Replaced(left1, right1), RangeDiff::Replaced(left2, right2)) => {
|
|
|
|
left1.end = left2.end;
|
|
|
|
right1.end = right2.end;
|
|
|
|
}
|
|
|
|
_ => {
|
|
|
|
// The previous range was unchanged and this one was replaced, or vice versa.
|
|
|
|
// If the new range is empty, just ignore it, so we can possibly compact
|
|
|
|
// with the previous one.
|
|
|
|
if !range.is_empty() {
|
|
|
|
if !current_range.is_empty() {
|
|
|
|
output.push(current_range.clone());
|
|
|
|
}
|
|
|
|
current_range = range.clone();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if !current_range.is_empty() {
|
|
|
|
output.push(current_range);
|
|
|
|
}
|
|
|
|
output
|
|
|
|
}
|
|
|
|
|
diff: first diff lines, then refine to words, producing better diffs
The new diff algorithm produces pretty bad diffs in some cases, such
as cc4b1e923091 in this repo (the parent of this commit). I think the
problem there is that many words are repeated over and over. Diffing
first at the line level and then refining the diff of the changed
ranges at the word level gives much better results. That's what this
patch does. After this patch, `jj diff -r cc4b1e923091` looks pretty
similar to the diff in GitHub's UI.
I hope to get around to doing the same for the merge code soon.
Impact on benchmarks:
Before:
test bench_diff_10k_lines_reversed ... bench: 42,647,532 ns/iter (+/- 765,347)
test bench_diff_10k_modified_lines ... bench: 21,407,980 ns/iter (+/- 126,366)
test bench_diff_10k_unchanged_lines ... bench: 4,235 ns/iter (+/- 16)
test bench_diff_1k_lines_reversed ... bench: 1,190,483 ns/iter (+/- 7,192)
test bench_diff_1k_modified_lines ... bench: 1,919,766 ns/iter (+/- 9,665)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 174,702 ns/iter (+/- 1,199)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,509 ns/iter (+/- 129,004)
test bench_diff_10k_modified_lines ... bench: 33,140,659 ns/iter (+/- 3,989,339)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 14)
test bench_diff_1k_lines_reversed ... bench: 973,551 ns/iter (+/- 94,895)
test bench_diff_1k_modified_lines ... bench: 3,033,818 ns/iter (+/- 29,513)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 79,100 ns/iter (+/- 963)
So most of them get slower, as expected. The last one, taken from a
real diff in the git.git repo, get faster, however (which is also what
I would have expected).
2021-04-03 22:37:55 +00:00
|
|
|
fn refine_changed_ranges<'a>(
|
|
|
|
left: &'a [u8],
|
|
|
|
right: &'a [u8],
|
|
|
|
input: &[RangeDiff],
|
|
|
|
tokenizer: &impl Fn(&[u8]) -> Vec<Range<usize>>,
|
|
|
|
) -> Vec<RangeDiff> {
|
|
|
|
let mut output = vec![];
|
|
|
|
for range_diff in input {
|
|
|
|
match range_diff {
|
|
|
|
RangeDiff::Replaced(left_range, right_range) => {
|
|
|
|
let left_slice = &left[left_range.clone()];
|
|
|
|
let right_slice = &right[right_range.clone()];
|
2021-06-14 07:18:38 +00:00
|
|
|
let refined_left_ranges: Vec<Range<usize>> = tokenizer(left_slice);
|
|
|
|
let refined_right_ranges: Vec<Range<usize>> = tokenizer(right_slice);
|
diff: first diff lines, then refine to words, producing better diffs
The new diff algorithm produces pretty bad diffs in some cases, such
as cc4b1e923091 in this repo (the parent of this commit). I think the
problem there is that many words are repeated over and over. Diffing
first at the line level and then refining the diff of the changed
ranges at the word level gives much better results. That's what this
patch does. After this patch, `jj diff -r cc4b1e923091` looks pretty
similar to the diff in GitHub's UI.
I hope to get around to doing the same for the merge code soon.
Impact on benchmarks:
Before:
test bench_diff_10k_lines_reversed ... bench: 42,647,532 ns/iter (+/- 765,347)
test bench_diff_10k_modified_lines ... bench: 21,407,980 ns/iter (+/- 126,366)
test bench_diff_10k_unchanged_lines ... bench: 4,235 ns/iter (+/- 16)
test bench_diff_1k_lines_reversed ... bench: 1,190,483 ns/iter (+/- 7,192)
test bench_diff_1k_modified_lines ... bench: 1,919,766 ns/iter (+/- 9,665)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 174,702 ns/iter (+/- 1,199)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,509 ns/iter (+/- 129,004)
test bench_diff_10k_modified_lines ... bench: 33,140,659 ns/iter (+/- 3,989,339)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 14)
test bench_diff_1k_lines_reversed ... bench: 973,551 ns/iter (+/- 94,895)
test bench_diff_1k_modified_lines ... bench: 3,033,818 ns/iter (+/- 29,513)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 79,100 ns/iter (+/- 963)
So most of them get slower, as expected. The last one, taken from a
real diff in the git.git repo, get faster, however (which is also what
I would have expected).
2021-04-03 22:37:55 +00:00
|
|
|
let unchanged_refined_ranges = unchanged_ranges(
|
2021-06-14 07:18:38 +00:00
|
|
|
left_slice,
|
|
|
|
right_slice,
|
diff: first diff lines, then refine to words, producing better diffs
The new diff algorithm produces pretty bad diffs in some cases, such
as cc4b1e923091 in this repo (the parent of this commit). I think the
problem there is that many words are repeated over and over. Diffing
first at the line level and then refining the diff of the changed
ranges at the word level gives much better results. That's what this
patch does. After this patch, `jj diff -r cc4b1e923091` looks pretty
similar to the diff in GitHub's UI.
I hope to get around to doing the same for the merge code soon.
Impact on benchmarks:
Before:
test bench_diff_10k_lines_reversed ... bench: 42,647,532 ns/iter (+/- 765,347)
test bench_diff_10k_modified_lines ... bench: 21,407,980 ns/iter (+/- 126,366)
test bench_diff_10k_unchanged_lines ... bench: 4,235 ns/iter (+/- 16)
test bench_diff_1k_lines_reversed ... bench: 1,190,483 ns/iter (+/- 7,192)
test bench_diff_1k_modified_lines ... bench: 1,919,766 ns/iter (+/- 9,665)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 174,702 ns/iter (+/- 1,199)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,509 ns/iter (+/- 129,004)
test bench_diff_10k_modified_lines ... bench: 33,140,659 ns/iter (+/- 3,989,339)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 14)
test bench_diff_1k_lines_reversed ... bench: 973,551 ns/iter (+/- 94,895)
test bench_diff_1k_modified_lines ... bench: 3,033,818 ns/iter (+/- 29,513)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 79,100 ns/iter (+/- 963)
So most of them get slower, as expected. The last one, taken from a
real diff in the git.git repo, get faster, however (which is also what
I would have expected).
2021-04-03 22:37:55 +00:00
|
|
|
&refined_left_ranges,
|
|
|
|
&refined_right_ranges,
|
|
|
|
);
|
|
|
|
let all_refined_ranges =
|
|
|
|
fill_in_range_gaps(left_slice, right_slice, &unchanged_refined_ranges);
|
|
|
|
let compacted_refined_range_diffs = compact_ranges(&all_refined_ranges);
|
|
|
|
for refined_range_diff in compacted_refined_range_diffs {
|
|
|
|
match refined_range_diff {
|
|
|
|
RangeDiff::Unchanged(refined_left_range, refined_right_range) => output
|
|
|
|
.push(RangeDiff::Unchanged(
|
|
|
|
left_range.start + refined_left_range.start
|
|
|
|
..left_range.start + refined_left_range.end,
|
|
|
|
right_range.start + refined_right_range.start
|
|
|
|
..right_range.start + refined_right_range.end,
|
|
|
|
)),
|
|
|
|
RangeDiff::Replaced(refined_left_range, refined_right_range) => output
|
|
|
|
.push(RangeDiff::Replaced(
|
|
|
|
left_range.start + refined_left_range.start
|
|
|
|
..left_range.start + refined_left_range.end,
|
|
|
|
right_range.start + refined_right_range.start
|
|
|
|
..right_range.start + refined_right_range.end,
|
|
|
|
)),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
range => {
|
|
|
|
output.push(range.clone());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
output
|
|
|
|
}
|
|
|
|
|
2021-03-20 21:44:00 +00:00
|
|
|
fn range_diffs_to_slice_diffs<'a>(
|
|
|
|
left: &'a [u8],
|
|
|
|
right: &'a [u8],
|
|
|
|
range_diffs: &[RangeDiff],
|
|
|
|
) -> Vec<SliceDiff<'a>> {
|
|
|
|
let mut slice_diffs = vec![];
|
|
|
|
for range in range_diffs {
|
|
|
|
match range {
|
|
|
|
RangeDiff::Unchanged(left_range, _right_range) => {
|
|
|
|
slice_diffs.push(SliceDiff::Unchanged(&left[left_range.clone()]));
|
|
|
|
}
|
|
|
|
RangeDiff::Replaced(left_range, right_range) => {
|
|
|
|
slice_diffs.push(SliceDiff::Replaced(
|
|
|
|
&left[left_range.clone()],
|
|
|
|
&right[right_range.clone()],
|
|
|
|
));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
slice_diffs
|
|
|
|
}
|
|
|
|
|
2021-06-19 20:04:08 +00:00
|
|
|
/// Wrapper around Range<usize> to provide Ord. We only order by the range's
|
|
|
|
/// start because we make sure to never have overlapping ranges.
|
|
|
|
#[derive(Clone, PartialEq, Eq, Debug)]
|
|
|
|
struct BaseRange(Range<usize>);
|
|
|
|
|
|
|
|
impl PartialOrd for BaseRange {
|
|
|
|
fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
|
|
|
|
self.0.start.partial_cmp(&other.0.start)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl Ord for BaseRange {
|
|
|
|
fn cmp(&self, other: &Self) -> Ordering {
|
|
|
|
self.0.start.cmp(&other.0.start)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Takes any number of inputs and finds regions that are them same between all
|
|
|
|
/// of them.
|
|
|
|
#[derive(Clone, Debug)]
|
|
|
|
pub struct Diff<'input> {
|
|
|
|
base_input: &'input [u8],
|
|
|
|
other_inputs: Vec<&'input [u8]>,
|
|
|
|
// The key is a range in the base input. The value is the start of each non-base region
|
|
|
|
// relative to the base region's start. By making them relative, they don't need to change
|
|
|
|
// when the base range changes.
|
|
|
|
unchanged_regions: BTreeMap<BaseRange, Vec<isize>>,
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Takes the current regions and intersects it with the new unchanged ranges
|
|
|
|
/// from a 2-way diff. The result is a map of unchanged regions with one more
|
|
|
|
/// offset in the map's values.
|
|
|
|
fn intersect_regions(
|
|
|
|
current_ranges: BTreeMap<BaseRange, Vec<isize>>,
|
|
|
|
new_unchanged_ranges: &[(Range<usize>, Range<usize>)],
|
|
|
|
) -> BTreeMap<BaseRange, Vec<isize>> {
|
|
|
|
let mut result = BTreeMap::new();
|
|
|
|
let mut current_ranges_iter = current_ranges.into_iter().peekable();
|
|
|
|
for (new_base_range, other_range) in new_unchanged_ranges.iter() {
|
|
|
|
assert_eq!(new_base_range.len(), other_range.len());
|
|
|
|
while let Some((BaseRange(base_range), offsets)) = current_ranges_iter.peek() {
|
|
|
|
// No need to look further if we're past the new range.
|
|
|
|
if base_range.start >= new_base_range.end {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
// Discard any current unchanged regions that don't match between the base and
|
|
|
|
// the new input.
|
|
|
|
if base_range.end <= new_base_range.start {
|
|
|
|
current_ranges_iter.next();
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
let new_start = max(base_range.start, new_base_range.start);
|
|
|
|
let new_end = min(base_range.end, new_base_range.end);
|
|
|
|
let mut new_offsets = offsets.clone();
|
|
|
|
new_offsets.push(other_range.start.wrapping_sub(new_base_range.start) as isize);
|
|
|
|
result.insert(BaseRange(new_start..new_end), new_offsets);
|
|
|
|
if base_range.end >= new_base_range.end {
|
|
|
|
// Break without consuming the item; there may be other new ranges that overlap
|
|
|
|
// with it.
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
current_ranges_iter.next();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
result
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<'input> Diff<'input> {
|
|
|
|
pub fn for_tokenizer(
|
|
|
|
inputs: &[&'input [u8]],
|
|
|
|
tokenizer: &impl Fn(&[u8]) -> Vec<Range<usize>>,
|
|
|
|
) -> Self {
|
|
|
|
assert!(!inputs.is_empty());
|
|
|
|
let base_input = inputs[0];
|
|
|
|
let other_inputs = inputs.iter().skip(1).copied().collect_vec();
|
|
|
|
// First tokenize each input
|
|
|
|
let base_token_ranges: Vec<Range<usize>> = tokenizer(base_input);
|
|
|
|
let other_token_ranges: Vec<Vec<Range<usize>>> = other_inputs
|
|
|
|
.iter()
|
|
|
|
.map(|other_slice| tokenizer(other_slice))
|
|
|
|
.collect_vec();
|
|
|
|
|
|
|
|
// Look for unchanged regions. Initially consider the whole range of the base
|
|
|
|
// input as unchanged (compared to itself). Then diff each other input
|
|
|
|
// against the base. Intersect the previously found ranges with the
|
|
|
|
// unchanged ranges in the diff.
|
|
|
|
let mut unchanged_regions = BTreeMap::new();
|
|
|
|
unchanged_regions.insert(BaseRange(0..base_input.len()), vec![]);
|
|
|
|
for (i, other_token_ranges) in other_token_ranges.iter().enumerate() {
|
|
|
|
let unchanged_diff_ranges = unchanged_ranges(
|
|
|
|
base_input,
|
|
|
|
other_inputs[i],
|
|
|
|
&base_token_ranges,
|
|
|
|
other_token_ranges,
|
|
|
|
);
|
|
|
|
unchanged_regions = intersect_regions(unchanged_regions, &unchanged_diff_ranges);
|
|
|
|
}
|
|
|
|
// Add an empty range at the end to make life easier for hunks().
|
|
|
|
let offsets = other_inputs
|
|
|
|
.iter()
|
|
|
|
.map(|input| input.len().wrapping_sub(base_input.len()) as isize)
|
|
|
|
.collect_vec();
|
|
|
|
unchanged_regions.insert(BaseRange(base_input.len()..base_input.len()), offsets);
|
|
|
|
|
|
|
|
Self {
|
|
|
|
base_input,
|
|
|
|
other_inputs,
|
|
|
|
unchanged_regions,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
pub fn unrefined(inputs: &[&'input [u8]]) -> Self {
|
|
|
|
Diff::for_tokenizer(inputs, &|_| vec![])
|
|
|
|
}
|
|
|
|
|
|
|
|
// TODO: At least when merging, it's wasteful to refine the diff if e.g. if 2
|
|
|
|
// out of 3 inputs match in the differing regions. Perhaps the refine()
|
|
|
|
// method should be on the hunk instead (probably returning a new Diff)?
|
|
|
|
// That would let each user decide which hunks to refine. However, it would
|
|
|
|
// probably mean that many callers repeat the same code. Perhaps it
|
|
|
|
// should be possible to refine a whole diff *or* individual hunks.
|
|
|
|
pub fn default_refinement(inputs: &[&'input [u8]]) -> Self {
|
|
|
|
let mut diff = Diff::for_tokenizer(inputs, &find_line_ranges);
|
|
|
|
diff.refine_changed_regions(&find_word_ranges);
|
|
|
|
diff.refine_changed_regions(&find_nonword_ranges);
|
|
|
|
diff
|
|
|
|
}
|
|
|
|
|
|
|
|
pub fn hunks<'diff>(&'diff self) -> DiffHunkIterator<'diff, 'input> {
|
|
|
|
let previous_offsets = vec![0; self.other_inputs.len()];
|
|
|
|
DiffHunkIterator {
|
|
|
|
diff: self,
|
|
|
|
previous_base_range: 0..0,
|
|
|
|
previous_offsets,
|
|
|
|
unchanged_emitted: true,
|
|
|
|
unchanged_iter: self.unchanged_regions.iter(),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/// Uses the given tokenizer to split the changed regions into smaller
|
|
|
|
/// regions. Then tries to finds unchanged regions among them.
|
|
|
|
pub fn refine_changed_regions(&mut self, tokenizer: &impl Fn(&[u8]) -> Vec<Range<usize>>) {
|
|
|
|
let mut previous_base_end = 0;
|
|
|
|
let mut previous_offsets = vec![0; self.other_inputs.len()];
|
|
|
|
let mut new_unchanged_ranges = BTreeMap::new();
|
|
|
|
for (BaseRange(base_range), offsets) in self.unchanged_regions.iter() {
|
|
|
|
// For the changed region between the previous region and the current one,
|
|
|
|
// create a new Diff instance. Then adjust the start positions and
|
|
|
|
// offsets to be valid in the context of the larger Diff instance
|
|
|
|
// (`self`).
|
|
|
|
let mut slices = vec![&self.base_input[previous_base_end..base_range.start]];
|
|
|
|
for (i, offset) in offsets.iter().enumerate() {
|
|
|
|
let changed_range = previous_base_end.wrapping_add(previous_offsets[i] as usize)
|
|
|
|
..base_range.start.wrapping_add(*offset as usize);
|
|
|
|
slices.push(&self.other_inputs[i][changed_range]);
|
|
|
|
}
|
|
|
|
|
|
|
|
let refined_diff = Diff::for_tokenizer(&slices, tokenizer);
|
|
|
|
|
|
|
|
for (BaseRange(base_range), offsets) in refined_diff.unchanged_regions {
|
|
|
|
let new_base_start = base_range.start + previous_base_end;
|
|
|
|
let new_base_end = base_range.end + previous_base_end;
|
|
|
|
let offsets = offsets
|
|
|
|
.into_iter()
|
|
|
|
.enumerate()
|
|
|
|
.map(|(i, offset)| offset + previous_offsets[i])
|
|
|
|
.collect_vec();
|
|
|
|
new_unchanged_ranges.insert(BaseRange(new_base_start..new_base_end), offsets);
|
|
|
|
}
|
|
|
|
previous_base_end = base_range.end;
|
|
|
|
previous_offsets = offsets.clone();
|
|
|
|
}
|
|
|
|
self.unchanged_regions.extend(new_unchanged_ranges);
|
|
|
|
self.compact_unchanged_regions();
|
|
|
|
}
|
|
|
|
|
|
|
|
fn compact_unchanged_regions(&mut self) {
|
|
|
|
let mut compacted = BTreeMap::new();
|
|
|
|
let mut previous: Option<(Range<usize>, Vec<isize>)> = None;
|
|
|
|
for (BaseRange(base_range), value) in self.unchanged_regions.iter() {
|
|
|
|
if let Some((prevous_base_range, previous_value)) = previous {
|
|
|
|
if prevous_base_range.end == base_range.start && previous_value == *value {
|
|
|
|
previous = Some((prevous_base_range.start..base_range.end, value.clone()));
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
compacted.insert(BaseRange(prevous_base_range), previous_value);
|
|
|
|
}
|
|
|
|
previous = Some((base_range.clone(), value.clone()));
|
|
|
|
}
|
|
|
|
if let Some((prevous_base_range, previous_value)) = previous {
|
|
|
|
compacted.insert(BaseRange(prevous_base_range), previous_value);
|
|
|
|
}
|
|
|
|
self.unchanged_regions = compacted;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(PartialEq, Eq, Clone)]
|
|
|
|
pub enum DiffHunk<'input> {
|
|
|
|
Matching(&'input [u8]),
|
|
|
|
Different(Vec<&'input [u8]>),
|
|
|
|
}
|
|
|
|
|
|
|
|
impl Debug for DiffHunk<'_> {
|
|
|
|
fn fmt(&self, f: &mut Formatter<'_>) -> Result<(), std::fmt::Error> {
|
|
|
|
match self {
|
|
|
|
DiffHunk::Matching(slice) => f
|
|
|
|
.debug_tuple("DiffHunk::Matching")
|
|
|
|
.field(&String::from_utf8_lossy(slice))
|
|
|
|
.finish(),
|
|
|
|
DiffHunk::Different(slices) => f
|
|
|
|
.debug_tuple("DiffHunk::Different")
|
|
|
|
.field(
|
|
|
|
&slices
|
|
|
|
.iter()
|
|
|
|
.map(|slice| String::from_utf8_lossy(slice))
|
|
|
|
.collect_vec(),
|
|
|
|
)
|
|
|
|
.finish(),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
pub struct DiffHunkIterator<'diff, 'input> {
|
|
|
|
diff: &'diff Diff<'input>,
|
|
|
|
previous_base_range: Range<usize>,
|
|
|
|
previous_offsets: Vec<isize>,
|
|
|
|
unchanged_emitted: bool,
|
|
|
|
unchanged_iter: btree_map::Iter<'diff, BaseRange, Vec<isize>>,
|
|
|
|
}
|
|
|
|
|
|
|
|
impl<'diff, 'input> Iterator for DiffHunkIterator<'diff, 'input> {
|
|
|
|
type Item = DiffHunk<'input>;
|
|
|
|
|
|
|
|
fn next(&mut self) -> Option<Self::Item> {
|
|
|
|
loop {
|
|
|
|
if !self.unchanged_emitted {
|
|
|
|
self.unchanged_emitted = true;
|
|
|
|
if !self.previous_base_range.is_empty() {
|
|
|
|
return Some(DiffHunk::Matching(
|
|
|
|
&self.diff.base_input[self.previous_base_range.clone()],
|
|
|
|
));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if let Some((BaseRange(base_range), offsets)) = self.unchanged_iter.next() {
|
|
|
|
let mut slices =
|
|
|
|
vec![&self.diff.base_input[self.previous_base_range.end..base_range.start]];
|
|
|
|
for (i, input) in self.diff.other_inputs.iter().enumerate() {
|
|
|
|
let start = self
|
|
|
|
.previous_base_range
|
|
|
|
.end
|
|
|
|
.wrapping_add(self.previous_offsets[i] as usize);
|
|
|
|
let end = base_range.start.wrapping_add(offsets[i] as usize);
|
|
|
|
slices.push(&input[start..end]);
|
|
|
|
}
|
|
|
|
self.previous_base_range = base_range.clone();
|
|
|
|
self.previous_offsets = offsets.clone();
|
|
|
|
self.unchanged_emitted = false;
|
|
|
|
if slices.iter().any(|slice| !slice.is_empty()) {
|
|
|
|
return Some(DiffHunk::Different(slices));
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
None
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-03-20 21:44:00 +00:00
|
|
|
/// Diffs two slices of bytes. The returned diff hunks may be any length (may
|
|
|
|
/// span many lines or may be only part of a line). This currently uses
|
|
|
|
/// Histogram diff (or maybe something similar; I'm not sure I understood the
|
diff: first diff lines, then refine to words, producing better diffs
The new diff algorithm produces pretty bad diffs in some cases, such
as cc4b1e923091 in this repo (the parent of this commit). I think the
problem there is that many words are repeated over and over. Diffing
first at the line level and then refining the diff of the changed
ranges at the word level gives much better results. That's what this
patch does. After this patch, `jj diff -r cc4b1e923091` looks pretty
similar to the diff in GitHub's UI.
I hope to get around to doing the same for the merge code soon.
Impact on benchmarks:
Before:
test bench_diff_10k_lines_reversed ... bench: 42,647,532 ns/iter (+/- 765,347)
test bench_diff_10k_modified_lines ... bench: 21,407,980 ns/iter (+/- 126,366)
test bench_diff_10k_unchanged_lines ... bench: 4,235 ns/iter (+/- 16)
test bench_diff_1k_lines_reversed ... bench: 1,190,483 ns/iter (+/- 7,192)
test bench_diff_1k_modified_lines ... bench: 1,919,766 ns/iter (+/- 9,665)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 174,702 ns/iter (+/- 1,199)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,509 ns/iter (+/- 129,004)
test bench_diff_10k_modified_lines ... bench: 33,140,659 ns/iter (+/- 3,989,339)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 14)
test bench_diff_1k_lines_reversed ... bench: 973,551 ns/iter (+/- 94,895)
test bench_diff_1k_modified_lines ... bench: 3,033,818 ns/iter (+/- 29,513)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 79,100 ns/iter (+/- 963)
So most of them get slower, as expected. The last one, taken from a
real diff in the git.git repo, get faster, however (which is also what
I would have expected).
2021-04-03 22:37:55 +00:00
|
|
|
/// algorithm correctly). It first diffs lines in the input and then refines
|
|
|
|
/// the changed ranges at the word level.
|
2021-03-20 21:44:00 +00:00
|
|
|
///
|
|
|
|
/// TODO: Diff at even lower level in the non-word ranges?
|
|
|
|
pub fn diff<'a>(left: &'a [u8], right: &'a [u8]) -> Vec<SliceDiff<'a>> {
|
|
|
|
if left == right {
|
|
|
|
return vec![SliceDiff::Unchanged(left)];
|
|
|
|
}
|
|
|
|
if left.is_empty() {
|
|
|
|
return vec![SliceDiff::Replaced(b"", right)];
|
|
|
|
}
|
|
|
|
if right.is_empty() {
|
|
|
|
return vec![SliceDiff::Replaced(left, b"")];
|
|
|
|
}
|
|
|
|
|
diff: first diff lines, then refine to words, producing better diffs
The new diff algorithm produces pretty bad diffs in some cases, such
as cc4b1e923091 in this repo (the parent of this commit). I think the
problem there is that many words are repeated over and over. Diffing
first at the line level and then refining the diff of the changed
ranges at the word level gives much better results. That's what this
patch does. After this patch, `jj diff -r cc4b1e923091` looks pretty
similar to the diff in GitHub's UI.
I hope to get around to doing the same for the merge code soon.
Impact on benchmarks:
Before:
test bench_diff_10k_lines_reversed ... bench: 42,647,532 ns/iter (+/- 765,347)
test bench_diff_10k_modified_lines ... bench: 21,407,980 ns/iter (+/- 126,366)
test bench_diff_10k_unchanged_lines ... bench: 4,235 ns/iter (+/- 16)
test bench_diff_1k_lines_reversed ... bench: 1,190,483 ns/iter (+/- 7,192)
test bench_diff_1k_modified_lines ... bench: 1,919,766 ns/iter (+/- 9,665)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 174,702 ns/iter (+/- 1,199)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,509 ns/iter (+/- 129,004)
test bench_diff_10k_modified_lines ... bench: 33,140,659 ns/iter (+/- 3,989,339)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 14)
test bench_diff_1k_lines_reversed ... bench: 973,551 ns/iter (+/- 94,895)
test bench_diff_1k_modified_lines ... bench: 3,033,818 ns/iter (+/- 29,513)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 79,100 ns/iter (+/- 963)
So most of them get slower, as expected. The last one, taken from a
real diff in the git.git repo, get faster, however (which is also what
I would have expected).
2021-04-03 22:37:55 +00:00
|
|
|
let range_diffs = vec![RangeDiff::Replaced(0..left.len(), 0..right.len())];
|
|
|
|
let range_diffs = refine_changed_ranges(left, right, &range_diffs, &find_line_ranges);
|
|
|
|
let range_diffs = refine_changed_ranges(left, right, &range_diffs, &find_word_ranges);
|
diff: do final refinement at byte-level for non-word bytes
This results in significantly more readable diffs on commits like
659393bec219 in this repo.
Before:
test bench_diff_10k_lines_reversed ... bench: 38,122,998 ns/iter (+/- 557,688)
test bench_diff_10k_modified_lines ... bench: 32,556,563 ns/iter (+/- 548,114)
test bench_diff_10k_unchanged_lines ... bench: 4,231 ns/iter (+/- 15)
test bench_diff_1k_lines_reversed ... bench: 958,296 ns/iter (+/- 46,963)
test bench_diff_1k_modified_lines ... bench: 3,014,723 ns/iter (+/- 15,830)
test bench_diff_1k_unchanged_lines ... bench: 249 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 78,599 ns/iter (+/- 1,079)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,493 ns/iter (+/- 413,712)
test bench_diff_10k_modified_lines ... bench: 37,352,516 ns/iter (+/- 1,293,950)
test bench_diff_10k_unchanged_lines ... bench: 4,238 ns/iter (+/- 13)
test bench_diff_1k_lines_reversed ... bench: 967,253 ns/iter (+/- 8,506)
test bench_diff_1k_modified_lines ... bench: 3,358,028 ns/iter (+/- 37,154)
test bench_diff_1k_unchanged_lines ... bench: 233 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 95,787 ns/iter (+/- 740)
So the biggest slowdown is when there are modified lines.
2021-04-07 17:07:37 +00:00
|
|
|
let range_diffs = refine_changed_ranges(left, right, &range_diffs, &find_nonword_ranges);
|
diff: first diff lines, then refine to words, producing better diffs
The new diff algorithm produces pretty bad diffs in some cases, such
as cc4b1e923091 in this repo (the parent of this commit). I think the
problem there is that many words are repeated over and over. Diffing
first at the line level and then refining the diff of the changed
ranges at the word level gives much better results. That's what this
patch does. After this patch, `jj diff -r cc4b1e923091` looks pretty
similar to the diff in GitHub's UI.
I hope to get around to doing the same for the merge code soon.
Impact on benchmarks:
Before:
test bench_diff_10k_lines_reversed ... bench: 42,647,532 ns/iter (+/- 765,347)
test bench_diff_10k_modified_lines ... bench: 21,407,980 ns/iter (+/- 126,366)
test bench_diff_10k_unchanged_lines ... bench: 4,235 ns/iter (+/- 16)
test bench_diff_1k_lines_reversed ... bench: 1,190,483 ns/iter (+/- 7,192)
test bench_diff_1k_modified_lines ... bench: 1,919,766 ns/iter (+/- 9,665)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 174,702 ns/iter (+/- 1,199)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,509 ns/iter (+/- 129,004)
test bench_diff_10k_modified_lines ... bench: 33,140,659 ns/iter (+/- 3,989,339)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 14)
test bench_diff_1k_lines_reversed ... bench: 973,551 ns/iter (+/- 94,895)
test bench_diff_1k_modified_lines ... bench: 3,033,818 ns/iter (+/- 29,513)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 79,100 ns/iter (+/- 963)
So most of them get slower, as expected. The last one, taken from a
real diff in the git.git repo, get faster, however (which is also what
I would have expected).
2021-04-03 22:37:55 +00:00
|
|
|
range_diffs_to_slice_diffs(left, right, &range_diffs)
|
2021-03-20 21:44:00 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
#[cfg(test)]
|
|
|
|
mod tests {
|
|
|
|
use super::*;
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_line_ranges_empty() {
|
|
|
|
assert_eq!(find_line_ranges(b""), vec![]);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_line_ranges_blank_line() {
|
|
|
|
assert_eq!(find_line_ranges(b"\n"), vec![0..1]);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_line_ranges_missing_newline_at_eof() {
|
|
|
|
assert_eq!(find_line_ranges(b"foo"), vec![0..3]);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_line_ranges_multiple_lines() {
|
|
|
|
assert_eq!(find_line_ranges(b"a\nbb\nccc\n"), vec![0..2, 2..5, 5..9]);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_word_ranges_empty() {
|
|
|
|
assert_eq!(find_word_ranges(b""), vec![]);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_word_ranges_single_word() {
|
|
|
|
assert_eq!(find_word_ranges(b"Abc"), vec![0..3]);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_word_ranges_no_word() {
|
|
|
|
assert_eq!(find_word_ranges(b"+-*/"), vec![]);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_word_ranges_word_then_non_word() {
|
|
|
|
assert_eq!(find_word_ranges(b"Abc "), vec![0..3]);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_word_ranges_non_word_then_word() {
|
|
|
|
assert_eq!(find_word_ranges(b" Abc"), vec![3..6]);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_lcs_empty() {
|
|
|
|
let empty: Vec<(usize, usize)> = vec![];
|
|
|
|
assert_eq!(find_lcs(&[]), empty);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_lcs_single_element() {
|
|
|
|
assert_eq!(find_lcs(&[0]), vec![(0, 0)]);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_lcs_in_order() {
|
|
|
|
assert_eq!(find_lcs(&[0, 1, 2]), vec![(0, 0), (1, 1), (2, 2)]);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_lcs_reverse_order() {
|
|
|
|
assert_eq!(find_lcs(&[2, 1, 0]), vec![(2, 0)]);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_lcs_two_swapped() {
|
|
|
|
assert_eq!(
|
|
|
|
find_lcs(&[0, 1, 4, 3, 2, 5, 6]),
|
|
|
|
vec![(0, 0), (1, 1), (2, 4), (5, 5), (6, 6)]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_lcs_element_moved_earlier() {
|
|
|
|
assert_eq!(
|
|
|
|
find_lcs(&[0, 1, 4, 2, 3, 5, 6]),
|
|
|
|
vec![(0, 0), (1, 1), (2, 3), (3, 4), (5, 5), (6, 6)]
|
|
|
|
);
|
|
|
|
}
|
2021-04-29 05:41:20 +00:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_lcs_element_moved_later() {
|
|
|
|
assert_eq!(
|
|
|
|
find_lcs(&[0, 1, 3, 4, 2, 5, 6]),
|
|
|
|
vec![(0, 0), (1, 1), (3, 2), (4, 3), (5, 5), (6, 6)]
|
|
|
|
);
|
|
|
|
}
|
2021-03-20 21:44:00 +00:00
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_lcs_interleaved_longest_chains() {
|
|
|
|
assert_eq!(
|
|
|
|
find_lcs(&[0, 4, 2, 9, 6, 5, 1, 3, 7, 8]),
|
|
|
|
vec![(0, 0), (1, 6), (3, 7), (7, 8), (8, 9)]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_find_word_ranges_many_words() {
|
|
|
|
assert_eq!(
|
|
|
|
find_word_ranges(b"fn find_words(text: &[u8])"),
|
|
|
|
vec![0..2, 3..13, 14..18, 22..24]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_fill_in_gaps_empty() {
|
|
|
|
assert_eq!(
|
|
|
|
fill_in_range_gaps(b"abc", b"abcde", &[]),
|
|
|
|
vec![RangeDiff::Replaced(0..3, 0..5),]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_fill_in_gaps_only_middle() {
|
|
|
|
assert_eq!(
|
|
|
|
fill_in_range_gaps(
|
|
|
|
b"a b c",
|
|
|
|
b"a x b y c",
|
|
|
|
&[(0..2, 0..2), (2..4, 4..6), (4..5, 8..9),]
|
|
|
|
),
|
|
|
|
vec![
|
|
|
|
RangeDiff::Unchanged(0..2, 0..2),
|
|
|
|
RangeDiff::Replaced(2..2, 2..4),
|
|
|
|
RangeDiff::Unchanged(2..4, 4..6),
|
|
|
|
RangeDiff::Replaced(4..4, 6..8),
|
|
|
|
RangeDiff::Unchanged(4..5, 8..9),
|
|
|
|
]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_fill_in_gaps_empty_gap() {
|
|
|
|
assert_eq!(
|
|
|
|
fill_in_range_gaps(b"a b", b"a b", &[(0..1, 0..1), (1..2, 1..2), (2..3, 2..3),]),
|
|
|
|
vec![
|
|
|
|
RangeDiff::Unchanged(0..1, 0..1),
|
|
|
|
RangeDiff::Unchanged(1..2, 1..2),
|
|
|
|
RangeDiff::Unchanged(2..3, 2..3),
|
|
|
|
]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_fill_in_gaps_before_and_after() {
|
|
|
|
assert_eq!(
|
|
|
|
fill_in_range_gaps(b" a ", b" a ", &[(1..2, 1..2),]),
|
|
|
|
vec![
|
|
|
|
RangeDiff::Unchanged(0..1, 0..1),
|
|
|
|
RangeDiff::Unchanged(1..2, 1..2),
|
|
|
|
RangeDiff::Unchanged(2..3, 2..3),
|
|
|
|
]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_compact_ranges_all_unchanged() {
|
|
|
|
assert_eq!(
|
|
|
|
compact_ranges(&[
|
|
|
|
RangeDiff::Unchanged(0..1, 0..2),
|
|
|
|
RangeDiff::Unchanged(1..2, 2..4),
|
|
|
|
RangeDiff::Unchanged(2..3, 4..6),
|
|
|
|
]),
|
|
|
|
vec![RangeDiff::Unchanged(0..3, 0..6),]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_compact_ranges_all_replaced() {
|
|
|
|
assert_eq!(
|
|
|
|
compact_ranges(&[
|
|
|
|
RangeDiff::Replaced(0..1, 0..2),
|
|
|
|
RangeDiff::Replaced(1..2, 2..4),
|
|
|
|
RangeDiff::Replaced(2..3, 4..6),
|
|
|
|
]),
|
|
|
|
vec![RangeDiff::Replaced(0..3, 0..6),]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_compact_ranges_mixed() {
|
|
|
|
assert_eq!(
|
|
|
|
compact_ranges(&[
|
|
|
|
RangeDiff::Replaced(0..1, 0..2),
|
|
|
|
RangeDiff::Replaced(1..2, 2..4),
|
|
|
|
RangeDiff::Unchanged(2..3, 4..6),
|
|
|
|
RangeDiff::Unchanged(3..4, 6..8),
|
|
|
|
RangeDiff::Replaced(4..5, 8..10),
|
|
|
|
RangeDiff::Replaced(5..6, 10..12),
|
|
|
|
]),
|
|
|
|
vec![
|
|
|
|
RangeDiff::Replaced(0..2, 0..4),
|
|
|
|
RangeDiff::Unchanged(2..4, 4..8),
|
|
|
|
RangeDiff::Replaced(4..6, 8..12),
|
|
|
|
]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_compact_ranges_mixed_empty_range() {
|
|
|
|
assert_eq!(
|
|
|
|
compact_ranges(&[
|
|
|
|
RangeDiff::Replaced(0..1, 0..2),
|
|
|
|
RangeDiff::Replaced(1..2, 2..4),
|
|
|
|
RangeDiff::Unchanged(2..2, 4..4),
|
|
|
|
RangeDiff::Replaced(3..4, 6..8),
|
|
|
|
RangeDiff::Replaced(4..5, 8..10),
|
|
|
|
]),
|
|
|
|
vec![RangeDiff::Replaced(0..5, 0..10)]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_unchanged_ranges_insert_in_middle() {
|
|
|
|
assert_eq!(
|
|
|
|
unchanged_ranges(
|
|
|
|
b"a b b c",
|
|
|
|
b"a b X b c",
|
|
|
|
&[0..1, 2..3, 4..5, 6..7],
|
|
|
|
&[0..1, 2..3, 4..5, 6..7, 8..9],
|
|
|
|
),
|
|
|
|
vec![(0..1, 0..1), (2..3, 2..3), (4..5, 6..7), (6..7, 8..9)]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_unchanged_ranges_non_unique_removed() {
|
|
|
|
assert_eq!(
|
|
|
|
unchanged_ranges(
|
|
|
|
b"a a a a",
|
|
|
|
b"a b a c",
|
|
|
|
&[0..1, 2..3, 4..5, 6..7],
|
|
|
|
&[0..1, 2..3, 4..5, 6..7],
|
|
|
|
),
|
|
|
|
vec![(0..1, 0..1), (2..3, 4..5)]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_unchanged_ranges_non_unique_added() {
|
|
|
|
assert_eq!(
|
|
|
|
unchanged_ranges(
|
|
|
|
b"a b a c",
|
|
|
|
b"a a a a",
|
|
|
|
&[0..1, 2..3, 4..5, 6..7],
|
|
|
|
&[0..1, 2..3, 4..5, 6..7],
|
|
|
|
),
|
|
|
|
vec![(0..1, 0..1), (4..5, 2..3)]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2021-06-19 20:04:08 +00:00
|
|
|
#[test]
|
|
|
|
fn test_intersect_regions_existing_empty() {
|
|
|
|
let actual = intersect_regions(btreemap! {}, &[(20..25, 55..60)]);
|
|
|
|
let expected = btreemap! {};
|
|
|
|
assert_eq!(actual, expected);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_intersect_regions_new_ranges_within_existing() {
|
|
|
|
let actual = intersect_regions(
|
|
|
|
btreemap! {
|
|
|
|
BaseRange(20..70) => vec![3],
|
|
|
|
},
|
|
|
|
&[(25..30, 35..40), (40..50, 40..50)],
|
|
|
|
);
|
|
|
|
let expected = btreemap! {
|
|
|
|
BaseRange(25..30) => vec![3, 10],
|
|
|
|
BaseRange(40..50) => vec![3, 0],
|
|
|
|
};
|
|
|
|
assert_eq!(actual, expected);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_intersect_regions_partial_overlap() {
|
|
|
|
let actual = intersect_regions(
|
|
|
|
btreemap! {
|
|
|
|
BaseRange(20..50) => vec![-3],
|
|
|
|
},
|
|
|
|
&[(15..25, 5..15), (45..60, 55..70)],
|
|
|
|
);
|
|
|
|
let expected = btreemap! {
|
|
|
|
BaseRange(20..25) => vec![-3, -10],
|
|
|
|
BaseRange(45..50) => vec![-3, 10],
|
|
|
|
};
|
|
|
|
assert_eq!(actual, expected);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_intersect_regions_new_range_overlaps_multiple_existing() {
|
|
|
|
let actual = intersect_regions(
|
|
|
|
btreemap! {
|
|
|
|
BaseRange(20..50) => vec![3, -8],
|
|
|
|
BaseRange(70..80) => vec![7, 1],
|
|
|
|
},
|
|
|
|
&[(10..100, 5..95)],
|
|
|
|
);
|
|
|
|
let expected = btreemap! {
|
|
|
|
BaseRange(20..50) => vec![3, -8, -5],
|
|
|
|
BaseRange(70..80) => vec![7, 1, -5],
|
|
|
|
};
|
|
|
|
assert_eq!(actual, expected);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_diff_single_input() {
|
|
|
|
let diff = Diff::default_refinement(&[b"abc"]);
|
|
|
|
assert_eq!(diff.hunks().collect_vec(), vec![DiffHunk::Matching(b"abc")]);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_diff_single_empty_input() {
|
|
|
|
let diff = Diff::default_refinement(&[b""]);
|
|
|
|
assert_eq!(diff.hunks().collect_vec(), vec![]);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_diff_two_inputs_one_different() {
|
|
|
|
let diff = Diff::default_refinement(&[b"a b c", b"a X c"]);
|
|
|
|
assert_eq!(
|
|
|
|
diff.hunks().collect_vec(),
|
|
|
|
vec![
|
|
|
|
DiffHunk::Matching(b"a "),
|
|
|
|
DiffHunk::Different(vec![b"b", b"X"]),
|
|
|
|
DiffHunk::Matching(b" c"),
|
|
|
|
]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_diff_multiple_inputs_one_different() {
|
|
|
|
let diff = Diff::default_refinement(&[b"a b c", b"a X c", b"a b c"]);
|
|
|
|
assert_eq!(
|
|
|
|
diff.hunks().collect_vec(),
|
|
|
|
vec![
|
|
|
|
DiffHunk::Matching(b"a "),
|
|
|
|
DiffHunk::Different(vec![b"b", b"X", b"b"]),
|
|
|
|
DiffHunk::Matching(b" c"),
|
|
|
|
]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_diff_multiple_inputs_all_different() {
|
|
|
|
let diff = Diff::default_refinement(&[b"a b c", b"a X c", b"a c X"]);
|
|
|
|
assert_eq!(
|
|
|
|
diff.hunks().collect_vec(),
|
|
|
|
vec![
|
|
|
|
DiffHunk::Matching(b"a "),
|
|
|
|
DiffHunk::Different(vec![b"b ", b"X ", b""]),
|
|
|
|
DiffHunk::Matching(b"c"),
|
|
|
|
DiffHunk::Different(vec![b"", b"", b" X"]),
|
|
|
|
]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2021-03-20 21:44:00 +00:00
|
|
|
#[test]
|
|
|
|
fn test_diff_nothing_in_common() {
|
|
|
|
assert_eq!(
|
|
|
|
diff(b"aaa", b"bb"),
|
|
|
|
vec![SliceDiff::Replaced(b"aaa", b"bb")]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_diff_insert_in_middle() {
|
|
|
|
assert_eq!(
|
|
|
|
diff(b"a z", b"a S z"),
|
|
|
|
vec![
|
2021-04-07 17:38:40 +00:00
|
|
|
// TODO: Should compact these two unchanged ranges
|
2021-03-20 21:44:00 +00:00
|
|
|
SliceDiff::Unchanged(b"a"),
|
2021-04-07 17:38:40 +00:00
|
|
|
SliceDiff::Unchanged(b" "),
|
|
|
|
SliceDiff::Replaced(b"", b"S "),
|
2021-03-20 21:44:00 +00:00
|
|
|
SliceDiff::Unchanged(b"z"),
|
|
|
|
]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_diff_no_unique_middle_flips() {
|
|
|
|
assert_eq!(
|
|
|
|
diff(b"a R R S S z", b"a S S R R z"),
|
|
|
|
vec![
|
|
|
|
SliceDiff::Unchanged(b"a"),
|
2021-04-07 17:38:40 +00:00
|
|
|
SliceDiff::Unchanged(b" "),
|
|
|
|
SliceDiff::Replaced(b"R R ", b""),
|
2021-03-20 21:44:00 +00:00
|
|
|
SliceDiff::Unchanged(b"S S"),
|
2021-04-07 17:38:40 +00:00
|
|
|
SliceDiff::Unchanged(b" "),
|
|
|
|
SliceDiff::Replaced(b"", b"R R "),
|
2021-03-20 21:44:00 +00:00
|
|
|
SliceDiff::Unchanged(b"z")
|
|
|
|
],
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_diff_recursion_needed() {
|
|
|
|
assert_eq!(
|
|
|
|
diff(
|
|
|
|
b"a q x q y q z q b q y q x q c",
|
|
|
|
b"a r r x q y z q b y q x r r c",
|
|
|
|
),
|
|
|
|
vec![
|
|
|
|
SliceDiff::Unchanged(b"a"),
|
2021-04-07 17:38:40 +00:00
|
|
|
SliceDiff::Unchanged(b" "),
|
|
|
|
SliceDiff::Replaced(b"q", b"r"),
|
|
|
|
SliceDiff::Unchanged(b" "),
|
|
|
|
SliceDiff::Replaced(b"", b"r "),
|
2021-03-20 21:44:00 +00:00
|
|
|
SliceDiff::Unchanged(b"x q y"),
|
2021-04-07 17:38:40 +00:00
|
|
|
SliceDiff::Unchanged(b" "),
|
|
|
|
SliceDiff::Replaced(b"q ", b""),
|
2021-03-20 21:44:00 +00:00
|
|
|
SliceDiff::Unchanged(b"z q b"),
|
2021-04-07 17:38:40 +00:00
|
|
|
SliceDiff::Unchanged(b" "),
|
|
|
|
SliceDiff::Replaced(b"q ", b""),
|
2021-03-20 21:44:00 +00:00
|
|
|
SliceDiff::Unchanged(b"y q x"),
|
2021-04-07 17:38:40 +00:00
|
|
|
SliceDiff::Unchanged(b" "),
|
|
|
|
SliceDiff::Replaced(b"q", b"r"),
|
|
|
|
SliceDiff::Unchanged(b" "),
|
|
|
|
SliceDiff::Replaced(b"", b"r "),
|
2021-03-20 21:44:00 +00:00
|
|
|
SliceDiff::Unchanged(b"c"),
|
|
|
|
]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
diff: also recurse into final region after after unchanged regions
See test case for details.
Before:
test bench_diff_10k_lines_reversed ... bench: 36,249,659 ns/iter (+/- 174,455)
test bench_diff_10k_modified_lines ... bench: 37,258,890 ns/iter (+/- 803,963)
test bench_diff_10k_unchanged_lines ... bench: 4,252 ns/iter (+/- 69)
test bench_diff_1k_lines_reversed ... bench: 982,834 ns/iter (+/- 6,467)
test bench_diff_1k_modified_lines ... bench: 3,343,469 ns/iter (+/- 23,243)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 95,559 ns/iter (+/- 816)
After:
test bench_diff_10k_lines_reversed ... bench: 36,186,715 ns/iter (+/- 196,903)
test bench_diff_10k_modified_lines ... bench: 37,511,000 ns/iter (+/- 1,370,476)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 8)
test bench_diff_1k_lines_reversed ... bench: 986,010 ns/iter (+/- 11,565)
test bench_diff_1k_modified_lines ... bench: 3,370,938 ns/iter (+/- 17,041)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 102,189 ns/iter (+/- 1,052)
So this patch makes diffing even slower (but still easily fast enough
for all cases I've run into in real life). There's probably a lot that
can be done to make things faster, but the first priority is that the
diffs are correct and easy to read.
2021-04-08 06:26:19 +00:00
|
|
|
fn test_diff_real_case_write_fmt() {
|
|
|
|
// This is from src/ui.rs in commit f44d246e3f88 in this repo. It highlights the
|
|
|
|
// need for recursion into the range at the end: after splitting at "Arguments"
|
2021-06-02 22:50:08 +00:00
|
|
|
// and "formatter", the region at the end has the unique words "write_fmt"
|
diff: also recurse into final region after after unchanged regions
See test case for details.
Before:
test bench_diff_10k_lines_reversed ... bench: 36,249,659 ns/iter (+/- 174,455)
test bench_diff_10k_modified_lines ... bench: 37,258,890 ns/iter (+/- 803,963)
test bench_diff_10k_unchanged_lines ... bench: 4,252 ns/iter (+/- 69)
test bench_diff_1k_lines_reversed ... bench: 982,834 ns/iter (+/- 6,467)
test bench_diff_1k_modified_lines ... bench: 3,343,469 ns/iter (+/- 23,243)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 95,559 ns/iter (+/- 816)
After:
test bench_diff_10k_lines_reversed ... bench: 36,186,715 ns/iter (+/- 196,903)
test bench_diff_10k_modified_lines ... bench: 37,511,000 ns/iter (+/- 1,370,476)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 8)
test bench_diff_1k_lines_reversed ... bench: 986,010 ns/iter (+/- 11,565)
test bench_diff_1k_modified_lines ... bench: 3,370,938 ns/iter (+/- 17,041)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 102,189 ns/iter (+/- 1,052)
So this patch makes diffing even slower (but still easily fast enough
for all cases I've run into in real life). There's probably a lot that
can be done to make things faster, but the first priority is that the
diffs are correct and easy to read.
2021-04-08 06:26:19 +00:00
|
|
|
// and "fmt", but we forgot to recurse into that region, so we ended up
|
|
|
|
// saying that "write_fmt(fmt).unwrap()" was replaced by b"write_fmt(fmt)".
|
|
|
|
assert_eq!(diff(
|
|
|
|
b" pub fn write_fmt(&mut self, fmt: fmt::Arguments<\'_>) {\n self.styler().write_fmt(fmt).unwrap()\n",
|
|
|
|
b" pub fn write_fmt(&mut self, fmt: fmt::Arguments<\'_>) -> io::Result<()> {\n self.styler().write_fmt(fmt)\n"
|
|
|
|
),
|
|
|
|
vec![
|
|
|
|
SliceDiff::Unchanged(b" pub fn write_fmt(&mut self, fmt: fmt::Arguments<\'_"),
|
|
|
|
SliceDiff::Unchanged(b">) "),
|
|
|
|
SliceDiff::Replaced(b"", b"-> io::Result<()> "),
|
|
|
|
SliceDiff::Unchanged(b"{\n "),
|
|
|
|
SliceDiff::Unchanged(b"self.styler().write_fmt(fmt"),
|
|
|
|
SliceDiff::Unchanged(b")"),
|
|
|
|
SliceDiff::Replaced(b".unwrap()", b""),
|
|
|
|
SliceDiff::Unchanged(b"\n")
|
|
|
|
]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn test_diff_real_case_gitgit_read_tree_c() {
|
diff: first diff lines, then refine to words, producing better diffs
The new diff algorithm produces pretty bad diffs in some cases, such
as cc4b1e923091 in this repo (the parent of this commit). I think the
problem there is that many words are repeated over and over. Diffing
first at the line level and then refining the diff of the changed
ranges at the word level gives much better results. That's what this
patch does. After this patch, `jj diff -r cc4b1e923091` looks pretty
similar to the diff in GitHub's UI.
I hope to get around to doing the same for the merge code soon.
Impact on benchmarks:
Before:
test bench_diff_10k_lines_reversed ... bench: 42,647,532 ns/iter (+/- 765,347)
test bench_diff_10k_modified_lines ... bench: 21,407,980 ns/iter (+/- 126,366)
test bench_diff_10k_unchanged_lines ... bench: 4,235 ns/iter (+/- 16)
test bench_diff_1k_lines_reversed ... bench: 1,190,483 ns/iter (+/- 7,192)
test bench_diff_1k_modified_lines ... bench: 1,919,766 ns/iter (+/- 9,665)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 174,702 ns/iter (+/- 1,199)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,509 ns/iter (+/- 129,004)
test bench_diff_10k_modified_lines ... bench: 33,140,659 ns/iter (+/- 3,989,339)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 14)
test bench_diff_1k_lines_reversed ... bench: 973,551 ns/iter (+/- 94,895)
test bench_diff_1k_modified_lines ... bench: 3,033,818 ns/iter (+/- 29,513)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 79,100 ns/iter (+/- 963)
So most of them get slower, as expected. The last one, taken from a
real diff in the git.git repo, get faster, however (which is also what
I would have expected).
2021-04-03 22:37:55 +00:00
|
|
|
// This is the diff from commit e497ea2a9b in the git.git repo
|
2021-03-20 21:44:00 +00:00
|
|
|
assert_eq!(
|
|
|
|
diff(
|
|
|
|
br##"/*
|
|
|
|
* GIT - The information manager from hell
|
|
|
|
*
|
|
|
|
* Copyright (C) Linus Torvalds, 2005
|
|
|
|
*/
|
|
|
|
#include "#cache.h"
|
|
|
|
|
|
|
|
static int unpack(unsigned char *sha1)
|
|
|
|
{
|
|
|
|
void *buffer;
|
|
|
|
unsigned long size;
|
|
|
|
char type[20];
|
|
|
|
|
|
|
|
buffer = read_sha1_file(sha1, type, &size);
|
|
|
|
if (!buffer)
|
|
|
|
usage("unable to read sha1 file");
|
|
|
|
if (strcmp(type, "tree"))
|
|
|
|
usage("expected a 'tree' node");
|
|
|
|
while (size) {
|
|
|
|
int len = strlen(buffer)+1;
|
|
|
|
unsigned char *sha1 = buffer + len;
|
|
|
|
char *path = strchr(buffer, ' ')+1;
|
|
|
|
unsigned int mode;
|
|
|
|
if (size < len + 20 || sscanf(buffer, "%o", &mode) != 1)
|
|
|
|
usage("corrupt 'tree' file");
|
|
|
|
buffer = sha1 + 20;
|
|
|
|
size -= len + 20;
|
|
|
|
printf("%o %s (%s)\n", mode, path, sha1_to_hex(sha1));
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
int main(int argc, char **argv)
|
|
|
|
{
|
|
|
|
int fd;
|
|
|
|
unsigned char sha1[20];
|
|
|
|
|
|
|
|
if (argc != 2)
|
|
|
|
usage("read-tree <key>");
|
|
|
|
if (get_sha1_hex(argv[1], sha1) < 0)
|
|
|
|
usage("read-tree <key>");
|
|
|
|
sha1_file_directory = getenv(DB_ENVIRONMENT);
|
|
|
|
if (!sha1_file_directory)
|
|
|
|
sha1_file_directory = DEFAULT_DB_ENVIRONMENT;
|
|
|
|
if (unpack(sha1) < 0)
|
|
|
|
usage("unpack failed");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
"##,
|
|
|
|
br##"/*
|
|
|
|
* GIT - The information manager from hell
|
|
|
|
*
|
|
|
|
* Copyright (C) Linus Torvalds, 2005
|
|
|
|
*/
|
|
|
|
#include "#cache.h"
|
|
|
|
|
|
|
|
static void create_directories(const char *path)
|
|
|
|
{
|
|
|
|
int len = strlen(path);
|
|
|
|
char *buf = malloc(len + 1);
|
|
|
|
const char *slash = path;
|
|
|
|
|
|
|
|
while ((slash = strchr(slash+1, '/')) != NULL) {
|
|
|
|
len = slash - path;
|
|
|
|
memcpy(buf, path, len);
|
|
|
|
buf[len] = 0;
|
|
|
|
mkdir(buf, 0700);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static int create_file(const char *path)
|
|
|
|
{
|
|
|
|
int fd = open(path, O_WRONLY | O_TRUNC | O_CREAT, 0600);
|
|
|
|
if (fd < 0) {
|
|
|
|
if (errno == ENOENT) {
|
|
|
|
create_directories(path);
|
|
|
|
fd = open(path, O_WRONLY | O_TRUNC | O_CREAT, 0600);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return fd;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int unpack(unsigned char *sha1)
|
|
|
|
{
|
|
|
|
void *buffer;
|
|
|
|
unsigned long size;
|
|
|
|
char type[20];
|
|
|
|
|
|
|
|
buffer = read_sha1_file(sha1, type, &size);
|
|
|
|
if (!buffer)
|
|
|
|
usage("unable to read sha1 file");
|
|
|
|
if (strcmp(type, "tree"))
|
|
|
|
usage("expected a 'tree' node");
|
|
|
|
while (size) {
|
|
|
|
int len = strlen(buffer)+1;
|
|
|
|
unsigned char *sha1 = buffer + len;
|
|
|
|
char *path = strchr(buffer, ' ')+1;
|
|
|
|
char *data;
|
|
|
|
unsigned long filesize;
|
|
|
|
unsigned int mode;
|
|
|
|
int fd;
|
|
|
|
|
|
|
|
if (size < len + 20 || sscanf(buffer, "%o", &mode) != 1)
|
|
|
|
usage("corrupt 'tree' file");
|
|
|
|
buffer = sha1 + 20;
|
|
|
|
size -= len + 20;
|
|
|
|
data = read_sha1_file(sha1, type, &filesize);
|
|
|
|
if (!data || strcmp(type, "blob"))
|
|
|
|
usage("tree file refers to bad file data");
|
|
|
|
fd = create_file(path);
|
|
|
|
if (fd < 0)
|
|
|
|
usage("unable to create file");
|
|
|
|
if (write(fd, data, filesize) != filesize)
|
|
|
|
usage("unable to write file");
|
|
|
|
fchmod(fd, mode);
|
|
|
|
close(fd);
|
|
|
|
free(data);
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
int main(int argc, char **argv)
|
|
|
|
{
|
|
|
|
int fd;
|
|
|
|
unsigned char sha1[20];
|
|
|
|
|
|
|
|
if (argc != 2)
|
|
|
|
usage("read-tree <key>");
|
|
|
|
if (get_sha1_hex(argv[1], sha1) < 0)
|
|
|
|
usage("read-tree <key>");
|
|
|
|
sha1_file_directory = getenv(DB_ENVIRONMENT);
|
|
|
|
if (!sha1_file_directory)
|
|
|
|
sha1_file_directory = DEFAULT_DB_ENVIRONMENT;
|
|
|
|
if (unpack(sha1) < 0)
|
|
|
|
usage("unpack failed");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
"##,
|
|
|
|
),
|
|
|
|
vec![
|
diff: first diff lines, then refine to words, producing better diffs
The new diff algorithm produces pretty bad diffs in some cases, such
as cc4b1e923091 in this repo (the parent of this commit). I think the
problem there is that many words are repeated over and over. Diffing
first at the line level and then refining the diff of the changed
ranges at the word level gives much better results. That's what this
patch does. After this patch, `jj diff -r cc4b1e923091` looks pretty
similar to the diff in GitHub's UI.
I hope to get around to doing the same for the merge code soon.
Impact on benchmarks:
Before:
test bench_diff_10k_lines_reversed ... bench: 42,647,532 ns/iter (+/- 765,347)
test bench_diff_10k_modified_lines ... bench: 21,407,980 ns/iter (+/- 126,366)
test bench_diff_10k_unchanged_lines ... bench: 4,235 ns/iter (+/- 16)
test bench_diff_1k_lines_reversed ... bench: 1,190,483 ns/iter (+/- 7,192)
test bench_diff_1k_modified_lines ... bench: 1,919,766 ns/iter (+/- 9,665)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 174,702 ns/iter (+/- 1,199)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,509 ns/iter (+/- 129,004)
test bench_diff_10k_modified_lines ... bench: 33,140,659 ns/iter (+/- 3,989,339)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 14)
test bench_diff_1k_lines_reversed ... bench: 973,551 ns/iter (+/- 94,895)
test bench_diff_1k_modified_lines ... bench: 3,033,818 ns/iter (+/- 29,513)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 79,100 ns/iter (+/- 963)
So most of them get slower, as expected. The last one, taken from a
real diff in the git.git repo, get faster, however (which is also what
I would have expected).
2021-04-03 22:37:55 +00:00
|
|
|
SliceDiff::Unchanged(b"/*\n * GIT - The information manager from hell\n *\n * Copyright (C) Linus Torvalds, 2005\n */\n#include \"#cache.h\"\n\n"),
|
|
|
|
SliceDiff::Replaced(b"", b"static void create_directories(const char *path)\n{\n\tint len = strlen(path);\n\tchar *buf = malloc(len + 1);\n\tconst char *slash = path;\n\n\twhile ((slash = strchr(slash+1, \'/\')) != NULL) {\n\t\tlen = slash - path;\n\t\tmemcpy(buf, path, len);\n\t\tbuf[len] = 0;\n\t\tmkdir(buf, 0700);\n\t}\n}\n\nstatic int create_file(const char *path)\n{\n\tint fd = open(path, O_WRONLY | O_TRUNC | O_CREAT, 0600);\n\tif (fd < 0) {\n\t\tif (errno == ENOENT) {\n\t\t\tcreate_directories(path);\n\t\t\tfd = open(path, O_WRONLY | O_TRUNC | O_CREAT, 0600);\n\t\t}\n\t}\n\treturn fd;\n}\n\n"),
|
|
|
|
SliceDiff::Unchanged(b"static int unpack(unsigned char *sha1)\n{\n\tvoid *buffer;\n\tunsigned long size;\n\tchar type[20];\n\n\tbuffer = read_sha1_file(sha1, type, &size);\n\tif (!buffer)\n\t\tusage(\"unable to read sha1 file\");\n\tif (strcmp(type, \"tree\"))\n\t\tusage(\"expected a \'tree\' node\");\n\twhile (size) {\n\t\tint len = strlen(buffer)+1;\n\t\tunsigned char *sha1 = buffer + len;\n\t\tchar *path = strchr(buffer, \' \')+1;\n"),
|
|
|
|
SliceDiff::Replaced(b"", b"\t\tchar *data;\n\t\tunsigned long filesize;\n"),
|
|
|
|
SliceDiff::Unchanged(b"\t\tunsigned int mode;\n"),
|
|
|
|
SliceDiff::Replaced(b"", b"\t\tint fd;\n\n"),
|
|
|
|
SliceDiff::Unchanged(b"\t\tif (size < len + 20 || sscanf(buffer, \"%o\", &mode) != 1)\n\t\t\tusage(\"corrupt \'tree\' file\");\n\t\tbuffer = sha1 + 20;\n\t\tsize -= len + 20;\n"),
|
2021-04-07 17:38:40 +00:00
|
|
|
SliceDiff::Unchanged(b"\t\t"),
|
diff: also recurse into final region after after unchanged regions
See test case for details.
Before:
test bench_diff_10k_lines_reversed ... bench: 36,249,659 ns/iter (+/- 174,455)
test bench_diff_10k_modified_lines ... bench: 37,258,890 ns/iter (+/- 803,963)
test bench_diff_10k_unchanged_lines ... bench: 4,252 ns/iter (+/- 69)
test bench_diff_1k_lines_reversed ... bench: 982,834 ns/iter (+/- 6,467)
test bench_diff_1k_modified_lines ... bench: 3,343,469 ns/iter (+/- 23,243)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 95,559 ns/iter (+/- 816)
After:
test bench_diff_10k_lines_reversed ... bench: 36,186,715 ns/iter (+/- 196,903)
test bench_diff_10k_modified_lines ... bench: 37,511,000 ns/iter (+/- 1,370,476)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 8)
test bench_diff_1k_lines_reversed ... bench: 986,010 ns/iter (+/- 11,565)
test bench_diff_1k_modified_lines ... bench: 3,370,938 ns/iter (+/- 17,041)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 2)
test bench_diff_git_git_read_tree_c ... bench: 102,189 ns/iter (+/- 1,052)
So this patch makes diffing even slower (but still easily fast enough
for all cases I've run into in real life). There's probably a lot that
can be done to make things faster, but the first priority is that the
diffs are correct and easy to read.
2021-04-08 06:26:19 +00:00
|
|
|
SliceDiff::Replaced(b"printf", b"data = read_sha1_file"),
|
|
|
|
SliceDiff::Unchanged(b"("),
|
|
|
|
SliceDiff::Replaced(b"\"%o %s (%s)\\n\", mode, path, sha1_to_hex(", b""),
|
diff: first diff lines, then refine to words, producing better diffs
The new diff algorithm produces pretty bad diffs in some cases, such
as cc4b1e923091 in this repo (the parent of this commit). I think the
problem there is that many words are repeated over and over. Diffing
first at the line level and then refining the diff of the changed
ranges at the word level gives much better results. That's what this
patch does. After this patch, `jj diff -r cc4b1e923091` looks pretty
similar to the diff in GitHub's UI.
I hope to get around to doing the same for the merge code soon.
Impact on benchmarks:
Before:
test bench_diff_10k_lines_reversed ... bench: 42,647,532 ns/iter (+/- 765,347)
test bench_diff_10k_modified_lines ... bench: 21,407,980 ns/iter (+/- 126,366)
test bench_diff_10k_unchanged_lines ... bench: 4,235 ns/iter (+/- 16)
test bench_diff_1k_lines_reversed ... bench: 1,190,483 ns/iter (+/- 7,192)
test bench_diff_1k_modified_lines ... bench: 1,919,766 ns/iter (+/- 9,665)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 174,702 ns/iter (+/- 1,199)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,509 ns/iter (+/- 129,004)
test bench_diff_10k_modified_lines ... bench: 33,140,659 ns/iter (+/- 3,989,339)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 14)
test bench_diff_1k_lines_reversed ... bench: 973,551 ns/iter (+/- 94,895)
test bench_diff_1k_modified_lines ... bench: 3,033,818 ns/iter (+/- 29,513)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 79,100 ns/iter (+/- 963)
So most of them get slower, as expected. The last one, taken from a
real diff in the git.git repo, get faster, however (which is also what
I would have expected).
2021-04-03 22:37:55 +00:00
|
|
|
SliceDiff::Unchanged(b"sha1"),
|
2021-04-07 17:38:40 +00:00
|
|
|
SliceDiff::Replaced(b"", b", type, &filesize"),
|
|
|
|
SliceDiff::Unchanged(b")"),
|
|
|
|
SliceDiff::Replaced(b")", b""),
|
|
|
|
SliceDiff::Unchanged(b";\n"),
|
diff: first diff lines, then refine to words, producing better diffs
The new diff algorithm produces pretty bad diffs in some cases, such
as cc4b1e923091 in this repo (the parent of this commit). I think the
problem there is that many words are repeated over and over. Diffing
first at the line level and then refining the diff of the changed
ranges at the word level gives much better results. That's what this
patch does. After this patch, `jj diff -r cc4b1e923091` looks pretty
similar to the diff in GitHub's UI.
I hope to get around to doing the same for the merge code soon.
Impact on benchmarks:
Before:
test bench_diff_10k_lines_reversed ... bench: 42,647,532 ns/iter (+/- 765,347)
test bench_diff_10k_modified_lines ... bench: 21,407,980 ns/iter (+/- 126,366)
test bench_diff_10k_unchanged_lines ... bench: 4,235 ns/iter (+/- 16)
test bench_diff_1k_lines_reversed ... bench: 1,190,483 ns/iter (+/- 7,192)
test bench_diff_1k_modified_lines ... bench: 1,919,766 ns/iter (+/- 9,665)
test bench_diff_1k_unchanged_lines ... bench: 231 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 174,702 ns/iter (+/- 1,199)
After:
test bench_diff_10k_lines_reversed ... bench: 38,289,509 ns/iter (+/- 129,004)
test bench_diff_10k_modified_lines ... bench: 33,140,659 ns/iter (+/- 3,989,339)
test bench_diff_10k_unchanged_lines ... bench: 3,099 ns/iter (+/- 14)
test bench_diff_1k_lines_reversed ... bench: 973,551 ns/iter (+/- 94,895)
test bench_diff_1k_modified_lines ... bench: 3,033,818 ns/iter (+/- 29,513)
test bench_diff_1k_unchanged_lines ... bench: 230 ns/iter (+/- 1)
test bench_diff_git_git_read_tree_c ... bench: 79,100 ns/iter (+/- 963)
So most of them get slower, as expected. The last one, taken from a
real diff in the git.git repo, get faster, however (which is also what
I would have expected).
2021-04-03 22:37:55 +00:00
|
|
|
SliceDiff::Replaced(b"", b"\t\tif (!data || strcmp(type, \"blob\"))\n\t\t\tusage(\"tree file refers to bad file data\");\n\t\tfd = create_file(path);\n\t\tif (fd < 0)\n\t\t\tusage(\"unable to create file\");\n\t\tif (write(fd, data, filesize) != filesize)\n\t\t\tusage(\"unable to write file\");\n\t\tfchmod(fd, mode);\n\t\tclose(fd);\n\t\tfree(data);\n"),
|
|
|
|
SliceDiff::Unchanged(b"\t}\n\treturn 0;\n}\n\nint main(int argc, char **argv)\n{\n\tint fd;\n\tunsigned char sha1[20];\n\n\tif (argc != 2)\n\t\tusage(\"read-tree <key>\");\n\tif (get_sha1_hex(argv[1], sha1) < 0)\n\t\tusage(\"read-tree <key>\");\n\tsha1_file_directory = getenv(DB_ENVIRONMENT);\n\tif (!sha1_file_directory)\n\t\tsha1_file_directory = DEFAULT_DB_ENVIRONMENT;\n\tif (unpack(sha1) < 0)\n\t\tusage(\"unpack failed\");\n\treturn 0;\n}\n")
|
2021-03-20 21:44:00 +00:00
|
|
|
]
|
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|