ok/jj
1
0
Fork 0
forked from mirrors/jj
Code Pull requests Activity

docs: explain that approving your coworker's PRs should be avoided

Browse source 
We want to avoid conflicts of interest (both real and
apparent). Better to document this before it happens.

By the way, Ilya and I both work for Google and we have approved lots
of each others' PRs, but we work in very different parts of the
company and I don't think any of the PRs have been specific to
Google's interests.
This commit is contained in:
Martin von Zweigbergk 2024-02-06 13:40:05 -08:00 committed by Martin von Zweigbergk
parent d66fcf2ca0
commit 1be8225046
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
docs/contributing.md
View file

@ -51,6 +51,12 @@ so you can address any remaining minor comments and then merge the PR yourself
when you're ready. If you realize that some comments require non-trivial
changes, please ask your reviewer to take another look.
To avoid conflicts of interest, please don't merge a PR that has only been
approved by someone from the same organization. Similarly, as a reviewer,
there is no need to approve your coworkers' PRs, since the author should await
an approval from someone else anyway. It is of course still appreciated if you
review and comment on their PRs. Also, if the PR seems completely unrelated to
your company's interests, do feel free to approve it.
### Community Guidelines