From 2ce02357e5dacb492c1735722c6273d9ed6231e8 Mon Sep 17 00:00:00 2001 From: Waleed Khan Date: Mon, 3 Jul 2023 18:34:46 +0300 Subject: [PATCH] perf: set filename according to `JJ_TRACE` --- src/cli_util.rs | 20 ++++++++++++-------- 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/src/cli_util.rs b/src/cli_util.rs index e4d096988..b0e98b3ae 100644 --- a/src/cli_util.rs +++ b/src/cli_util.rs @@ -391,14 +391,18 @@ impl TracingSubscription { let (filter, reload_log_filter) = tracing_subscriber::reload::Layer::new(filter); let (chrome_tracing_layer, chrome_tracing_flush_guard) = match std::env::var("JJ_TRACE") { - Ok(_) => { - let filename = format!( - "jj-trace-{}.json", - SystemTime::now() - .duration_since(SystemTime::UNIX_EPOCH) - .unwrap() - .as_secs(), - ); + Ok(filename) => { + let filename = if filename.is_empty() { + format!( + "jj-trace-{}.json", + SystemTime::now() + .duration_since(SystemTime::UNIX_EPOCH) + .unwrap() + .as_secs(), + ) + } else { + filename + }; let include_args = std::env::var("JJ_TRACE_INCLUDE_ARGS").is_ok(); let (layer, guard) = ChromeLayerBuilder::new() .file(filename)