ok/jj
1
0
Fork 0
forked from mirrors/jj
Code Pull requests Activity

matchers: simplify DifferenceMatcher slightly

Browse source 
The new `Visit::Nothing` variant lets us more easily restructure
`DifferenceMatcher::visit()` to make it handle the case of not
removing anything. I think this makes the code a little clearer.
This commit is contained in:
Martin von Zweigbergk 2022-05-21 22:59:43 -07:00 committed by Martin von Zweigbergk
parent 169261ca21
commit 4fda0f8b6a
1 changed files with 6 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
lib/src/matchers.rs
View file

@ -187,17 +187,12 @@ impl Matcher for DifferenceMatcher<'_> {
fn visit(&self, dir: &RepoPath) -> Visit {
match self.unwanted.visit(dir) {
Visit::AllRecursively => Visit::Nothing,
unwanted_visit => match self.wanted.visit(dir) {
Visit::AllRecursively => {
if unwanted_visit == Visit::Nothing {
Visit::AllRecursively
} else {
Visit::Specific {
dirs: VisitDirs::All,
files: VisitFiles::All,
}
}
}
Visit::Nothing => self.wanted.visit(dir),
Visit::Specific { .. } => match self.wanted.visit(dir) {
Visit::AllRecursively => Visit::Specific {
dirs: VisitDirs::All,
files: VisitFiles::All,
},
wanted_visit => wanted_visit,
},
}