cli: simplify relative_path() by leveraging ancestors() iterator

Just code cleanup. There should be no behavior change.

src/ui.rs

@@ -15,7 +15,7 @@
 use std::io::{Stderr, Stdout, Write};
 use std::path::{Component, Path, PathBuf};
 use std::str::FromStr;
-use std::{fmt, io};
+use std::{fmt, io, iter};
 
 use atty::Stream;
 use jujutsu_lib::repo_path::{RepoPath, RepoPathComponent, RepoPathJoin};
@@ -209,25 +209,26 @@ pub enum FilePathParseError {
     InputNotInRepo(String),
 }
 
-pub fn relative_path(mut from: &Path, to: &Path) -> PathBuf {
+/// Turns the given `to` path into relative path starting from the `from` path.
-    let mut result = PathBuf::from("");
+///
-    loop {
+/// Both `from` and `to` paths are supposed to be absolute and normalized in the
-        if let Ok(suffix) = to.strip_prefix(from) {
+/// same manner.
-            result = result.join(suffix);
+pub fn relative_path(from: &Path, to: &Path) -> PathBuf {
-            break;
+    // Find common prefix.
-        }
+    for (i, base) in from.ancestors().enumerate() {
-        if let Some(parent) = from.parent() {
+        if let Ok(suffix) = to.strip_prefix(base) {
-            result = result.join("..");
+            if i == 0 && suffix.as_os_str().is_empty() {
-            from = parent;
+                return ".".into();
             } else {
-            result = to.to_path_buf();
+                let mut result = PathBuf::from_iter(iter::repeat("..").take(i));
-            break;
+                result.push(suffix);
+                return result;
             }
         }
-    if result.as_os_str().is_empty() {
-        result = PathBuf::from(".");
     }
-    result
+
+    // No common prefix found. Return the original (absolute) path.
+    to.to_owned()
 }
 
 #[cfg(test)]