ok/jj
1
0
Fork 0
forked from mirrors/jj
Code Pull requests Activity

style: use explicit loop instead of .for_each() in simple cases

Browse source
This commit is contained in:
Samuel Tardieu 2024-10-02 23:38:33 +02:00
parent 43711de61c
commit 6368544f4f
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Cargo.toml
View file

@ -136,6 +136,7 @@ testutils = { path = "lib/testutils" }
explicit_iter_loop = "warn" explicit_iter_loop = "warn"
flat_map_option = "warn" flat_map_option = "warn"
implicit_clone = "warn" implicit_clone = "warn"
needless_for_each = "warn"
semicolon_if_nothing_returned = "warn" semicolon_if_nothing_returned = "warn"
uninlined_format_args = "warn" uninlined_format_args = "warn"

4
cli/src/movement_util.rs
View file

@ -101,7 +101,7 @@ impl Direction {
let template = workspace_command.commit_summary_template(); let template = workspace_command.commit_summary_template();
let mut cmd_err = user_error(err_msg); let mut cmd_err = user_error(err_msg);
commits.iter().for_each(|commit| { for commit in commits {
cmd_err.add_formatted_hint_with(|formatter| { cmd_err.add_formatted_hint_with(|formatter| {
if args.should_edit { if args.should_edit {
write!(formatter, "Working copy: ")?; write!(formatter, "Working copy: ")?;
@ -110,7 +110,7 @@ impl Direction {
} }
template.format(commit, formatter) template.format(commit, formatter)
}); });
}); }
cmd_err cmd_err
} }