From 8148daa22912b19a212f9ad40a5d592db4ab2787 Mon Sep 17 00:00:00 2001
From: Yuya Nishihara <yuya@tcha.org>
Date: Wed, 28 Feb 2024 20:32:26 +0900
Subject: [PATCH] merge_tools: extract function that doesn't look up :builtin
 merge tool

The :builtin tool only applies to merge or diff editor.
---
 cli/src/merge_tools/mod.rs | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/cli/src/merge_tools/mod.rs b/cli/src/merge_tools/mod.rs
index b45b787ae..98570c7e8 100644
--- a/cli/src/merge_tools/mod.rs
+++ b/cli/src/merge_tools/mod.rs
@@ -183,15 +183,24 @@ fn editor_args_from_settings(
     }
 }
 
-/// Loads merge tool options from `[merge-tools.<name>]`.
+/// Resolves builtin merge tool name or loads external tool options from
+/// `[merge-tools.<name>]`.
 pub fn get_tool_config(
     settings: &UserSettings,
     name: &str,
 ) -> Result<Option<MergeTool>, ConfigError> {
     if name == BUILTIN_EDITOR_NAME {
-        return Ok(Some(MergeTool::Builtin));
+        Ok(Some(MergeTool::Builtin))
+    } else {
+        Ok(get_external_tool_config(settings, name)?.map(MergeTool::External))
     }
+}
 
+/// Loads external diff/merge tool options from `[merge-tools.<name>]`.
+pub fn get_external_tool_config(
+    settings: &UserSettings,
+    name: &str,
+) -> Result<Option<ExternalMergeTool>, ConfigError> {
     const TABLE_KEY: &str = "merge-tools";
     let tools_table = settings.config().get_table(TABLE_KEY)?;
     if let Some(v) = tools_table.get(name) {
@@ -204,7 +213,7 @@ pub fn get_tool_config(
         if result.program.is_empty() {
             result.program.clone_from(&name.to_string());
         };
-        Ok(Some(MergeTool::External(result)))
+        Ok(Some(result))
     } else {
         Ok(None)
     }