ok/jj
1
0
Fork 0
forked from mirrors/jj
Code Pull requests Activity

tree: consolidate read error variants

Browse source 
There isn't much difference between BackendError::ReadObject of file type
and TreeMergeError::ReadError. They are both caused by the backend.
This commit is contained in:
Yuya Nishihara 2024-03-30 16:16:32 +09:00
parent bfa43d16f9
commit 916014dc1e
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
lib/src/tree.rs
View file

@ -24,7 +24,7 @@ use thiserror::Error;
use tracing::instrument;
use crate::backend::{
BackendError, ConflictId, FileId, TreeEntriesNonRecursiveIterator, TreeEntry, TreeId, TreeValue,
BackendError, ConflictId, TreeEntriesNonRecursiveIterator, TreeEntry, TreeId, TreeValue,
};
use crate::files::MergeResult;
use crate::matchers::{EverythingMatcher, Matcher};
@ -36,11 +36,6 @@ use crate::{backend, files};
#[derive(Debug, Error)]
pub enum TreeMergeError {
#[error("Failed to read file with ID {} ", .file_id.hex())]
ReadError {
source: std::io::Error,
file_id: FileId,
},
#[error(transparent)]
BackendError(#[from] BackendError),
}
@ -448,9 +443,10 @@ pub fn try_resolve_file_conflict(
store
.read_file(filename, file_id)?
.read_to_end(&mut content)
.map_err(|err| TreeMergeError::ReadError {
source: err,
file_id: file_id.clone(),
.map_err(|err| BackendError::ReadObject {
object_type: file_id.object_type(),
hash: file_id.hex(),
source: err.into(),
})?;
Ok(content)
})?;