diff --git a/lib/tests/test_working_copy.rs b/lib/tests/test_working_copy.rs index 260ac443a..1fbe9b210 100644 --- a/lib/tests/test_working_copy.rs +++ b/lib/tests/test_working_copy.rs @@ -804,22 +804,12 @@ fn test_existing_directory_symlink(use_git: bool) { // Creates a symlink in working directory, and a tree that will add a file under // the symlinked directory. std::os::unix::fs::symlink("..", workspace_root.join("parent")).unwrap(); - let mut tree_builder = repo - .store() - .tree_builder(repo.store().empty_tree_id().clone()); - testutils::write_normal_file( - &mut tree_builder, - &RepoPath::from_internal_string("parent/escaped"), - "contents", - ); - let tree_id = tree_builder.write_tree(); - let tree = repo.store().get_tree(&RepoPath::root(), &tree_id).unwrap(); + let file_path = RepoPath::from_internal_string("parent/escaped"); + let tree = create_tree(repo, &[(&file_path, "contents")]); // Checkout should fail because "parent" already exists and is a symlink. let wc = test_workspace.workspace.working_copy_mut(); - assert!(wc - .check_out(repo.op_id().clone(), None, &MergedTree::legacy(tree)) - .is_err()); + assert!(wc.check_out(repo.op_id().clone(), None, &tree).is_err()); // Therefore, "../escaped" shouldn't be created. assert!(!workspace_root.parent().unwrap().join("escaped").exists()); diff --git a/lib/testutils/src/lib.rs b/lib/testutils/src/lib.rs index 8106863da..9d09d3e1d 100644 --- a/lib/testutils/src/lib.rs +++ b/lib/testutils/src/lib.rs @@ -261,13 +261,9 @@ pub fn create_tree(repo: &Arc, path_contents: &[(&RepoPath, &str)] #[must_use] pub fn create_random_tree(repo: &Arc) -> MergedTreeId { - let mut tree_builder = repo - .store() - .tree_builder(repo.store().empty_tree_id().clone()); let number = rand::random::(); let path = RepoPath::from_internal_string(format!("file{number}").as_str()); - write_normal_file(&mut tree_builder, &path, "contents"); - MergedTreeId::Legacy(tree_builder.write_tree()) + create_tree(repo, &[(&path, "contents")]).id() } pub fn create_random_commit<'repo>(