ok/jj
1
0
Fork 0
forked from mirrors/jj
Code Pull requests Activity

Make CommitBuilder constructors private to the library crate

Browse source 
The implementation of `CommitBuilder::write` is tightly bound to the MutRepo,
so only MutRepo should construct CommitBuilder-s.
This commit is contained in:
Ilya Grigoriev 2023-12-17 17:44:32 -08:00
parent 6b862c6f23
commit cde8ea8985
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
lib/src/commit_builder.rs
View file

@ -32,7 +32,8 @@ pub struct CommitBuilder<'repo> {
}
impl CommitBuilder<'_> {
pub fn for_new_commit<'repo>(
// Use MutRepo::new_commit() instead
pub(crate) fn for_new_commit<'repo>(
mut_repo: &'repo mut MutableRepo,
settings: &UserSettings,
parents: Vec<CommitId>,
@ -61,7 +62,8 @@ impl CommitBuilder<'_> {
}
}
pub fn for_rewrite_from<'repo>(
// Use MutRepo::rewrite_commit() instead
pub(crate) fn for_rewrite_from<'repo>(
mut_repo: &'repo mut MutableRepo,
settings: &UserSettings,
predecessor: &Commit,

2
lib/src/repo.rs
View file

@ -796,6 +796,8 @@ impl MutableRepo {
predecessor: &Commit,
) -> CommitBuilder {
CommitBuilder::for_rewrite_from(self, settings, predecessor)
// CommitBuilder::write will record the rewrite in
// `self.rewritten_commits`
}
pub fn write_commit(