ok/jj
1
0
Fork 0
forked from mirrors/jj
Code Pull requests Activity

view: delete an incorrect comment about a race

Browse source 
Unlike in `Transaction::commit()`, in the `view` module, we actually
don't update the `.jj/view/op_heads/` directory until after we've
recorded the index associated with the operation, so there's no race
there.
This commit is contained in:
Martin von Zweigbergk 2021-03-10 14:19:19 -08:00
parent a715fd0ae7
commit fc73ef8d6e
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/src/view.rs
View file

@ -365,7 +365,6 @@ fn merge_op_heads(
metadata: operation_metadata, metadata: operation_metadata,
}; };
let merge_operation_id = op_store.write_operation(&merge_operation).unwrap(); let merge_operation_id = op_store.write_operation(&merge_operation).unwrap();
// TODO: Like in Transaction::commit(), there's a race here.
index_store index_store
.associate_file_with_operation(merged_index.as_ref(), &merge_operation_id) .associate_file_with_operation(merged_index.as_ref(), &merge_operation_id)
.unwrap(); .unwrap();