ok/jj
1
0
Fork 0
forked from mirrors/jj
jj/lib
Grégoire Geis 104f8e154c Fix Git/SSH on Windows
There were two issues on my end:
1. `known_hosts` doesn't seem to be recognized
2. SSH Agent is ignored despite running

A workaround for 1. is to set the HOME environment variable on Windows, so I added a hint to suggest this. Ideally we would add a `certificate_check` callback to the remote callbacks, but the git2 crate doesn't expose whether the certificate check already succeeded, which makes it useless for this purpose (as we'd be prompting users to accept a certificate even though that certificate is already known to be valid).

As for 2., I changed the behavior from "check SSH Agent if some env variables exist" to "check SSH Agent and only fail if some env variables exist". On Windows SSH Agent doesn't use these env variables (but trying to communicate with it will still work), so now Windows properly works with SSH Agent.
2023-05-04 23:57:06 +09:00
..
benches
gen-protos cargo: bump prost-build from 0.11.8 to 0.11.9 2023-04-14 16:11:09 +00:00
src Fix Git/SSH on Windows 2023-05-04 23:57:06 +09:00
tests revset: add substitution rule for nested descendants/children 2023-04-24 20:45:13 +09:00
testutils cargo: bump git2 from 0.17.0 to 0.17.1 2023-04-17 09:19:58 -07:00
build.rs
Cargo.toml cargo: downgrade tracing from yanked 0.1.38 to 0.1.37 2023-04-29 22:59:52 -07:00