mirrors/crosvm
1
0
Fork 0
mirror of https://chromium.googlesource.com/crosvm/crosvm synced 2025-02-11 12:35:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

crosvm: Use more semantically correct error type.

Browse source 
It's not UnknownArgument, it's an unexpected argument.

BUG=None
TEST=build

Change-Id: I990942c741d1e641697418a39ff55544d9fe4876
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/crosvm/+/3670094
Reviewed-by: Daniel Verkamp <dverkamp@chromium.org>
Tested-by: kokoro <noreply+kokoro@google.com>
Commit-Queue: Junichi Uekawa <uekawa@chromium.org>
This commit is contained in:
Junichi Uekawa 2022-05-26 09:51:19 +09:00 committed by Chromeos LUCI
parent 4080aaf9b3
commit 22b30eb15f
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/main.rs
View file

@ -2145,7 +2145,7 @@ fn validate_arguments(cfg: &mut Config) -> std::result::Result<(), argument::Err
if !cfg.userspace_msr.is_empty() {
for (_, msr_config) in cfg.userspace_msr.iter() {
if msr_config.from == MsrValueFrom::RWFromRunningCPU {
return Err(argument::Error::UnknownArgument(
return Err(argument::Error::ExpectedArgument(
"`userspace-msr` must set `cpu0` if `host-cpu-topology` is not set"
.to_owned(),
));
@ -2205,7 +2205,7 @@ fn validate_arguments(cfg: &mut Config) -> std::result::Result<(), argument::Err
}
}
set_itmt_msr_config(&mut cfg.userspace_msr).map_err(|e| {
argument::Error::UnknownArgument(format!("the cpu doesn't support itmt {}", e))
argument::Error::UnexpectedValue(format!("the cpu doesn't support itmt {}", e))
})?;
}
if !cfg.balloon && cfg.balloon_control.is_some() {