Markus Westerlind
ce6428fbbd
Lift the static restriction on the traits
2020-07-23 11:34:20 +02:00
Aleksey Kladov
380c4c1dc8
Release v0.15.0
...
The single (but big) change is Dynamic Database RFC implementation:
https://github.com/salsa-rs/salsa/pull/231
2020-07-07 15:45:39 +02:00
Niko Matsakis
9b9dbcca8c
Merge pull request #231 from nikomatsakis/dynamic-databases-rfc
...
[RFC] Dynamic databases
2020-07-07 06:13:03 -04:00
Niko Matsakis
4974d649ec
mention the plumbing
2020-07-07 10:07:47 +00:00
Niko Matsakis
f0c28c7e30
fix hello-world documentation
2020-07-07 10:05:02 +00:00
Niko Matsakis
b00981935a
fix doc tests
2020-07-07 09:59:57 +00:00
Niko Matsakis
da7c8b30db
fix mdbook tests
2020-07-07 09:55:04 +00:00
Niko Matsakis
fd036a4f15
do not generate in_db_mut
when it is inappropriate
2020-07-06 21:48:14 +00:00
Niko Matsakis
d2e9f64bda
add shims for input queries
2020-07-06 21:48:07 +00:00
Niko Matsakis
9596c25b77
move the shims into private, hidden functions
2020-07-06 21:06:36 +00:00
Aleksey Kladov
a5626cd8a0
Force codegen in the query-defning crate
2020-07-06 21:04:07 +00:00
Aleksey Kladov
0442f628cd
release v0.14.4
...
Significantly amount of memory used to store dependency information
2020-07-06 11:31:42 +02:00
Niko Matsakis
b66eb81311
experiment: extract some Memo code to be independent from Q
...
This should enable more sharing and less monomorphization. There is
probably room for more radical restructing in this vein.
2020-07-06 00:55:01 +00:00
Niko Matsakis
f7071dd137
RFC: remove RFC text about DependencySlot
...
It's simpler to just store a DatabaseKeyIndex. It may be somewhat
slower, we'll have to measure. But we can add back in this other
design later if we want.
2020-07-05 20:13:29 +00:00
Niko Matsakis
8ca3ab56b5
update the mdbook documentation, introducing a diagram
2020-07-05 16:45:07 +00:00
Niko Matsakis
0a8c2038b5
RFC: remove link, linkcheck doesn't like it
2020-07-05 10:52:49 +00:00
Niko Matsakis
b1e3003c1e
RFC: describe new bounds
2020-07-05 10:52:47 +00:00
Niko Matsakis
0b82d24514
RFC: describe 'static requirement
2020-07-05 10:52:43 +00:00
Niko Matsakis
b59dcc9145
RFC: describe in_db
functions
2020-07-05 10:34:15 +00:00
Niko Matsakis
fad97eeb6a
remove the DB
parameter
...
This had two unexpected consequences, one unfortunate, one "medium":
* All `salsa::Database` must be `'static`. This falls out from
`Q::DynDb` not having access to any lifetimes, but also the defaulting
rules for `dyn QueryGroup` that make it `dyn QueryGroup + 'static`. We
don't really support generic databases anyway yet so this isn't a big
deal, and we can add workarounds later (ideally via GATs).
* It is now statically impossible to invoke `snapshot` from a query,
and so we don't need to test that it panics. This is because the
signature of `snapshot` returns a `Snapshot<Self>` and that is not
accessible to a `dyn QueryGroup` type. Similarly, invoking
`Runtime::snapshot` directly is not possible becaues it is
crate-private. So I removed the test. This seems ok, but eventually I
would like to expose ways for queries to do parallel
execution (matklad and I had talked about a "speculation" primitive
for enabling that).
* This commit is 99% boilerplate I did with search-and-replace. I also
rolled in a few other changes I might have preferred to factor out,
most notably removing the `GetQueryTable` plumbing trait in favor of
free-methods, but it was awkward to factor them out and get all the
generics right (so much simpler in this version).
2020-07-04 14:17:11 +00:00
Niko Matsakis
d64dfa1727
make for_each_query
dyn-safe
2020-07-04 14:17:11 +00:00
Niko Matsakis
0e5366df5d
move to QueryType.in_db(&db)
instead of db.query(QueryType)
...
This will be more compatible once we move to having queries have an
associated `DynDb` type. It also reads nicely.
2020-07-04 14:17:11 +00:00
Niko Matsakis
7a5b515279
make DatabaseStorageTypes have supertrait of Database
2020-07-04 14:17:11 +00:00
Niko Matsakis
12f54d66f4
move query/query-mut to DatabaseQueryExt
2020-07-04 14:17:11 +00:00
Niko Matsakis
28b642e8c0
make DB
?Sized
on execute_query_implementation
helper
2020-07-04 14:17:11 +00:00
Niko Matsakis
d1fe9950c5
simplify salsa_event
and make it dyn-safe
2020-07-04 14:17:11 +00:00
Niko Matsakis
67687376ed
implement the Storage<DB> change
2020-07-04 14:17:10 +00:00
Niko Matsakis
4bf46f5f24
RFC: describe new approach to runtime
2020-07-04 14:16:50 +00:00
Niko Matsakis
c6663f3dcb
return durability of modified data and remove SharedStateWriteGuard
...
Now the `with_incremented_revision` method signature does not
reference the database DB in any way.
2020-07-04 14:16:50 +00:00
Niko Matsakis
705a35d4b7
pass 'new revision' as an explicit argument
...
The goal is to eliminate the "shared state guard" argument, which
currently requires access to the database.
2020-07-04 14:16:50 +00:00
Niko Matsakis
d71a7a2751
make with_incremented_revision
dyn-safe
2020-07-04 14:16:50 +00:00
Niko Matsakis
b3ffaec3b0
remove salsa::requires
feature
2020-07-04 14:16:50 +00:00
Niko Matsakis
6e813441cb
RFC: update to mention that salsa::requires is removed
2020-07-04 14:16:50 +00:00
Niko Matsakis
cc7bc54409
RFC: adjust because DatabaseKeyIndex are not part of public API
2020-07-04 14:16:50 +00:00
Niko Matsakis
64f3eb96a1
remove GroupKey associated type
2020-07-04 14:16:50 +00:00
Niko Matsakis
1a07944efe
remove DatabaseKey associated type
2020-07-04 14:16:50 +00:00
Niko Matsakis
799ddce157
remove unused GroupData
associated type
2020-07-04 14:16:50 +00:00
Niko Matsakis
1b778760ae
track and report cycles using DatabaseKeyIndex
2020-07-04 14:16:50 +00:00
Niko Matsakis
7b5ac6e717
implement ability to get readable debug output for DatabaseKeyIndex
2020-07-04 14:16:50 +00:00
Niko Matsakis
5a1bf10ba6
add a query_name
associated constant
2020-07-04 14:16:50 +00:00
Niko Matsakis
b4c6e69faf
rewrite get_cycle_path
to push to a vector
2020-07-04 14:16:50 +00:00
Niko Matsakis
07623fb962
remove the DatabaseData
and associated unsafe code
2020-07-04 14:16:50 +00:00
Niko Matsakis
f7a14f2309
use DatabaseKeyIndex
instead of Dependency
2020-07-04 14:16:49 +00:00
Niko Matsakis
29b6b833d1
compute database-key-index for interned fields
2020-07-04 14:16:14 +00:00
Niko Matsakis
a45087a322
compute database-key-index for input slots
2020-07-04 14:16:14 +00:00
Niko Matsakis
ed1632d151
compute database-key-index for derived slots
2020-07-04 14:16:14 +00:00
Niko Matsakis
8664e7e43c
add database-key-index type
2020-07-04 14:16:14 +00:00
Niko Matsakis
206c086bac
thread group index to storage initializers
2020-07-04 14:16:14 +00:00
Niko Matsakis
9bd9f8b202
use new
with index to create group storage
2020-07-04 14:16:14 +00:00
Niko Matsakis
0da53151c5
RFC: update to use index triples
2020-07-04 14:16:14 +00:00