2745 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Antonio Scandurra	dca974c7d4	Apply code actions remotely	2022-02-08 12:18:14 +01:00
Antonio Scandurra	aedf31e2d8	Manually refresh code action when data is not present	2022-02-08 10:47:50 +01:00
Antonio Scandurra	9ce3b1adf2	Send DidCloseTextDocument when dropping buffer ... Closes https://github.com/zed-industries/zed/issues/434	2022-02-08 10:02:26 +01:00
Antonio Scandurra	17114cc6f7	Merge branch 'main' into assists	2022-02-08 09:39:43 +01:00
Max Brunsfeld	30e870993d	Merge pull request #437 from zed-industries/fix-server-hangs ... Use an unbounded channel for peer's outgoing messages	2022-02-07 16:33:36 -08:00
Max Brunsfeld	8a2613d49c	Preserve ordering between responses and other incoming messages ... Co-Authored-By: Nathan Sobo <nathan@zed.dev>	2022-02-07 14:14:15 -08:00
Max Brunsfeld	d4fe1115e7	Use an unbounded channel for peer's outgoing messages ... Using a bounded channel may have blocked the collaboration server from making progress handling RPC traffic. There's no need to apply backpressure to calling code within the same process - suspending a task that is attempting to call `send` has an even greater memory cost than just buffering a protobuf message. We do still want a bounded channel for incoming messages, so that we provide backpressure to noisy peers - blocking their writes as opposed to allowing them to buffer arbitrarily many messages in our server. Co-Authored-By: Antonio Scandurra <me@as-cii.com> Co-Authored-By: Nathan Sobo <nathan@zed.dev>	2022-02-07 12:27:13 -08:00
Antonio Scandurra	8f3ff1590e	Apply edits received from LSP code actions and open all touched buffers	2022-02-07 18:48:45 +01:00
Antonio Scandurra	7a35ea7b25	Tolerate language servers reporting non-monotonic buffer versions ... This isn't perfect but we'll retain up to 10 old versions just in case there are race conditions in the language server. We haven't seen this in the wild but we're concerned about diagnostic reporting racing with code action resolution. Co-Authored-By: Nathan Sobo <nathan@zed.dev>	2022-02-07 16:29:05 +01:00
Antonio Scandurra	a172c3c5c6	Apply file-system operations coming from an LSP code action ... Co-Authored-By: Nathan Sobo <nathan@zed.dev>	2022-02-07 16:11:40 +01:00
Antonio Scandurra	982e90539d	WIP: Start on applying code actions	2022-02-07 12:20:03 +01:00
Nathan Sobo	dc20be256e	Start on code action confirmation	2022-02-05 12:37:34 -07:00
Nathan Sobo	ba99b01de6	Generalize showing and hiding of context menus ... We still cancel pending completions when hiding the context menu so its not perfectly general, but I think this is ok.	2022-02-05 12:13:02 -07:00
Nathan Sobo	025e83c1ec	Render code actions context menu	2022-02-05 11:04:05 -07:00
Nathan Sobo	93a3f4b615	Move rendering and select prev/next into ContextMenu enum ... This prepares the way to have a code actions context menu.	2022-02-05 10:19:43 -07:00
Nathan Sobo	ee661516fa	Start generalizing the completions menu into a context menu ... This will let us render the code actions menu in a way that's mutually exclusive with completions.	2022-02-05 09:43:25 -07:00
Max Brunsfeld	83d4fe8e3a	Start work on code actions ... Just print out the returned code actions for now Co-Authored-By: Nathan Sobo <nathan@zed.dev>	2022-02-04 17:45:00 -08:00
Max Brunsfeld	4900019e9b	Add a ToPointUtf16 trait in text and multibuffer ... Co-Authored-By: Nathan Sobo <nathan@zed.dev>	2022-02-04 17:35:37 -08:00
Max Brunsfeld	16acbd2123	Handle appkit's cancelOperation: message to allow binding cmd-.	2022-02-04 17:33:09 -08:00
Max Brunsfeld	82afacd33d	Merge pull request #425 from zed-industries/refine-select-larger-node ... Refine behavior of select_larger_syntax_node	2022-02-04 13:42:50 -08:00
Max Brunsfeld	7fc951853d	Adjust assertion to reflect rust grammar upgrade ... Co-Authored-By: Nathan Sobo <nathan@zed.dev>	2022-02-04 13:31:41 -08:00
Max Brunsfeld	3e232f7115	Refine behavior of select_larger_syntax_node ... Co-Authored-By: Antonio Scandurra <antonio@zed.dev>	2022-02-04 13:19:00 -08:00
Antonio Scandurra	fe1729ff70	Merge pull request #424 from zed-industries/fix-goal-column-on-cut ... Clear selection goal column when cutting a full line	2022-02-04 19:01:23 +01:00
Nathan Sobo	01f702ae5e	Merge pull request #423 from zed-industries/line-selection ... Refine line-oriented selection and deletion	2022-02-04 10:24:53 -07:00
Nathan Sobo	3f897ed588	Clear selection goal column when cutting a full line ... Co-Authored-By: Antonio Scandurra <me@as-cii.com> Co-Authored-By: Max Brunsfeld <maxbrunsfeld@gmail.com>	2022-02-04 10:19:26 -07:00
Nathan Sobo	3ef3f3098c	Merge pull request #401 from zed-industries/fail-ci-on-warnings ... Cause tests to fail on CI when there are warnings	2022-02-04 10:14:05 -07:00
Nathan Sobo	a9d2abebdb	Merge pull request #400 from zed-industries/libc++ ... Use -stdlib=libc++ in script/bundle to avoid errors on Monterey	2022-02-04 10:13:48 -07:00
Nathan Sobo	c38fe473cd	Delete to hard line boundary when deleting to start/end of line ... Co-Authored-By: Antonio Scandurra <me@as-cii.com>	2022-02-04 10:10:30 -07:00
Nathan Sobo	90a780a604	Improve moving to start or end of soft-wrapped lines ... When moving to end, stop at the soft-wrap line boundary first, then move to the end of the hard line. Vice versa when moving to the beginning. Co-Authored-By: Antonio Scandurra <me@as-cii.com>	2022-02-04 09:52:50 -07:00
Nathan Sobo	4eb2b978e8	Fix warning when not building in test mode ... Co-Authored-By: Antonio Scandurra <me@as-cii.com>	2022-02-04 09:23:16 -07:00
Nathan Sobo	aa12eb6b55	Span across soft-wraps when triple clicking a line ... Co-Authored-By: Antonio Scandurra <me@as-cii.com>	2022-02-04 09:21:13 -07:00
Nathan Sobo	6ac3a44e88	Cause tests to fail on CI when there are warnings ... Co-Authored-By: Antonio Scandurra <me@as-cii.com>	2022-02-04 08:57:39 -07:00
Antonio Scandurra	ed37ad37fb	Merge pull request #399 from zed-industries/unbounded-fs-events ... Buffer all incoming file-system events	2022-02-04 16:48:07 +01:00
Nathan Sobo	dad3ddb6f1	Use -stdlib=libc++ in script/bundle to avoid errors on Monterey ... I was unable to run script/bundle my local machine without this change.	2022-02-04 08:48:00 -07:00
Antonio Scandurra	a2aa844ddd	Buffer all incoming file-system events ... This avoids a problem where the operating system would drop events on the floor and tell us to rescan the entire directory, which in turn would cause a flicker in the project browser. Co-Authored-By: Nathan Sobo <nathan@zed.dev>	2022-02-04 16:31:34 +01:00
Antonio Scandurra	1e186d7235	Merge pull request #398 from zed-industries/refine-find ... Refine find	2022-02-04 16:31:06 +01:00
Antonio Scandurra	807049af51	Always populate find bar on cmd-f ... Co-Authored-By: Nathan Sobo <nathan@zed.dev>	2022-02-04 16:13:58 +01:00
Antonio Scandurra	bf043fe3fb	Merge pull request #396 from zed-industries/fix-autocomplete-bugs ... Refine autocomplete	2022-02-04 16:13:16 +01:00
Antonio Scandurra	7a8765a016	Dismiss the focused find bar on escape ... Co-Authored-By: Nathan Sobo <nathan@zed.dev>	2022-02-04 16:11:48 +01:00
Antonio Scandurra	55f0933872	Show completions as soon as possible ... Co-Authored-By: Nathan Sobo <nathan@zed.dev>	2022-02-04 16:01:04 +01:00
Antonio Scandurra	625beaaa9b	Finish writing test for the new autocompletion behavior ... Co-Authored-By: Nathan Sobo <nathan@zed.dev>	2022-02-04 15:47:19 +01:00
Nathan Sobo	f8dce23440	Merge pull request #394 from zed-industries/fix-selections-after-format ... Fix selection positions after typing with old selection anchors	2022-02-04 06:02:18 -07:00
Antonio Scandurra	0f266cff54	WIP: Start refactoring completion test ... The idea is to write more assertions related to how autocompletion behaves with multiple cursors, prefixes that don't match, etc.	2022-02-04 12:24:04 +01:00
Antonio Scandurra	99d0100c45	Remove unused bytes_at method	2022-02-04 12:07:30 +01:00
Antonio Scandurra	32859a38ed	Refine autocompletion when text matches a prefix of the suggestion	2022-02-04 12:05:57 +01:00
Antonio Scandurra	ad13bcdbda	Merge pull request #395 from zed-industries/fix-show-next-diagnostic ... Move cursor to diagnostic even if the only diagnostic is currently shown	2022-02-04 11:46:14 +01:00
Antonio Scandurra	8d17287167	Move cursor to diagnostic even if the only diagnostic is currently shown	2022-02-04 09:34:32 +01:00
Max Brunsfeld	d23115f628	Fix selection positions after typing with old selection anchors	2022-02-03 18:14:00 -08:00
Max Brunsfeld	40f9d2fc5d	Merge pull request #393 from zed-industries/autocomplete ... Autocomplete	2022-02-03 15:47:57 -08:00
Max Brunsfeld	3dfff3866a	Add integration test for getting and resolving completions	2022-02-03 15:24:16 -08:00