mirror of
https://github.com/zed-industries/zed.git
synced 2025-02-08 19:43:11 +00:00
6f40da77b6
When the `List` element's state is `ListState::reset()`, it eagerly trashes it's cached element heights in anticipation of a prompt render. But, due to the recent `display_layer` changes, that re-render is not always forthcoming. This is a problem for `ListState::scroll()`, which depends on these cached elements to correctly calculate the new logical scroll offset. Solutions we attempted: - Cache the element heights and continue the scroll calculation - This was conceptually incorrect, reset should only be called when the underlying data has been changed, making any calculation with the old results meaningless. - Lazily re-compute the element heights in scroll - Beyond being a non-trivial refactor, this would probably also cause us to double-render the list in a single frame, which is bad. - Cache the scroll offset and only calculate it in paint - This solution felt awkward to implement and meant we can't supply synchronous list scroll events. - Delay resetting until paint - This means that all of the other APIs that `ListState` supplies would give temporarily incorrect results, worsening the problem Given these issues, we settled on the solution with the least compromises: drop scroll events if the state has been `reset()` between `paint()` and `scroll()`. This shifts the responsibility for the problem out of the List element and into consumers of `List`, if you want perfectly smooth scrolling then you need to use `reset()` judiciously and prefer `splice()`. That said, I tested this by aggressively scrolling the Collab panel, and it seems to work as well as it did before. This PR also includes some initial testing infrastructure for working with input from the platform and rendered elements. Release Notes: - N/A |
||
|---|---|---|
| .. | ||
| app | ||
| elements | ||
| keymap | ||
| platform | ||
| text_system | ||
| action.rs | ||
| app.rs | ||
| arena.rs | ||
| assets.rs | ||
| color.rs | ||
| element.rs | ||
| executor.rs | ||
| geometry.rs | ||
| gpui.rs | ||
| image_cache.rs | ||
| input.rs | ||
| interactive.rs | ||
| key_dispatch.rs | ||
| platform.rs | ||
| prelude.rs | ||
| scene.rs | ||
| shared_string.rs | ||
| shared_url.rs | ||
| style.rs | ||
| styled.rs | ||
| subscription.rs | ||
| svg_renderer.rs | ||
| taffy.rs | ||
| test.rs | ||
| text_system.rs | ||
| util.rs | ||
| view.rs | ||
| window.rs | ||