Joseph Lyons
83f9d51dee
Fix layout of elements in the feedback editor's toolbar
...
Co-Authored-By: Kay Simmons <3323631+Kethku@users.noreply.github.com>
Co-Authored-By: Julia <30666851+ForLoveOfCats@users.noreply.github.com>
2023-02-08 21:26:27 -05:00
Mikayla Maki
767d2f9766
Merge pull request #2134 from zed-industries/fix-action-keystroke-bugs
...
Fix several action dispatching bugs
2023-02-08 15:56:50 -08:00
Mikayla Maki
87cf8ac60e
Fixed strange y results from faulty conversion to screen coordinates
...
co-authored-by: Nathan <nathan@zed.dev>
2023-02-07 15:26:03 -08:00
Joseph Lyons
20377ea4e9
Update links to community repository
2023-02-07 18:19:27 -05:00
Mikayla Maki
db2aaa4367
Fixed bug in setting cursor style
2023-02-07 14:35:46 -08:00
Max Brunsfeld
f065399799
Fix crash when unplugging display containing a zed window
...
Co-authored-by: Kay Simmons <kay@zed.dev>
2023-02-06 16:44:06 -08:00
Mikayla Maki
926b59b15d
Fixed a bug where the command palette wouldn't check the keymap context when showing available actions
...
Fixed a bug where context menus wouldn't show action keystrokes
WIP Fixing a bug where tooltips won't show action keystrokes
Co-Authored-By: Max <max@zed.dev>
2023-02-06 15:42:14 -08:00
Petros Amoiridis
433f284571
Merge pull request #2126 from zed-industries/731-make-cursor-visible-immediately
...
Focus the editor when activating previous pane
2023-02-03 10:12:34 +02:00
Petros Amoiridis
8f61134e7e
Allow comparing ViewHandle to AnyViewHandle
...
Since they both have a window_id and a view_id.
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
2023-02-02 20:15:40 +02:00
Kay Simmons
62d32db66c
Make display uuid optional if the display is disconnected
2023-02-01 14:59:43 -08:00
Kay Simmons
ea0dd8972f
Merge pull request #2090 from zed-industries/workspace-window-position-persistence
...
Workspace window position persistence
2023-01-27 15:24:01 -08:00
Kay Simmons
d6acea525d
add test for is_child_focused
2023-01-27 13:00:26 -08:00
Kay Simmons
89a5506f43
Add function which checks if a child of a view is focused and use that to only focus item updates from the leader when that the active item was focused
2023-01-27 12:39:32 -08:00
Kay Simmons
1593b1e13d
window position restoration working
2023-01-26 16:35:00 -08:00
Kay Simmons
a369fb8033
better but still broken
2023-01-25 17:05:57 -08:00
Julia
3819a67185
Add "Close Window" global action which does not need a focused workspace
2023-01-25 18:51:25 -05:00
Kay Simmons
5eac797a93
mostly working now
2023-01-25 11:36:38 -08:00
Kay Simmons
a581d0c5b8
wip
2023-01-25 11:32:19 -08:00
Kay Simmons
15799f7af6
wip
2023-01-25 11:32:19 -08:00
Julia
3d8dbee76a
Clean up some debug printing
2023-01-25 13:37:04 -05:00
Mikayla Maki
ecb7d1072f
Fixes a broken conditional that is only caught on darwin systems
2023-01-25 09:33:07 -08:00
Mikayla Maki
1fc6276eab
Remove debug wiring
2023-01-25 09:10:51 -08:00
Mikayla Maki
45e4e3354e
Changed the presenter to only send 'set_cursor_style' on the topmost window
...
co-authored-by: Antonio <antonio@zed.dev>
2023-01-25 09:10:35 -08:00
Mikayla Maki
27a80a1c94
WIP
2023-01-25 09:10:35 -08:00
Mikayla Maki
426aeb7c5e
WIP - adds platform APIs for checking the top most window
2023-01-25 09:10:35 -08:00
Julia
0414723a54
Decode URL from openURLs
to handle percent encoded paths
...
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
2023-01-24 18:48:15 -05:00
Mikayla Maki
d060114f00
Added complete scripts for generating third party license files
2023-01-23 12:47:12 -08:00
Mikayla Maki
8dcaa81aad
switch return type of accepts_first_mouse
2023-01-20 18:19:24 -08:00
Mikayla Maki
94b2f8e07f
Merge pull request #2054 from zed-industries/notification-mouse-events
...
Notification mouse events
2023-01-20 16:41:27 -08:00
Mikayla Maki
310d867aab
Switch PopUp windows to use the NSTrackingArea API and add support for the mouseExited event
...
Co-authored-by: Antonio <antonio@zed.dev>
2023-01-20 16:35:25 -08:00
Max Brunsfeld
2f42af2ac3
Add confirm_quit setting
2023-01-20 13:02:38 -08:00
Mikayla Maki
8af1294ba5
Changed platform mouse moved handling to only fire on active or popup windows
...
co-authored-by: Antonio <antonio@zed.dev>
2023-01-20 09:37:09 -08:00
Mikayla Maki
5a00729fad
Merge pull request #2051 from zed-industries/show-following-to-followed
...
Show following to followed
2023-01-20 09:23:34 -08:00
Mikayla Maki
97203e1e02
Fix broken merge
2023-01-20 09:19:58 -08:00
Mikayla Maki
95e661a78c
Switched from active hover to NSViews acceptsFirstMouse API
...
Co-authored-by: Nathan <nathan@zed.dev>
2023-01-20 09:14:38 -08:00
Julia
131f3471fc
Don't dispatch mousemove without focus & avoid swallowing external moves
...
Co-Authored-By: Antonio Scandurra <me@as-cii.com>
2023-01-20 10:11:28 -05:00
Mikayla Maki
88170df7f0
Switched from active hover to NSViews acceptsFirstMouse API
2023-01-19 15:21:26 -08:00
Julia
ad1947fa50
Add in-window on-move-out mouse handler concept
2023-01-19 12:34:13 -05:00
Max Brunsfeld
6810490bf4
Remove tree-sitter dependency from gpui
2023-01-16 16:11:13 -08:00
Max Brunsfeld
373902d933
Add '>' child operator in keymap context predicates
2023-01-16 16:00:46 -08:00
Max Brunsfeld
f62d13de21
Use a hand-coded parser for keymap context predicates
2023-01-16 15:53:49 -08:00
Mikayla Maki
febf992a43
Fix bug where keybindings would not show in command palette
2023-01-11 16:35:49 -08:00
Nathan Sobo
3cffee4065
Merge pull request #2011 from zed-industries/project-reconnection
...
Retain connection to remote projects when temporarily disconnected
2023-01-06 18:01:08 -07:00
Nathan Sobo
386f7ba16d
Merge remote-tracking branch 'origin/main' into project-reconnection
2023-01-06 16:52:22 -07:00
Kay Simmons
73e7967a12
working f and t bindings
2023-01-06 14:24:20 -08:00
Max Brunsfeld
b762d70202
Remove unused CallbackCollection method
2023-01-06 11:51:36 -08:00
Max Brunsfeld
53cb3a4429
Remove GC step for callback collections, always drop callbacks asap
2023-01-06 11:33:50 -08:00
Max Brunsfeld
ef192a902a
Remove dropped subscription eagerly when removing callbacks
2023-01-06 11:03:45 -08:00
Max Brunsfeld
4708f5d88f
Add test for notifying and dropping subscriptions in an update cycle
2023-01-06 10:46:03 -08:00
Max Brunsfeld
a165cd596b
Make event tests in gpui more consistent
2023-01-06 10:44:45 -08:00
Max Brunsfeld
3da69117ae
Use a CallbackCollection for action dispatch observations
2023-01-06 09:15:53 -08:00
Max Brunsfeld
82e9f736bd
Use a CallbackCollection for release observations
...
Co-authored-by: Kay Simmons <kay@zed.dev>
2023-01-05 18:02:53 -08:00
Max Brunsfeld
fa620bf98f
Fix logic error in dropping callback subscriptions
...
Co-authored-by: Kay Simmons <kay@zed.dev>
2023-01-05 17:30:39 -08:00
Max Brunsfeld
378f0c32fe
Restructure callback subscriptions
...
Fix a callback leak that would occur when dropping a subscription
to a callback collection after triggering that callback, but before
processing the effect of *adding* the handler.
Co-authored-by: Kay Simmons <kay@zed.dev>
2023-01-05 16:41:23 -08:00
Joseph T. Lyons
bd223f5a1f
Merge pull request #2002 from zed-industries/appease-clippy
...
Appease clippy
2023-01-04 16:33:29 -05:00
Nathan Sobo
a6ffcdd0cf
Track open buffers when handling sync requests
...
When a host sends a buffer to a guest for the first time, they record that
they have done so in a set tied to that guest's peer id. When the guest
reconnects and syncs buffers, they do so under a different peer id, so we
need to be sure we track which buffers we have sent them to avoid sending
them the same buffer twice, which violates the guest's assumptions.
2023-01-02 20:27:59 -07:00
Julia
2b1118f597
Add dismiss buffer search button & fix some faulty icon button styling
...
Co-Authored-By: Nate Butler <nate@zed.dev>
2023-01-01 23:50:46 -05:00
Joseph Lyons
233b28a1b9
Appease clippy
2023-01-01 23:50:45 -05:00
Nathan Sobo
273988b8d5
Set transaction group interval to ZERO by default in tests
...
We were seeing non-deterministic behavior in randomized tests when
generating backtraces took enough time to cause transactions to group
in some cases, but not group in others.
Tests will need to explicitly opt into grouping if they want it by
setting the interval explicitly. We have tests in the text module that
currently test the history grouping explicitly, but I'm not sure
it's needed elsewhere.
2022-12-27 16:47:28 -07:00
Joseph Lyons
21a0df406f
Add home and end key support
2022-12-26 00:24:26 -05:00
Max Brunsfeld
599acf0daa
WIP - Panic immediately when detecting non-determinism via a change to the execution trace
2022-12-23 17:34:13 -08:00
Mikayla Maki
34388a1d31
Updated is_child() to omit self
2022-12-09 12:07:49 -08:00
Kay Simmons
b1e37378dc
Merge pull request #1944 from zed-industries/vim-page-movement
...
Add scroll commands to vim mode
2022-12-08 14:58:19 -08:00
Kay Simmons
10aecc310e
notify views when hover finishes in tooltip wrapper
2022-12-08 11:26:46 -08:00
Kay Simmons
cffb064c16
Refactor editor scrolling and implement scroll commands from vim mode
2022-12-07 16:39:32 -08:00
Antonio Scandurra
9a62150dce
Merge branch 'main' into reconnections-2
2022-12-05 19:18:40 +01:00
Mikayla Maki
4798161118
Distributed database pattern built.
...
Co-Authored-By: kay@zed.dev
2022-12-03 16:06:01 -08:00
K Simmons
0c466f806c
WIP
2022-12-03 16:04:10 -08:00
Antonio Scandurra
969c314315
Merge branch 'main' into reconnections-2
2022-12-02 19:09:33 +01:00
Antonio Scandurra
cd2a8579b9
Capture runnable backtraces only when detecting nondeterminism
2022-11-28 19:35:33 +01:00
Antonio Scandurra
fa3f100eff
Introduce a new detect_nondeterminism = true
attribute to gpui::test
2022-11-28 19:01:28 +01:00
Kay Simmons
75b8a12ab3
address issue where mouse down events weren't getting captured after the multiple handlers change
2022-11-18 13:04:27 -08:00
Julia
6537def97e
Allow having multiple mouse event handlers of the same kind
...
Co-Authored-By: Kay Simmons <kay@zed.dev>
2022-11-17 17:01:34 -05:00
Mikayla Maki
8e6c5dbc3b
Fix unscaled scrolling when using an imprecise mouse wheel
2022-11-16 10:44:13 -08:00
Antonio Scandurra
d275474b23
Don't focus incoming call and project shared notification windows
2022-11-02 14:17:16 +01:00
K Simmons
c5650f9334
remove unnecessary comment
2022-10-27 13:29:57 -07:00
K Simmons
bf968707df
upgrade existing test to match new expected behavior
2022-10-27 13:28:49 -07:00
K Simmons
672b445676
minor tweak to keymap code
2022-10-27 12:36:53 -07:00
K Simmons
e02199fa2a
fixed binding fallback
2022-10-27 12:33:51 -07:00
Mikayla Maki
8d94de8eb2
WIP: Change to matches to vec
2022-10-27 11:27:26 -07:00
K Simmons
ae79b50101
Disallow new keybindings when there are any pending
2022-10-26 16:57:23 -07:00
K Simmons
949a28d49c
wip
2022-10-26 15:57:42 -07:00
Antonio Scandurra
1e85361914
Log instead of panicking when we can't retrieve a drawable
2022-10-26 14:30:48 +02:00
Antonio Scandurra
f611b443c0
Convert window frame rect to screen coordinates
2022-10-26 14:27:53 +02:00
Antonio Scandurra
5a8061ac7b
Add the ability to open a window on a given screen
...
This is done by supplying the screen in the `WindowOptions` struct.
Note that it's optional, and we will let the operating system choose
which screen to show the window on when `screen` is not provided, as
we did before this change.
2022-10-26 12:04:45 +02:00
Antonio Scandurra
ddc71653ad
Maintain scroll position in contacts list
...
Co-Authored-By: Max Brunsfeld <max@zed.dev>
2022-10-25 18:36:33 +02:00
Antonio Scandurra
2b4fd53202
Rename height to z-index
2022-10-25 13:47:12 +02:00
Antonio Scandurra
dfe2fd0386
Allow specifying a custom height for stacking contexts
2022-10-25 13:41:47 +02:00
Antonio Scandurra
2055f05b09
💄
2022-10-25 12:19:25 +02:00
Antonio Scandurra
33ebfc3f10
Rename depth
to height
when referring to stacking contexts
2022-10-25 12:18:23 +02:00
Antonio Scandurra
6a4f3aaa56
Create a SceneBuilder
and sort stacking contexts when calling build
2022-10-25 12:16:09 +02:00
Kay Simmons
68717d0fe8
Merge pull request #1792 from zed-industries/fn-modifier
...
Add fn modifier
2022-10-25 00:35:00 -07:00
K Simmons
82956b618a
remove derive_more
2022-10-25 00:06:43 -07:00
K Simmons
a725ded95e
Add fn modifier to modifier keys in gpui and refactor platform events to use a single modifiers struct
2022-10-24 23:50:39 -07:00
K Simmons
113b7f6f97
tweak drop target overlay color and make stack fully constraint children by the first child
...
's size
2022-10-24 23:47:43 -07:00
K Simmons
aed085b168
remove unnecessary Move branch in dispatch_events
2022-10-24 23:32:01 -07:00
K Simmons
345544646a
remove more notify on moves
2022-10-24 23:32:01 -07:00
K Simmons
4520227e98
remove mouse position from render params
2022-10-24 23:32:01 -07:00
K Simmons
f5795ffc6f
roll back mouse position in mouse_state struct in favor of using the dragged element position
2022-10-24 23:32:01 -07:00
K Simmons
8cde64d3f6
extract dragged item target
2022-10-24 23:32:00 -07:00